chore(coverage): ratchet baseline 58.87 -> 58.88 (measured) - #2362
chore(coverage): ratchet baseline 58.87 -> 58.88 (measured)#2362rubenvdlinde wants to merge 1 commit into
Conversation
Coverage Baseline Check fails on a non-empty git diff after --update-baseline.
Measured 58.88% on two independent development push runs 8h apart
(31050093224 and 31074199287); .coverage-baseline said 58.87.
This RAISES the baseline to the measured value, which is what the job asks for
('The Coverage Baseline Protection job accepts any value that does not LOWER
the baseline'). No threshold weakened, no waiver added.
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 713/713 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-06 06:11 UTC
Download the full PDF report from the workflow artifacts.
|
Heads-up from the ratchet fix (ConductionNL/.github#181, merged): the job this PR closes no longer exists.
The ratchet now measures the merge base on pull requests and compares against that, so the floor cannot go stale and there is nothing for anyone to keep up to date. The push-side staleness job is deleted. This PR is therefore optional, not required — nothing is red waiting on it. It is still safe to merge (raising a floor is always accepted), but it is worth knowing the trade: pinning the floor to today's exact measurement puts the push-side check back on a knife edge, where a single covered statement in either direction is once again meaningful. A floor left below actual coverage is simply conservative and is never what blocks a PR. No action needed either way — flagging so it isn't merged under the belief that it is unblocking something. |
Coverage Baseline Checkis push-only and runscoverage-guard.php --update-baseline, then fails on a non-emptygit diff -- .coverage-baseline. A baseline that is too LOW therefore fails exactly as hard as one that is too high.Measured 58.88% on two independent
developmentpush runs eight hours apart —31050093224(2026-08-05 21:46Z) and31074199287(2026-08-06 05:35Z) — so this is a settled value, not a one-run wobble.This raises the baseline to the measured figure, which is what the job's own error text asks for: "Commit the recomputed value … The Coverage Baseline Protection job accepts any value that does not LOWER the baseline."
No threshold weakened, no waiver, no
continue-on-error, no skip. The ratchet still only moves upward.