Skip to content

chore(coverage): ratchet baseline 58.87 -> 58.88 (measured) - #2362

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/coverage-baseline-58-88
Open

chore(coverage): ratchet baseline 58.87 -> 58.88 (measured)#2362
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/coverage-baseline-58-88

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Coverage Baseline Check is push-only and runs coverage-guard.php --update-baseline, then fails on a non-empty git diff -- .coverage-baseline. A baseline that is too LOW therefore fails exactly as hard as one that is too high.

Coverage baseline: 58.87%
Coverage current:  58.88%

Measured 58.88% on two independent development push runs eight hours apart — 31050093224 (2026-08-05 21:46Z) and 31074199287 (2026-08-06 05:35Z) — so this is a settled value, not a one-run wobble.

This raises the baseline to the measured figure, which is what the job's own error text asks for: "Commit the recomputed value … The Coverage Baseline Protection job accepts any value that does not LOWER the baseline."

No threshold weakened, no waiver, no continue-on-error, no skip. The ratchet still only moves upward.

Coverage Baseline Check fails on a non-empty git diff after --update-baseline.
Measured 58.88% on two independent development push runs 8h apart
(31050093224 and 31074199287); .coverage-baseline said 58.87.

This RAISES the baseline to the measured value, which is what the job asks for
('The Coverage Baseline Protection job accepts any value that does not LOWER
the baseline'). No threshold weakened, no waiver added.
@rubenvdlinde
rubenvdlinde requested a review from a team as a code owner August 6, 2026 05:41
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 2b8e781

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-specs
test-l10n
composer ✅ 173/173
npm ✅ 713/713
PHPUnit
Newman
Playwright
Hydra gates

Quality workflow — 2026-08-06 06:11 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Heads-up from the ratchet fix (ConductionNL/.github#181, merged): the job this PR closes no longer exists.

Coverage Baseline Check failed when the committed value was stale — i.e. when coverage had gone up. That, together with the phpunit guard failing when coverage went down, demanded exact equality with a checked-in constant, which against a moving base branch is not satisfiable. Six of sixteen apps were red on it simultaneously, every one for coverage being higher than recorded, three of them by 0.01–0.02%.

The ratchet now measures the merge base on pull requests and compares against that, so the floor cannot go stale and there is nothing for anyone to keep up to date. The push-side staleness job is deleted. .coverage-baseline remains only as a conservative fail-safe floor on pushes.

This PR is therefore optional, not required — nothing is red waiting on it. It is still safe to merge (raising a floor is always accepted), but it is worth knowing the trade: pinning the floor to today's exact measurement puts the push-side check back on a knife edge, where a single covered statement in either direction is once again meaningful. A floor left below actual coverage is simply conservative and is never what blocks a PR.

No action needed either way — flagging so it isn't merged under the belief that it is unblocking something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant