fix(license): delete the Nextcloud GmbH SPDX residue instead of relabelling it - #2356
Merged
Merged
Conversation
…ng it PR #2350 flipped 'SPDX-License-Identifier: AGPL-3.0-or-later' to EUPL-1.2 in 12 files whose adjacent line reads 'SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors'. That asserted EUPL-1.2 over a third party's copyright — a false licence claim, and worse than the AGPL contradiction it replaced. This deletes the residue block rather than relabelling it. Evidence that the block is copy-paste residue from the Nextcloud app template, not a real Nextcloud GmbH copyright: - It occurs in exactly 12 source files; the only other 'Nextcloud GmbH' strings in the repo are dependency author fields in bom-npm-test.cdx.json, which is an SBOM of real Nextcloud npm packages and is left untouched. - 11 of the 12 already carry their own '@copyright 20xx Conduction B.V.' PHPDoc tag in the same file, directly contradicting the SPDX line. - The full git history of all 12 files contains no Nextcloud GmbH author: only Conduction people (Barry Brands, Conduction Development Team, Remko, Robert Zondervan, Ruben van der Linde, Thijn) and the CI bot. - The repo's other ~270 PHP files carry Conduction copyright only, with no SPDX pair at all — this is the app-template scaffold the rest shed. tests/Unit/Controller/SettingsControllerTest.php had no other licence header, so it gains the repo's standard test-file PHPDoc rather than being left bare. No licence value is changed by this commit; the false claim is removed.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 713/713 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-05 21:07 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Merging: 27 SUCCESS / 4 SKIPPED / 0 failures.
This removes a false licence claim that is live on No conflict with #2345 — that PR is CLOSED, and its 32 files have zero overlap with these 12. |
rubenvdlinde
added a commit
that referenced
this pull request
Aug 5, 2026
#2356 landed the same 12 Nextcloud GmbH SPDX residue files while this branch was in flight, deleting the stray block rather than correcting the holder. Both remove the false third-party licence claim, which is the load-bearing outcome, so this takes development's version verbatim and drops the duplicate work here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
PR #2350 (mine) flipped
SPDX-License-Identifier: AGPL-3.0-or-later→EUPL-1.2in 12 files whose adjacent line reads:That made
developmentassert EUPL-1.2 over Nextcloud GmbH's copyright — a false licence claim over a third party's work, and strictly worse than the AGPL contradiction it replaced. I should have treated the copyright line as a stop sign instead of editing past it.This PR deletes the residue block rather than relabelling it. No licence value is changed here; the false claim is removed.
Evidence that the block is app-template residue, not a real Nextcloud GmbH copyright
Nextcloud GmbHstrings in the repo are dependencyauthorfields insidebom-npm-test.cdx.json— an SBOM of genuine Nextcloud npm packages, correctly left untouched.@copyright 2024 Conduction B.V.,@copyright 2026 Conduction B.V.), directly contradicting the SPDX line.git log --followacross all of them yields only Conduction people — Barry Brands, Conduction Development Team, Remko, Robert Zondervan, Ruben van der Linde, Thijn — plus the CI bot.nextcloud/app-templatescaffold that the rest of the codebase already shed.What changed per file
lib/Migration/Version1Date*.php— a standalone/* SPDX… */comment sitting below an existing full Conduction PHPDoc header; the stray comment is deleted.lib/Db/Webhook.php,lib/Migration/Version002003000Date20251013000000.php— the SPDX pair were the first two lines inside the main PHPDoc, which already carries@author/@copyright/@license; those two lines are removed and the rest of the docblock is untouched.tests/Unit/Controller/SettingsControllerTest.php— this one had no other licence header, so deleting outright would have left it unlicensed. It gains the repo's standard test-file PHPDoc (matchingtests/Unit/Activity/FilterTest.php) instead.Verification
Nextcloud GmbHoccurrences remaining underlib/ src/ tests/ appinfo/: 0@license EUPL-1.2and@copyright: confirmed file by filephp -lclean on all 12A fleet sweep of the other 15 apps found no remaining
Nextcloud GmbHcopyright line in any app's source, so openregister was the only repo affected.