fix(ci): beta's branch-protection caller is dead twice over — wrong job id AND the retired Codeberg org - #257
Merged
Conversation
…+ retired org) 1. Job id `protect` emitted `protect / check-branch`; the org rulesets require `branch-protection / check-branch`, so the required context never reported and PRs to main/beta sat permanently pending. 2. `uses: Conduction/.github/...` names the RETIRED Codeberg org. On GitHub the org is `ConductionNL`, so Actions could not resolve the reusable workflow at all and the run produced zero jobs. Deliberately narrow: seven other workflows on this branch (code-quality, documentation, issue-triage, openspec-sync, release-beta, release-stable, sync-to-beta) still carry the same retired org name. Correcting those would switch real test/lint gates back on for a branch that has been stale since March, which is a separate change that needs its own red/green triage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem — two independent faults, either fatal on its own
beta's.github/workflows/branch-protection.ymlcould not satisfy the required check for two separate reasons:<caller-job-id> / <called-job-name>. The org rulesets Main Branch Protection and Beta Branch Protection requirebranch-protection / check-branch, but the caller job was namedprotect, so the emitted context wasprotect / check-branch. The required context never reported at all — PRs tomain/betasat permanently pending and only--admincould ship them.uses: Conduction/.github/...names the retired Codeberg org. On GitHub the org isConductionNL, so from commite2faa092("org rename") Actions could not resolve the reusable workflow at all — the run produced zero jobs.Live evidence: PR #90 (
development → beta, open since March) has 34 status checks and not one of them isbranch-protection / check-branch.Fix
protect→branch-protection,Conduction→ConductionNL.Deliberately narrow — please read
Seven other workflows on
betastill carry the retired org name:code-quality.yml,documentation.yml,issue-triage.yml,openspec-sync.yml,release-beta.yml,release-stable.yml,sync-to-beta.ymlThey are not touched here on purpose. Correcting them would switch real lint/test/release gates back on for a branch that has been stale since March, and that needs its own red/green triage rather than being smuggled in behind a branch-protection fix.
Safety
Making a never-reporting check report is only safe if it will pass. The shared
check-branchjob requires PRs tobetacome fromdevelopment,main, orhotfix/*. This PR is fromhotfix/*, and larpingapp has bothdevelopmentandbeta, so the topology holds. (petstore had neither branch — a second, independent fault there.)