Skip to content

T3646 FIX B2S letter pages from Cloudinary and faster reports of the communications - #2206

Merged
ecino merged 2 commits into
18.0from
T3646-cloudinary-page-seams
Nov 5, 2026
Merged

ecino merged 2 commits into
18.0from
T3646-cloudinary-page-seams

Conversation

@ecino

@ecino ecino commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

T3646

  • Find the pages in the stacked Cloudinary image from their borders (pages of different heights were cut in equal parts). Connect is the fallback if they can't be found.
  • Add a print_delay field on the reports (partner_communication), set to 0 by an end-migration for all the reports of the communications: wkhtmltopdf has nothing to wait for and each report is generated about 2 seconds faster.
  • Set it to 0 for the reports of child_compassion and the correspondence report from partner_communication_compassion.

Related PRs: CompassionCH/compassion-switzerland#1893, CompassionCH/compassion-nordic#105

The pages of a letter are stacked in one image with pages of different
heights, which were cut in equal parts. The borders between the pages are
detected, and the page is fetched from Connect if they can't be found.

Assisted-by: claude-sonnet-5-5, medium, claude-code
wkhtmltopdf waits 1 second (and costs 2 seconds) for the javascript of the
reports, which have none. The delay can be set for each report and the
migration sets it to 0 for the reports of the communications.
@ecino
ecino force-pushed the T3646-cloudinary-page-seams branch from 558d2f2 to f773ee9 Compare November 5, 2026 14:11
@ecino
ecino marked this pull request as ready for review November 5, 2026 14:13
@ecino
ecino merged commit 6fb3b04 into 18.0 Nov 5, 2026
1 check passed
@ecino
ecino deleted the T3646-cloudinary-page-seams branch November 5, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant