Repository navigation
T3646 FIX: Compose letter issues, allow overlay on project gift letters - #2204
Merged
Merged
Conversation
Translations saved on extra scanned pages were missing from the PDF. - Spread the translation into the boxes before printing, like v14 (writes once per letter). - Text under 5 characters stays put, so no more empty pages.
Member
Author
|
@ecino If you agree with this change I will test on stage and the merge into prod |
Danielgergely
marked this pull request as draft
November 5, 2026 08:09
Print the page images at an absolute width so that they never overflow on the next page, and fetch the page from Connect first when the Cloudinary image is a crop of a stack of pages (pages of different heights were cut wrongly). Assisted-by: claude-sonnet-5-5, medium, claude-code
Assisted-by: claude-sonnet-5-5, medium, claude-code
Assisted-by: claude-sonnet-5-5, medium, claude-code
ecino
changed the title
The Source PDF is never modified and the translation is composed on top of it at 150 dpi, until a final letter PDF is set, which is then used as it is. Assisted-by: claude-sonnet-5-5, medium, claude-code
A blank line adds one line to the gap and several blank lines in a row are reduced to one. The measure of the text boxes follows the same rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translations saved on extra scanned pages were missing from the PDF.
Tickets: T3616, T3646
Related PR: CompassionCH/compassion-switzerland#1891 (sbc_switzerland, T3646)