Skip to content

T3417 thankyou config model #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielgergely merged 5 commits into from
Nov 4, 2026
Merged

T3417 thankyou config model #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6af9a57
[T3417] FIX: thank-you crashes when a third party letter is pending
Danielgergely Oct 30, 2026
6cfb999
[T3417] FIX: Christmas letters released for suspended projects
Danielgergely Oct 30, 2026
2ce1cf6
[T3417] FIX: thank-you crashes when a third party letter is pending
Danielgergely Oct 30, 2026
4b87d7d
[T3417] FIX: Christmas letters released for suspended projects
Danielgergely Oct 30, 2026
fccf65d
Merge branch 'T3417-thankyou-config-model' of github.com:compassionch…
Danielgergely Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sbc_compassion/models/correspondence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1364,6 +1364,8 @@ def check_postponed_christmas_letters(self):
("kit_identifier", "=", False),
("state", "=", "Exception"),
("on_hold", "=", True),
# Released with the project reactivation instead
("child_id.project_id.hold_s2b_letters", "!=", True),
]
)
correspondences.reactivate_letters(_("Christmas period started"))
Expand Down
9 changes: 8 additions & 1 deletion thankyou_letters/models/account_move_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,14 @@ def generate_thank_you(self):

all_thanks_config_ids = (
self.env["partner.communication.config"]
.search([("send_mode_pref_field", "like", "thankyou_preference")])
.search(
[
("send_mode_pref_field", "like", "thankyou_preference"),
# Other configs (e.g. third party letters on res.partner)
# share the preference field but not the model.
("model_id.model", "=", self._name),
]
)
.ids
)

Expand Down
Loading