Skip to content

[T3539] FIX: don't crash child creation on a photo download timeout #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Danielgergely merged 2 commits into from
Nov 4, 2026
Merged

[T3539] FIX: don't crash child creation on a photo download timeout #2201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7639229
[T3539] FIX: don't crash child creation on a photo download timeout
Danielgergely Nov 4, 2026
8a4ecfa
Merge branch '18.0' into T3539-child-picture-timeout
Danielgergely Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions child_compassion/models/child_pictures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
##############################################################################
import base64
import logging
from urllib.error import HTTPError, URLError
from urllib.request import Request, urlopen

from odoo import _, api, fields, models
Expand Down Expand Up @@ -187,6 +186,7 @@ def _get_picture(self, pic_type="Headshot", width=300, height=400):
self.headshot = data
elif pic_type.lower() == "fullshot":
self.fullshot = data
except (AttributeError, ValueError, URLError, HTTPError, TypeError):
# OSError also covers URLError/HTTPError and read timeouts (TimeoutError)
except (AttributeError, ValueError, OSError, TypeError):
logger.error("Failed to fetch image from %s", self.image_url, exc_info=True)
return _image_date
4 changes: 4 additions & 0 deletions crm_compassion/data/demand_planning.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
<field name="name">Demand planning: correct negative resupply</field>
<field name="model_id" ref="model_demand_weekly_demand" />
<field name="trigger">on_create_or_write</field>
<field
name="trigger_field_ids"
eval="[(6, 0, [ref('crm_compassion.field_demand_weekly_demand__resupply_events')])]"
/>
<field name="filter_domain">[('resupply_events', '&lt;', 0)]</field>
<field name="action_server_ids" eval="[(6,0,[ref('crm_compassion.correct_resupply_event_action')])]"/>
</record>
Expand Down
Loading