Skip to content

T3616 overlay followups - #2199

Merged
Danielgergely merged 5 commits into
18.0from
T3616-overlay-followups
Nov 3, 2026
Merged

T3616 overlay followups#2199
Danielgergely merged 5 commits into
18.0from
T3616-overlay-followups

Conversation

@Danielgergely

@Danielgergely Danielgergely commented Nov 3, 2026

Copy link
Copy Markdown
Member

Follow-up of #2195 / #2197.

  • Extra scanned pages: no translation box on scanned pages beyond the template; the text moves to an added page instead of covering the child's page (2,182 letters).
  • Stored GMC PDF: render our translation instead of the stored sponsor_letter_scan when all page images load (~13,600 older letters).
  • Image download: a network error on a Cloudinary image no longer crashes the PDF.

@Danielgergely

Danielgergely commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Tested on stage

@Danielgergely
Danielgergely marked this pull request as ready for review November 3, 2026 14:54
@Danielgergely
Danielgergely merged commit d5d5766 into 18.0 Nov 3, 2026
1 check passed
@Danielgergely
Danielgergely deleted the T3616-overlay-followups branch November 3, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Danielgergely @ecino