Repository navigation
Fix pkgdown deployment: split single job into build + deploy - #24
Merged
Merged
Conversation
…tection issue Co-authored-by: jeffstang <22566396+jeffstang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pkgdown URL generation issue
Fix pkgdown deployment: split single job into build + deploy
Mar 2, 2026
jeffstang
marked this pull request as ready for review
March 2, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #23 placed
environment: github-pageson the singlepkgdownjob, which applied deployment protection to the build step as well — causing PR workflows to block onaction_requiredapproval. The PR's own description identified the correct fix but the diff never implemented it.Changes
Split
pkgdowninto two jobsbuild: runs on all events (PRs + pushes); builds the site and uploads the Pages artifact viaactions/upload-pages-artifact@v3; no environment protectiondeploy: runs only on non-PR events; depends onbuild; carriesenvironment: github-pagesand deploys viaactions/deploy-pages@v4Updated workflow-level
permissionsfromread-allto explicit scopes (contents: read,pages: write,id-token: write) required byactions/deploy-pagesGitHub Pages source must be set to "GitHub Actions" in Settings → Pages → Source.
actions/deploy-pagesrequires this; the oldJamesIvesaction pushed to agh-pagesbranch instead.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.