Repository navigation
fix(cursor-review): retry the review POST on a 5xx or transport error #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-byrne
wants to merge
1
commit into
main
Choose a base branch
from
fix/cursor-review-post-retry-5xx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The budget comment does not hold for the hung-
ghcase.The comment says three attempts plus the reads "must still fit well inside" the 10-minute job limit. Check the worst case where
ghhangs every time:gh_post_reviewcall: 3 × 60s POST + 2 × 60s reads + 5s + 15s sleeps = 320s.gh_post_reviewagain for another 320s.The total is about 700s, which is over 600s. The job timer would kill the process before
write_step_summary. Then the findings are lost from both channels. This is the exact loss thePostTimeoutTestdocstring warns about. The case is rare (it needs repeated hangs, not fast 502s), but the comment overstates the safety.Add a wall-clock cap for the wrapper. Skip further retries once the elapsed time passes a fixed budget (e.g. 90s). Or correct the comment. A time budget keeps the retries on a short leash.
🔧 Example: bound the total retry time
The harness fakes
time.monotonic, so check the new tests against it.Committable suggestion