Skip to content

feat: count superseded reviews toward the cap - #457

Draft
huang47 wants to merge 1 commit into
codex/cursor-three-reviewfrom
codex/cursor-count-superseded
Draft

huang47 wants to merge 1 commit into
codex/cursor-three-reviewfrom
codex/cursor-count-superseded

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

A review does not stop costing effort simply because a new commit arrived before the result was acted on. Callers can choose to count that delivered review toward their limit instead of treating it as a free extra round.

Motivation

A review limit can serve as a budget for delivered reviews. Excluding a delivered review after the head moves makes that budget less predictable. Callers that need the existing behavior keep it by default.

Provenance

  • Authored by: interactive session
  • Verified: Cursor review suite passed 1,754 tests, including a regression that distinguishes the default behavior from the opt-in. Workflow documentation and pin suite passed 551 tests (43 skipped). Workflow pin, agent-instruction and repository-literal checks passed. Local actionlint reported the same 98 diagnostics as the base, with no new diagnostics.
  • Deviations: The option does not count undelivered panels, prevent a human reset, serialize concurrent runs, or cover other review systems. It is not a lifetime execution cap. Current-head CI passed; CodeRabbit was skipped. A live caller run has not been verified.

Reviewer context

Summary

  • Let callers include delivered reviews whose decisions observed a moved head in the existing review counter.
  • Keep the previous default and document both the option and its boundaries.

Test plan

  • Exercise the opt-in with a delivered review followed by a moved-head decision.
  • Verify callers that omit it retain the existing counter behavior.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant