Skip to content

fix: retain highest severity in degraded review deduplication - #455

Draft
huang47 wants to merge 3 commits into
mainfrom
codex/cursor-fallback-finding-identity
Draft

huang47 wants to merge 3 commits into
mainfrom
codex/cursor-fallback-finding-identity

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

If the judge cannot consolidate findings, the fallback combines the panel's output. Previously, identical findings with different severities kept whichever came first, which could hide a higher severity. The fallback now keeps one finding at the highest reported severity.

Summary

Input Before After
Same file, line and body: low then high Only low retained Only high retained
Same finding: high then low Only high retained Only high retained
Unknown severity Could be discarded as a duplicate Retained for downstream handling

Severity ordering comes from the structured-output schema. The normal judge and publication rules are unchanged. This matches exact file, line and body; semantic duplicate removal still depends on the judge. Revert this PR to restore the previous fallback.

Stack order: 1/1, independent.

Verification

  • The real workflow step regression failed on the prior draft and passed here for both input orders.
  • Full cursor-review suite passed (1,746 tests); workflow pin, agent instruction and public-repo literal checks passed.
  • Local actionlint reports the same 98 existing diagnostics on main and this branch; no new diagnostics. Current-head CI passed, including the reviewer script suite; CodeRabbit skipped.
  • GitHub review publication and an actual judge failure were not exercised.

Provenance

Authored in an interactive code review implementation session.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@huang47 huang47 changed the title fix: preserve severity in degraded review deduplication fix: retain highest severity in degraded review deduplication Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant