Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A review only counts as an approval when the person can approve for that repository. The shadow report checks current access for each current human approval and waits when it cannot determine access.
Summary
Read repository base permissions for current human, non-author approvals. Count write, maintain or admin access; exclude lower access. Missing, malformed or unavailable responses leave approval evidence incomplete, while observed change requests still block. Limit lookups and stop after an error.
Verification
64 readiness tests cover real collector and evaluator integration, lower and missing permissions, mismatched identity, stale reviews, bounded reads and preserved blockers. Removing the access check in a disposable copy made the lower-access regression fail. A read-only current PR with a current human approval exercised the real permission endpoint and returned
WAITINGfor other missing evidence. Repository lint checks passed. Current-head CI passed, with CodeRabbit skipped. The shadow workflow run produced a WAITING report for this draft; no human approval was present, so it did not call the permission endpoint.Limits
This verifies repository base permission, not code-owner requirements or the complete ruleset. It does not prove a tested revision or authorize merging. Reads are non-atomic; the reusable workflow token's access to this endpoint is not yet established with a real approved PR. No pilot or policy change is included.
Stack
Stack order: 8/9. Parent: #452 — fix: keep unverified approvals incomplete. Followed by #454, which keeps User approvals incomplete until human identity is established. Allowed effects: read GitHub permissions and retain the shadow report. Revert this commit to return to the parent behavior.
Provenance