Skip to content

feat: collect scoped GitHub review evidence - #448

Draft
huang47 wants to merge 1 commit into
codex/readiness-from-riskfrom
codex/readiness-review-inventory
Draft

huang47 wants to merge 1 commit into
codex/readiness-from-riskfrom
codex/readiness-review-inventory

Conversation

@huang47

@huang47 huang47 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

A review decision can be out of date, and a long discussion can span multiple pages. Read the current PR, reviews and review threads, then check the PR revision again before using what was collected.

collector-flow

Summary

  • Collect paginated GitHub reviews and threads for a supplied snapshot. Count only current-head submitted human decisions and report collection failures explicitly.
  • Keep known open, current threads blocking even if a later page fails; discard collected evidence if the snapshot changes or cannot be rechecked.
  • Keep the findings inventory incomplete and checks missing. This read-only entry point can return BLOCKED or WAITING, never READY.

Verification

  • 39 Python tests passed, including a CLI test with paginated GitHub responses. The tests cover stale and dismissed approvals, identity, page failure, known blockers and changed snapshots.
  • Removing the final snapshot guard in a disposable copy caused the snapshot tests to fail.
  • A read-only live run against a draft PR using a synthetic policy observed matching revisions and returned WAITING for missing evidence.
  • Repository pin, agent and literal checks passed.

Limits

GitHub review threads are only one finding source. Review permissions, branch protection, tested revision and policy ownership are not verified. Separate reads are not atomic: reviews can change during collection and an ABA branch change can escape the recheck. The collector does not publish a report or gate merges.

Stack

Stack order: 4/9, follows #447 — feat: evaluate scoped review readiness evidence; followed by #449 — feat: retain integrated review shadow reports.

Provenance

Implemented and verified with an interactive coding agent and human direction. Recovery: revert this PR; no configuration or GitHub state is changed by the collector.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant