Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A risk report records the change being reviewed, but it did not say which base revision was visible when it was collected. This adds that observation so readers can identify the comparison point while keeping its limits explicit.
Motivation
A risk record is easier to interpret when both sides of the change have revision identifiers. Other reads in the grading process happen separately, so recording the base alone does not establish that the whole record is an atomic snapshot.
Provenance
3433be9997a2431564eeb080f29109e1c90f4b55(same tree tested before commit).Reviewer context
Summary
observed_base_shato live schema 5 risk records, ornullwhen unavailable.Recovery
Revert this change to restore the previous record shape. Consumers should tolerate records without the field.