Repository navigation
feat(cursor-approve): show each axis's full first sentence and its full reasoning on the card (BE-20249) - #413
Merged
Conversation
…ll reasoning on the card (BE-20249) The status card's Why cell showed the axis headline clamped at 100 characters, which cut the models' ordinary one-sentence reasons mid-thought; the full summary sat only in the run's job summary. - aggregate.py: HEADLINE_MAX 100 -> 240. The clamp keeps every whole sentence that fits (no "…"; abbreviations such as "e.g." are not sentence ends) and only word-cuts a first sentence longer than the cap. - card.py: the Why cell renders the whole clamped headline; under the result, one collapsed <details> block per axis carries its sanitised full summary and confidence; the decide card links "workflow run" on the reviewed-commit line like every other card (the rule line no longer carries the link). - prompt-common.md: one sentence, aim for ~120 characters, never more than 240; the summary is now shown collapsed on the card. - Docs and workflow header comments updated; tests cover the clamp, the cell, the blocks (including a port of the fleet's row parser to prove model text cannot add an axis row) and the run link.
Contributor
|
Warning Review limit reached
This review includes 9 billable files and costs up to $2.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 33 minutes for your next included review. View limit details
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
| ⚪ Nit | 3 |
Panel: 5/6 reviewers contributed findings.
Reviewers that did not contribute: kimi-k3-max:adversarial (error)
…Why fallbacks (BE-20249) Review round on #413: - a sentence cut keeping fewer than four words ("OK.") falls through to the word cut instead of leaving a reason-free headline; - initialisms, one-character initials/list numbers and ellipses no longer end a sentence; a closing quote/bracket after the mark does; `etc.` ends one before a capital; - a word-less headline is rejected at any length, not only past the cap; - the Why cell falls back to the summary's first sentence when the clamp rejects the headline, and the job summary reuses why_text so both surfaces show the same headline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI-5
The approve bot keeps one status card on each PR. The card has a table with a row per reviewer axis (correctness, conformance, …) and a short reason for each verdict. That reason was chopped at 100 characters, so it usually stopped mid-sentence ("… the cache is still not wired into…"). The full explanation was only in the Actions run.
Now the row shows the whole sentence. Under the result there is a collapsed "full reasoning" section for each axis, which you can open right on the PR.
What changed
aggregate.py.,!or?followed by whitespace ends a sentence, including after a closing quote or bracket.e.g.,i.e.,vs., …), initialisms (U.S.), one-character initials and list numbers (J.,2.) and ellipses do not. Neither does a decimal or a mid-word dot, since no space follows it.etc.ends a sentence only before a capital.card.pyWHY_LIMITthat a test pins equal toHEADLINE_MAX. A headline that is missing or that the clamp rejects falls back to the summary's first sentence.<details>block per axis that reported a summary. It holds the sanitised fullsummaryand the confidence.why_text), so the two always match.prompt-common.md: the headline is ONE sentence, aiming for about 120 characters and never more than 240. The summary is now described as shown collapsed on the card.docs/callers/cursor-approve.md(the headline/card passage and the 240 cap), the.github/cursor-approve/README.mdfield table, and the header comments incursor-approve.ymlandcursor-axis-base.yml.Why
BE-20249.
Design notes
| Axis | Verdict | Why |rows are as before. Only the cell text can be longer.sanitize, which folds it to one line and escapes every|and<.awk -F'|'row parser line for line. It proves a summary that carries a forged row, a forged state marker,</details>, a heading, a mention or the card marker changes nothing an agent reads.prior_roundson, the summary was also already in the card's base64 sentinel.Coordination
This touches
.github/cursor-approve/card.pyalongside #412 (BE-20246)._reviewed_linekeeps its signature, which feat(cursor-review): link every auto-approve review to the cursor-approve card (BE-20246) #412'srender_pendinguses.main(ebd6a64, which includes feat(cursor-review): link every auto-approve review to the cursor-approve card (BE-20246) #412) is clean, and the cursor-approve and workflow-pins suites andcheck_workflow_pins.pypass on the merged tree.Testing
python3 -m unittest discover -s .github/cursor-approve/tests -p 'test_*.py': 267 OK on the current head. New cases:?, abbreviations, initialisms, initials and list numbers, ellipses, closing quotes and brackets,etc.before a capital, decimals and file names, a short lead, a cut that keeps no word, a word-less headline within the cap, and decide end to end);WHY_LIMITandHEADLINE_MAX;.github/cursor-review/tests: 1527 OK..github/workflow-pins/tests: 551 OK (43 skipped).check_workflow_pins.pyOK..github/agents-md-integrity/tests: 62 OK.check_agents_md.pypassed, with the same 2 warnings as main (line count, no CODEOWNERS)..github/public-repo-hygiene/tests: 204 OK.check-org-repo-literals.shOK.shellcheckOK.Sample: a two-axis pass card as rendered (markdown)
Rollout
Callers get this on their next SHA bump. There are no new inputs. The 240 cap and the prompt wording apply from the next round.
Provenance
.github/cursor-approve/tests: 267 OK on the current head..github/workflow-pins/testsOK;check_workflow_pins.py,check_agents_md.py(same 2 warnings as main) andcheck-org-repo-literals.shpass.🤖 Generated with Claude Code