Repository navigation
fix(cursor-axis-base): carry the Cursor CLI pin forward to match cursor-review - #383
Conversation
…or-review `cursor-review.yml` moved the pinned Cursor CLI to 2026.10.01-e373342 in #335 and `cursor-axis-base.yml` was not carried along, so the two workflows have been installing different CLI builds since then. `test_cli_pin_matches_cursor_review` asserts the pair is equal — the comment above the pin says so too ("Same pin as cursor-review.yml's (a test keeps them equal)") — so this has been failing `Test cursor-review scripts / unittest + shellcheck` on every PR in the repo, independently of what the PR changes. Syncs the version and its SHA256 forward to the values cursor-review.yml already pins. No other change: the axes now install the same build the panel does. cursor-approve suite: 166 tests, OK (was 1 failure). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for one more day.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for one more day. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 16 minutes for your next included review. Limit details: You’ve used the included review currently available. Your 130 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 4/6 reviewers contributed findings.
Reviewers that did not contribute: kimi-k3-high:adversarial (error), kimi-k3-high:edge-case (error)
| # .github/cursor-review/install-cursor-cli.sh. | ||
| CURSOR_CLI_VERSION: 2026.09.10-fd3934a | ||
| CURSOR_CLI_SHA256: 27997c8391ad853a5a732b1845db8ef82a8ba6afb0f7829cc739464f8966e96e | ||
| CURSOR_CLI_VERSION: 2026.10.01-e373342 |
There was a problem hiding this comment.
🟢 Low — This hand-sync fixes the current drift, but the root cause is still there. bump-cursor-cli-pin.yml reportedly rewrites only .github/workflows/cursor-review.yml (its WORKFLOW_FILE is hardcoded). If so, the next automated bump will move that file alone, fail test_cli_pin_matches_cursor_review, and leave the cursor-approve axes on a stale CLI until someone copies the pin over by hand again. Consider making the bumper rewrite CURSOR_CLI_VERSION/CURSOR_CLI_SHA256 in cursor-axis-base.yml in the same commit. Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh edge-case).
What
Two lines in
.github/workflows/cursor-axis-base.yml: the pinned Cursor CLI version and its SHA256, moved forward to the valuescursor-review.ymlalready pins.CURSOR_CLI_VERSION2026.09.10-fd3934a2026.10.01-e373342CURSOR_CLI_SHA25627997c83…66e96ea79726c6…66ae28e8Why
cursor-review.ymlwas bumped in #335 and this file was not carried along, so the panel and the approve axes have been installing different CLI builds since then.test_cli_pin_matches_cursor_reviewasserts the two are equal, and the comment above the pin states the same intent — "Same pin as cursor-review.yml's (a test keeps them equal)". That test has therefore been failingTest cursor-review scripts / unittest + shellcheckon every PR in this repo regardless of its contents, which makes a genuine regression in that job easy to miss.Forward is the correct direction:
cursor-review.ymlis already on the October build, and these values are the ones it pins.Verification
cursor-approvesuite: 166 tests, OK (1 skipped) — was 1 failure,test_cli_pin_matches_cursor_review.Note for reviewers
This moves the CLI build underneath the approve axes, not just the panel — worth a glance if anything depended on the September build. Nothing in the repo appears to, and the test's existence says equality is the intended invariant.
🤖 Generated with Claude Code