Skip to content

fix(cursor-approve): keep Slack out of the business axis - #376

Merged
mattmillerai merged 2 commits into
mainfrom
matt/axis-business-drop-slack
Oct 8, 2026
Merged

mattmillerai merged 2 commits into
mainfrom
matt/axis-business-drop-slack

Conversation

@mattmillerai

@mattmillerai mattmillerai commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

ELI-5

The business reviewer decides whether a change was actually wanted. One place it looked for that was Slack. Slack is where people argue before they decide, and anyone can post there, so it's a poor record of intent and an easy thing to game or inject into. This PR has the business reviewer use Linear and Notion only.

Change

  • axis-business.yml: context_sources: linear,notion (it was linear,notion,slack). It no longer forwards SLACK_TOKEN. The secret stays declared as optional and unused, so an existing caller's SLACK_TOKEN: line is not rejected at startup. The header says why.
  • cursor-axis-base.yml: rejects slack in context_sources, so a direct caller of the public base cannot turn Slack back on either.
  • docs/callers/cursor-approve.md, README.md and .github/cursor-approve/README.md: drop Slack from the business row, the caller example and the context-axes intro, and add a short "No axis reads Slack" note.
  • test_context_axes.py: separates declared secrets from forwarded ones, and pins that the base rejects slack and no wrapper enables it.

Why

  • Not authoritative. Decisions land in a ticket, PRD or TDD. Using a thread as proof that a change was wanted rewards opening a thread just to get a PR approved. It also penalizes work that never had one, such as infra and CI changes.
  • Injection surface. Anyone in a channel can write text the approver will read while it holds company context.

Compatibility

No caller wires axis-business.yml yet; a search across the org finds only this repo's own references. Even so, SLACK_TOKEN stays declared, so a caller that passes it keeps working. The proxy's slack_search / slack_history and the base's optional SLACK_TOKEN declaration are left in place; removing them can be a separate cleanup.

Provenance

Authored by: agent-work loop
Verified:

  • python3 -m unittest discover -s .github/cursor-approve/tests -p 'test_*.py': 164 tests OK at head.
  • check_workflow_pins.py and check_agents_md.py --root .: clean.
  • PR CI: all checks passing at head.

Deviations:

  • Review round: kept SLACK_TOKEN declared (unused) instead of removing it, and added the base-level slack rejection.

🤖 Generated with Claude Code

The business axis searched Slack for evidence that a change was wanted.
Slack is where people debate before deciding, not a record of the
decision: that lands in a ticket, PRD or TDD. Reading threads as intent
rewards opening a thread to get a PR approved, and flags work (infra, CI)
that never had one; and anyone in a channel can post text the approver
then reads.

The business axis now gets Linear and Notion only, and no longer declares
or forwards SLACK_TOKEN. No caller wires axis-business.yml yet, so nothing
breaks. The proxy's slack tools and the base's SLACK_TOKEN input stay, but
no shipped axis enables them.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review paused — included plan limit reached

Keep your review moving with free on-demand reviews.

  • Run this review for free

On-demand reviews are free for the next 2 days.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Promotion and pricing details

On-demand reviews are free for the next 2 days. After that, they cost $0.25 per reviewed file.

Review limit details

Or wait 24 minutes for your next included review.

Check out review usage here.

Limit details: You’ve used the included review currently available. Your 130 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: b9f3e360-624c-4406-bec7-ab03580dd9c6
📥 Commits

Reviewing files that changed from the base of the PR and between 100472a and b251b77.

📒 Files selected for processing (6)
  • .github/cursor-approve/README.md
  • .github/cursor-approve/tests/test_context_axes.py
  • .github/workflows/axis-business.yml
  • .github/workflows/cursor-axis-base.yml
  • README.md
  • docs/callers/cursor-approve.md
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@mattmillerai mattmillerai added the cursor-review Multi-model cursor review label Oct 8, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 3 finding(s).

Severity Count
🟠 High 1
🟢 Low 1
⚪ Nit 1

Panel: 6/6 reviewers contributed findings.

Comment thread .github/workflows/axis-business.yml Resolved
Comment thread docs/callers/cursor-approve.md Resolved
Comment thread docs/callers/cursor-approve.md Resolved
…ack in the base

Removing the business wrapper's SLACK_TOKEN declaration would fail any
caller still passing it at startup, taking down its whole workflow file.
Keep it declared, optional and never forwarded.

The exclusion now lives in cursor-axis-base.yml too: context_sources may
not include slack, so a direct caller of the public base cannot turn it
back on. Tests pin both, plus that no wrapper enables slack.
@mattmillerai
mattmillerai merged commit c052ff9 into main Oct 8, 2026
8 checks passed
@mattmillerai
mattmillerai deleted the matt/axis-business-drop-slack branch October 8, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Multi-model cursor review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants