Repository navigation
fix(cursor-approve): keep Slack out of the business axis - #376
Conversation
The business axis searched Slack for evidence that a change was wanted. Slack is where people debate before deciding, not a record of the decision: that lands in a ticket, PRD or TDD. Reading threads as intent rewards opening a thread to get a PR approved, and flags work (infra, CI) that never had one; and anyone in a channel can post text the approver then reads. The business axis now gets Linear and Notion only, and no longer declares or forwards SLACK_TOKEN. No caller wires axis-business.yml yet, so nothing breaks. The proxy's slack tools and the base's SLACK_TOKEN input stay, but no shipped axis enables them.
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 2 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 2 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 24 minutes for your next included review. Limit details: You’ve used the included review currently available. Your 130 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (6)
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
…ack in the base Removing the business wrapper's SLACK_TOKEN declaration would fail any caller still passing it at startup, taking down its whole workflow file. Keep it declared, optional and never forwarded. The exclusion now lives in cursor-axis-base.yml too: context_sources may not include slack, so a direct caller of the public base cannot turn it back on. Tests pin both, plus that no wrapper enables slack.
ELI-5
The business reviewer decides whether a change was actually wanted. One place it looked for that was Slack. Slack is where people argue before they decide, and anyone can post there, so it's a poor record of intent and an easy thing to game or inject into. This PR has the business reviewer use Linear and Notion only.
Change
axis-business.yml:context_sources: linear,notion(it waslinear,notion,slack). It no longer forwardsSLACK_TOKEN. The secret stays declared as optional and unused, so an existing caller'sSLACK_TOKEN:line is not rejected at startup. The header says why.cursor-axis-base.yml: rejectsslackincontext_sources, so a direct caller of the public base cannot turn Slack back on either.docs/callers/cursor-approve.md,README.mdand.github/cursor-approve/README.md: drop Slack from the business row, the caller example and the context-axes intro, and add a short "No axis reads Slack" note.test_context_axes.py: separates declared secrets from forwarded ones, and pins that the base rejectsslackand no wrapper enables it.Why
Compatibility
No caller wires
axis-business.ymlyet; a search across the org finds only this repo's own references. Even so,SLACK_TOKENstays declared, so a caller that passes it keeps working. The proxy'sslack_search/slack_historyand the base's optionalSLACK_TOKENdeclaration are left in place; removing them can be a separate cleanup.Provenance
Authored by: agent-work loop
Verified:
python3 -m unittest discover -s .github/cursor-approve/tests -p 'test_*.py': 164 tests OK at head.check_workflow_pins.pyandcheck_agents_md.py --root .: clean.Deviations:
SLACK_TOKENdeclared (unused) instead of removing it, and added the base-levelslackrejection.🤖 Generated with Claude Code