Repository navigation
feat(cursor-review): add defer_approval so only cursor-approve's decide approves - #352
Conversation
…de approves A caller that runs cursor-approve's axes after cursor-review had two approvers in sequence: cursor-review's `decide` APPROVED on severity alone, then cursor-approve's start phase withdrew it. In between, the approval satisfied code-owner review (a merge-race window), and a cursor-review run that failed or was cancelled after approving skipped the start phase, leaving the approval standing until the next push. `defer_approval: true` keeps `approve_gate` exactly as before but, on an APPROVE outcome, posts no review and resolves no thread; it withdraws the approver's own earlier marked approvals instead, as a no-decision round does. REQUEST_CHANGES is unchanged. Default false: existing callers see no change. The cursor-approve guide now sets it on the cursor-review call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 3 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 3 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 29 minutes for your next included review. Limit details: You’ve used the included review currently available. Your 127 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (7)
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
Panel: 5/6 reviewers contributed findings.
Reviewers that did not contribute: gpt-5.6-sol-max:edge-case (error)
…the posting path Addresses the cursor-review panel on #352: - a failed withdrawal of an earlier approval now reports approve_gate=untrusted instead of pass (the approval would otherwise keep satisfying protection); - a deferred pass dismisses the identity's own marked, unedited REQUEST_CHANGES, which a posted APPROVE would have superseded; - the post-decision head/base/needs-human-review re-check now also runs on the deferred path; - --defer-approval is read case- and whitespace-insensitively; - docs: poster_login must match cursor-review's poster under bot_app_id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ELI-5
When a repo runs cursor-approve's per-axis reviewers after cursor-review, cursor-review used to approve the PR first and cursor-approve took that approval back a moment later. In that gap, or if cursor-review crashed after approving, the PR looked approved even though no axis had looked at it. The new
defer_approval: trueinput tells cursor-review to report "this round passed" without approving, so cursor-approve's final decision is the only approval.What changed
cursor-review.yml: newdefer_approvalboolean input, defaultfalse. It is passed toauto-approve.py decideas--defer-approval.auto-approve.py decide: with--defer-approval true, an APPROVE outcome:approve_gate=pass, computed exactly as before (fail/untrusted/cappedare unchanged too);approve_max_severity+poster_login;DEFERRED_MESSAGE. Turning the input on therefore also clears approvals left from before.--defer-approvalcase- and whitespace-insensitively.docs/callers/cursor-approve.mdnow setsdefer_approval: truein the caller example and explains why in "What it does" steps 1–2 and Prerequisites. Step 2 now calls the start-phase withdraw a backstop.defer_approvalis added to the input tables indocs/callers/cursor-review.mdand.github/cursor-review/README.md. Theapprove_gate=passdescriptions now say the approval may be deferred. Comments incursor-approve.ymlandcmd_withdraware updated to match.Judgment calls
fail, so cursor-approve never runs on that round.untrusted. Aneeds-human-reviewlabel makes itcapped.untrusted, matching a failed POST, so no axis round runs over a standing severity-only approval. If dismissing a REQUEST_CHANGES fails, the step also goes red, but the gate stayspass, since a request for changes withholds nothing.poster_loginis still an input, not derived. The cursor-approve guide now says it must be<app-slug>[bot]when cursor-review runs withbot_app_id.Residual
defer_approval: trueon its cursor-review call. That is a one-line change per caller repo and is out of scope here. Until a caller does it, that caller keeps today's two-approver ordering.gh, not by a real workflow run.Provenance
.github/cursor-review/tests(942, including 10DeferApprovalTestcases covering failed withdrawal, REQUEST_CHANGES dismissal, the post-decision re-read and input parsing) and.github/cursor-approve/testsall passcheck_workflow_pins.py,.github/workflow-pins/tests,check_agents_md.py(only the 2 existing warnings),check-org-repo-literals.shcursor-review.yml(earlier round): no new findings compared withmain🤖 Generated with Claude Code