Skip to content

docs(custom-nodes): replace PrimeVue and PrimeIcons guidance in extension pages - #2237

Merged
DrJKL merged 1 commit into
mainfrom
drjkl/front-3794-remove-stale-primevueprimeicons-guidance-from-docscomfyorg
Nov 4, 2026
Merged

DrJKL merged 1 commit into
mainfrom
drjkl/front-3794-remove-stale-primevueprimeicons-guidance-from-docscomfyorg

Conversation

@DrJKL

@DrJKL DrJKL commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Resolves FRONT-3794. Follows #2223.

PrimeVue is gone from the ComfyUI frontend, but the About Panel Badges, Settings, Selection Toolbox and Sidebar Tabs extension pages still told extension authors to use PrimeVue components and pi pi-* icon classes.

Changes

  • Icons: examples now use Lucide classes (icon-[lucide--<name>]), which the frontend uses for its own sidebar, toolbox and About panel icons. The "Icon Options" sections explain that these classes are generated at frontend build time, so only icons the frontend already uses are available. They also note that pi pi-* and mdi mdi-* still render but are being phased out, with a link to the PrimeVue removal migration note.

  • Settings: the "Based on the X PrimeVue component" lines are removed. attrs are now documented against the current form components on ComfyUI_frontend main:

    • number: min, max, step and formatOptions. formatOptions replaces maxFractionDigits, and showButtons is gone because the buttons always show.
    • slider: min, max and step.
    • combo: searchable replaces filter. editable is no longer supported.
    • color: 8-digit hex is accepted.

    A short note sends authors who passed PrimeVue props to the migration note.

Translations

TRANSLATE_API_KEY isn't available here, so I translated the changed sections for es, ja, ko and zh by hand instead of running pnpm translate. Then I ran pnpm translate:sync-hash on the four English pages. Code blocks match the English pages exactly. The migration link points to the English page because it has no localized copies yet.

Verification

  • Icon format checked against ComfyUI_frontend main (packages/design-system/src/icons/README.md and the About panel, sidebar and selection toolbox components). Every Lucide icon used in the examples is present in the CSS of the published comfyui-frontend-package.
  • check-structure-parity.ts --base=origin/main, check-i18n-sync.mjs and check-anchors.py --only-changed pass. mint broken-links couldn't run locally (Node 26), so it's left to CI.

…sion pages

Icon examples now use Lucide icon classes (icon-[lucide--<name>]), and the
settings page documents the attrs the current form components accept.
Remaining PrimeVue mentions point to the PrimeVue removal migration note.
Translated copies (es, ja, ko, zh) are updated by hand and their source
hashes synced.

Amp-Thread-ID: https://ampcode.com/threads/T-01a1a3e4-7b41-7016-9bc0-ee2b78a40e24
@mintlify

mintlify Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
comfy 🟢 Ready View Preview Nov 4, 2026, 12:22 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@DrJKL
DrJKL merged commit 4a9f856 into main Nov 4, 2026
10 checks passed
@github-actions
github-actions Bot deleted the drjkl/front-3794-remove-stale-primevueprimeicons-guidance-from-docscomfyorg branch November 4, 2026 00:19
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch was successfully deployed

1 active deployment
staging — a33d940d Deployed Nov 4, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants