Skip to content

Revert "docs(custom-nodes): document the V3 DynamicGroup input type (#1877)" - #1999

Merged
comfyui-wiki merged 1 commit into
mainfrom
cursor/revert-dynamicgroup-docs-1877-74a9
Oct 18, 2026
Merged

comfyui-wiki merged 1 commit into
mainfrom
cursor/revert-dynamicgroup-docs-1877-74a9

Conversation

@comfyui-wiki

@comfyui-wiki comfyui-wiki commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Reverts the squash merge of #1877 (ba8a8b3acf7cad0b2ebf80c7981edbe7a21d076a).

Why

#1877 documented a public io.DynamicGroup API on the V3 migration guides. In ComfyUI (comfy_api/latest/_io.py) the type is the private _DynamicGroup. It is marked internal/unstable, is not exported in __all__, and unit tests assert DynamicGroup is not on the public io module. Built-in nodes import _DynamicGroup from comfy_api.latest._io. Authors following the merged docs get AttributeError.

This removes that documentation until a public API exists. It does not try to document the private import.

What changed

git revert of the squash commit. No later commit touched these files, and the four pages match their pre-#1877 content:

  • custom-nodes/v3_migration.mdx
  • zh/custom-nodes/v3_migration.mdx
  • ja/custom-nodes/v3_migration.mdx
  • ko/custom-nodes/v3_migration.mdx

Do not merge.

Open in Web Open in Cursor 

Note

Low Risk
Documentation-only revert; no runtime or API changes, and it reduces risk of custom-node authors hitting AttributeError from following incorrect public API guidance.

Reviewed by Cursor Bugbot for commit c963eb9. Bugbot is set up for automated code reviews on this repo. Configure here.

@mintlify

mintlify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
comfy 🟢 Ready View Preview Oct 18, 2026, 12:16 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: feea01ce-0906-435e-98b6-ef5b2837d408
📥 Commits

Reviewing files that changed from the base of the PR and between ddeab94 and c963eb9.

📒 Files selected for processing: 4
  • custom-nodes/v3_migration.mdx
  • ja/custom-nodes/v3_migration.mdx
  • ko/custom-nodes/v3_migration.mdx
  • zh/custom-nodes/v3_migration.mdx
+--------------------------------------------------------------------------+
| This function returns three different shapes. It's basically modern art. |
+--------------------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@comfyui-wiki
comfyui-wiki marked this pull request as ready for review October 18, 2026 12:15
@comfyui-wiki
comfyui-wiki merged commit 8d3c0ce into main Oct 18, 2026
14 checks passed
@github-actions
github-actions Bot deleted the cursor/revert-dynamicgroup-docs-1877-74a9 branch October 18, 2026 12:15

This branch was successfully deployed

1 active deployment
staging — c963eb94 Deployed Oct 18, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant