Repository navigation
Revert "docs(custom-nodes): document the V3 DynamicGroup input type (#1877)" - #1999
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 4
✨ Finishing Touches
Comment |
comfyui-wiki
marked this pull request as ready for review
October 18, 2026 12:15
github-actions
Bot
deleted the
cursor/revert-dynamicgroup-docs-1877-74a9
branch
October 18, 2026 12:15
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the squash merge of #1877 (
ba8a8b3acf7cad0b2ebf80c7981edbe7a21d076a).Why
#1877 documented a public
io.DynamicGroupAPI on the V3 migration guides. In ComfyUI (comfy_api/latest/_io.py) the type is the private_DynamicGroup. It is marked internal/unstable, is not exported in__all__, and unit tests assertDynamicGroupis not on the publiciomodule. Built-in nodes import_DynamicGroupfromcomfy_api.latest._io. Authors following the merged docs getAttributeError.This removes that documentation until a public API exists. It does not try to document the private import.
What changed
git revertof the squash commit. No later commit touched these files, and the four pages match their pre-#1877 content:custom-nodes/v3_migration.mdxzh/custom-nodes/v3_migration.mdxja/custom-nodes/v3_migration.mdxko/custom-nodes/v3_migration.mdxDo not merge.
Note
Low Risk
Documentation-only revert; no runtime or API changes, and it reduces risk of custom-node authors hitting AttributeError from following incorrect public API guidance.
Reviewed by Cursor Bugbot for commit c963eb9. Bugbot is set up for automated code reviews on this repo. Configure here.