Skip to content

docs: document selecting canvas links with a frame - #1981

Merged
comfyui-wiki merged 2 commits into
Comfy-Org:mainfrom
lin-bot23:docs/canvas-link-selection
Oct 17, 2026
Merged

comfyui-wiki merged 2 commits into
Comfy-Org:mainfrom
lin-bot23:docs/canvas-link-selection

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

Summary

Adds the link selection behaviour that shipped in Comfy-Org/ComfyUI_frontend#20837 (675f9b56eb7) to the canvas controls page.

  • A frame drawn over the canvas that captures no nodes, groups or reroutes selects every visible link it crosses.
  • The selection toolbox replaces its node buttons with a hide action, which keeps the connection and hides the wire (Comfy.Canvas.HideSelectedLinks), and a delete action, which removes the link from the graph (Comfy.Canvas.DeleteSelectedLinks).
  • Each action is one undo step, and Comfy.Canvas.DeleteSelectedItems falls back to the link selection, so Delete and Backspace remove a link selection too.
  • Shift and Alt frames and the Hand canvas mode never select links (marqueeSelectsLinks in LGraphCanvas.ts).

The new ### Selecting links subsection sits in the existing "Links and canvas globals" section, next to the link visibility controls.

Files

interface/canvas-controls.mdx plus zh/, ja/, ko/ with translationSourceHash resynced. git diff upstream/main..HEAD --stat: 4 files, 30 insertions, 6 deletions.

Verification

  • Behaviour, command ids and the toolbox buttons read from origin/main of ComfyUI_frontend: src/lib/litegraph/src/LGraphCanvas.ts (marqueeSelectsLinks), src/lib/litegraph/src/canvas/linkSelection.ts, src/lib/litegraph/src/canvas/linkVisibility.ts, src/components/graph/selectionToolbox/LinkSelectionActions.vue, src/composables/useCoreCommands.ts.
  • Heading structure identical across the four languages (6 H2, 1 H3).

In ComfyUI_frontend (675f9b56eb7, Comfy-Org/ComfyUI_frontend#20837) a frame
drawn over the canvas that captures no nodes, groups or reroutes now selects
the visible links it crosses. The selection toolbox then offers Hide, which
keeps the connection and hides the wire, and Delete, which removes the link.
Both are single undo steps and Comfy.Canvas.DeleteSelectedItems falls back to
the link selection, so Delete and Backspace do the same.

Adds a "Selecting links" subsection to the canvas controls page in all four
languages, next to the existing link visibility controls. Translation hashes
resynced.
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

Or wait 30 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9e49841e-4007-4297-ae04-db908edf2002
📥 Commits

Reviewing files that changed from the base of the PR and between ab73441 and c5fb0a5.

📒 Files selected for processing: 4
  • interface/canvas-controls.mdx
  • ja/interface/canvas-controls.mdx
  • ko/interface/canvas-controls.mdx
  • zh/interface/canvas-controls.mdx

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d864000b-d39b-428a-9a7e-d17e96e3d697
📥 Commits

Reviewing files that changed from the base of the PR and between 1da5c31 and ab73441.

📒 Files selected for processing: 4
  • interface/canvas-controls.mdx
  • ja/interface/canvas-controls.mdx
  • ko/interface/canvas-controls.mdx
  • zh/interface/canvas-controls.mdx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The canvas controls documentation now explains when area selection selects visible links, how to hide or delete selected links, and which selection modes exclude links. Japanese, Korean, and Chinese translations include the guidance and updated translation metadata.

Changes: Canvas link-selection documentation

Layer / File(s) Summary
Document link selection
interface/canvas-controls.mdx, ja/interface/canvas-controls.mdx, ko/interface/canvas-controls.mdx, zh/interface/canvas-controls.mdx
The English page and its translations describe link selection by framing, Hide and Delete actions, undo steps, keyboard deletion, and selection-mode limits. The translated pages also update translation metadata.

Suggested reviewers: comfyui-wiki

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ab734

The changes add canvas link-selection guidance across four locales. No actionable merge-blocking risk is identified in the supplied review evidence.

### Architecture Summary

Architecture risk: 🔵 Low · up to ab734

The change affects 4 systems.

Changed systems: interface, ja, ko, zh

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — interface (service) was modified; 1 changed file maps to changed impact.
  • observed — ja (service) was modified; 1 changed file maps to changed impact.
  • observed — ko (service) was modified; 1 changed file maps to changed impact.
  • observed — zh (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in interface/canvas-controls.mdx: Added guidance on link selection by framing: when no nodes, groups, or reroutes are captured, all crossed visible links are selected. The toolbox provides Hide and Delete actions, each treated as one undo step; Delete and Backspace also remove a link selection. Shift/Alt frames select only nodes and groups, and Hand mode cannot select links.
  • observed — Modified behavior in ja/interface/canvas-controls.mdx: 翻訳元ハッシュと翻訳ブロックハッシュを更新しました。
  • observed — Modified behavior in ja/interface/canvas-controls.mdx: 「リンクの選択」節を追加し、範囲選択でリンクが選択される条件、選択後の非表示・削除操作と取り消し単位、キーボード削除、およびShift/Alt併用時とHandモードではリンクが選択されないことを説明しています。
  • observed — Modified behavior in ko/interface/canvas-controls.mdx: Updated translation metadata: the source hash changed, and the “Links and canvas globals” block hash changed; the other listed block hashes remain the same.
Pre-merge checks: Passed 2
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
✨ Simplify code
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from comfyui-wiki October 16, 2026 05:11

Copy link
Copy Markdown
Member

反馈:如果前端功能更新带有版本说明(例如 versionAdded),希望能同步写进对应文档,方便后续 review 时 agent 对照合并 PR 的意见改进规则。

本 PR 已补充:框选连线功能需要 ComfyUI 前端 ≥ 1.58.0(来自 ComfyUI_frontend#20837,versionAdded: '1.58.0'),是画布框选默认行为,不是设置项开关。

Co-authored-by: Daxiong (Lin) <comfyui-wiki@users.noreply.github.com>
@comfyui-wiki
comfyui-wiki merged commit 7ca6a40 into Comfy-Org:main Oct 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants