Skip to content

docs(interface): drop the deprecated Pointer click drift delay setting - #1931

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:docs/remove-pointer-click-drift-delay
Oct 12, 2026
Merged

comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:docs/remove-pointer-click-drift-delay

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

Summary

The frontend retired the Pointer click drift delay setting in Comfy-Org/ComfyUI_frontend#20374. Comfy.Pointer.ClickBufferTime is now registered as type: 'hidden' with deprecated: true (modified in 1.54.3), its translations were removed, and time-based click promotion no longer exists: a press becomes a drag only when it moves further than Comfy.Pointer.ClickDrift.

The settings reference still described it as a live pointer setting, with a default of 150 while the registered default is 32. This removes the entry from interface/settings/lite-graph.mdx and from the three translations.

Files

  • interface/settings/lite-graph.mdx
  • zh/interface/settings/lite-graph.mdx
  • ja/interface/settings/lite-graph.mdx
  • ko/interface/settings/lite-graph.mdx

Verification

  • coreSettings.ts registers Comfy.Pointer.ClickBufferTime with type: 'hidden', deprecated: true, defaultValue: 32. The remaining visible Pointer settings, Comfy.Pointer.ClickDrift and Comfy.Pointer.DoubleClickTime, are both still documented.
  • Heading parity across the four files: 10 ## and 37 ### each.
  • python3 .github/scripts/check-anchors.py over the four changed files: all anchor links OK.
  • bun .github/scripts/i18n/sync-hash-i18n.ts interface/settings/lite-graph.mdx refreshed the translated block hashes.
  • git diff --stat shows only the four files.

@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b1e8c24a-6e22-4094-a975-f8ccc79ba453

📥 Commits

Reviewing files that changed from the base of the PR and between f44a91a and 4f3bfd7.


📒 Files selected for processing (4)
  • interface/settings/lite-graph.mdx
  • ja/interface/settings/lite-graph.mdx
  • ko/interface/settings/lite-graph.mdx
  • zh/interface/settings/lite-graph.mdx

💤 Files with no reviewable changes (1)
  • interface/settings/lite-graph.mdx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The English, Japanese, Korean, and Chinese LiteGraph settings pages remove the pointer click drift delay entry. The localized pages also update translation hashes.

Changes

Pointer settings documentation

Layer / File(s) Summary
Remove pointer click drift delay entry
interface/settings/lite-graph.mdx, ja/interface/settings/lite-graph.mdx, ko/interface/settings/lite-graph.mdx, zh/interface/settings/lite-graph.mdx
The pages remove the pointer click drift delay setting documentation. The Japanese, Korean, and Chinese pages update their translation hashes.

Suggested reviewers: comfyui-wiki


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 4f3bf

This documentation change removes the retired setting consistently across the four pages without changing runtime behavior. No material merge risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 4f3bf

The change affects 4 systems.

Changed systems: interface, ja, ko, zh

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — interface (service) was modified; 1 changed file maps to changed impact.
  • observed — ja (service) was modified; 1 changed file maps to changed impact.
  • observed — ko (service) was modified; 1 changed file maps to changed impact.
  • observed — zh (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in interface/settings/lite-graph.mdx: Removed the “Pointer click drift delay” setting, including its default value of 150 and its description of ignoring pointer movement for a maximum time after a pointer button is pressed.
  • observed — Modified behavior in ja/interface/settings/lite-graph.mdx: The page’s translationSourceHash changed from 870926b7 to 0d85813c.
  • observed — Modified behavior in ja/interface/settings/lite-graph.mdx: The Pointer translation block hash changed from 6b9ade60 to ad814775.
  • observed — Modified behavior in ja/interface/settings/lite-graph.mdx: Removed the “pointer click drift delay” setting documentation, including its default value of 150 ms and its description of the time during which pointer movement is ignored after pressing a pointer button.

Pre-merge checks | Passed 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

✨ Simplify code
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from comfyui-wiki October 12, 2026 05:09
@comfyui-wiki
comfyui-wiki merged commit 4dc3a49 into Comfy-Org:main Oct 12, 2026
10 checks passed
lin-bot23 added a commit to lin-bot23/docs that referenced this pull request Oct 12, 2026
Conflict: interface/settings/lite-graph.mdx plus its zh/ja/ko translations. Upstream (Comfy-Org#1931)
dropped the deprecated "Pointer click drift delay" setting, while this PR corrected that
setting's default from 150 to 32. Resolved by taking upstream in all four locales: the
setting no longer exists in the frontend (coreSettings.ts keeps only Comfy.Pointer.ClickDrift,
the maximum distance one), so a corrected default has nothing left to describe.

The three frontmatter conflicts (translationSourceHash plus the Node, Node Widget and Pointer
block hashes) were also resolved to upstream and then re-derived with translate:sync-hash
against the merged English page, so all three locales now carry translationSourceHash ace25c3f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants