Repository navigation
docs(interface): drop the deprecated Pointer click drift delay setting - #1931
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This documentation change removes the retired setting consistently across the four pages without changing runtime behavior. No material merge risk was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 4 systems. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
Conflict: interface/settings/lite-graph.mdx plus its zh/ja/ko translations. Upstream (Comfy-Org#1931) dropped the deprecated "Pointer click drift delay" setting, while this PR corrected that setting's default from 150 to 32. Resolved by taking upstream in all four locales: the setting no longer exists in the frontend (coreSettings.ts keeps only Comfy.Pointer.ClickDrift, the maximum distance one), so a corrected default has nothing left to describe. The three frontmatter conflicts (translationSourceHash plus the Node, Node Widget and Pointer block hashes) were also resolved to upstream and then re-derived with translate:sync-hash against the merged English page, so all three locales now carry translationSourceHash ace25c3f.
Summary
The frontend retired the Pointer click drift delay setting in Comfy-Org/ComfyUI_frontend#20374.
Comfy.Pointer.ClickBufferTimeis now registered astype: 'hidden'withdeprecated: true(modified in 1.54.3), its translations were removed, and time-based click promotion no longer exists: a press becomes a drag only when it moves further thanComfy.Pointer.ClickDrift.The settings reference still described it as a live pointer setting, with a default of 150 while the registered default is 32. This removes the entry from
interface/settings/lite-graph.mdxand from the three translations.Files
interface/settings/lite-graph.mdxzh/interface/settings/lite-graph.mdxja/interface/settings/lite-graph.mdxko/interface/settings/lite-graph.mdxVerification
Comfy.Pointer.ClickBufferTimewithtype: 'hidden',deprecated: true,defaultValue: 32. The remaining visible Pointer settings,Comfy.Pointer.ClickDriftandComfy.Pointer.DoubleClickTime, are both still documented.##and 37###each.python3 .github/scripts/check-anchors.pyover the four changed files: all anchor links OK.bun .github/scripts/i18n/sync-hash-i18n.ts interface/settings/lite-graph.mdxrefreshed the translated block hashes.git diff --statshows only the four files.