Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
e58f884 to
4c2fa3c
Compare
Add a Launching, Stopping, and Restarting an Instance section to the Instance Management page: how launching works, the multi-instance warning (Close & Launch / Run All) and its preference, the stopped card with Relaunch ComfyUI, and the crash card with Restart ComfyUI. Sources: src/renderer/src/composables/useLocalInstanceGuard.ts, src/renderer/src/panel/ComfyLifecycleView.vue, locales/en.json (launch.instanceRunning*, comfyLifecycle.*). Also fixes a pre-existing ja drift: the identifier in the Python environment example is now the byte-identical <ComfyUI_dir>.
d59d148 to
c094cd4
Compare
|
Superseded by #1961: consolidated Desktop docs (first-run, migration, title bar, performance tests, settings/beta, instance launch/stop/crash, update-check FAQ, Ollama FAQ). |
|
Closing in favor of #1961 (Desktop consolidation). Content preserved there. |
What
Documents the instance lifecycle in Comfy Desktop, which had no coverage: a new
Launching, Stopping, and Restarting an Instancesection on the Instance Management page.Sources
src/renderer/src/composables/useLocalInstanceGuard.tsin Comfy-Org/Comfy-Desktop: the multi-instance warning, its buttons, and thewarnBeforeRunningMultipleInstancespreferencesrc/renderer/src/panel/ComfyLifecycleView.vue: the stopped and crashed cards and their actionslocales/en.json(launch.instanceRunning*,comfyLifecycle.*,settings.warnBeforeRunningMultipleInstances)Localization
All four languages are updated in this PR: EN, zh, ja, ko, including the frontmatter hashes (
translate:sync-hashrun for this page only).The ja page also picks up one small fix: the placeholder in the Python environment example is now the byte-identical
<ComfyUI_dir>instead of a localized variant, matching the English source.Checklist
installation/desktop/usage/instance-management.mdxand its zh/ja/ko counterparts are touched. No nav change needed (existing page).check-anchorsclean for the four files; structure parity and content parity clean for the page.Added in a follow-up commit: the asset database failure
ComfyUI turns its assets system on by default and now names the reason when it cannot open its asset database (
ASSETS_STARTUP_FAILED: <kind>, then a message, then exit 1). The crash section now covers what the user sees instead of "Process exited with code 1":--database-urlstartup argument).--disable-assets.Sources:
src/main/lib/assetsStartupFailure.ts, the failure path insrc/main/lib/ipc/sessionActions/launch.ts, the exact user-visible text asserted bye2e/assets-startup-failure.test.ts, and ComfyUI'smain.py(stop_startup()/database_failure_message()). Upstream: Comfy-Org/Comfy-Desktop#1688.