Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to No concrete issue in the documentation changes is established that should block merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 4 systems. Changed systems: Architecture concerns Review details
Pre-merge checks |
|
The "Trailing Buttons" section of the Comfy Desktop usage overview listed only three of the controls on the right side of the title bar. It now covers all of them, in UI order, and adds the one detail that was missing from the instance pill description. - What's new bell: opens the announcements panel; the bell carries a dot until an announcement is opened. - Reset Zoom pill: appears only while the ComfyUI view is zoomed off 100%. - Downloads tray: what the badge shows, and what the tray can do, with the full list called out separately. - Instance Switcher: the center pill's inline Update chip, which updates the instance without opening the picker. Also normalized the full-width colons in the rewritten EN bullets to ASCII. Sources: Comfy-Org/Comfy-Desktop @ origin/main (68774676) - src/renderer/src/comfyTitleBar/TitleBarApp.vue, src/renderer/src/composables/useAnnouncement.ts, src/renderer/src/components/AnnouncementModal.vue, src/renderer/src/comfyTitlePopup/DownloadsView.vue, src/renderer/src/comfyTitlePopup/DownloadsFullView.vue, src/main/index.ts, locales/en.json.
ba90c4b to
436a062
Compare
|
Superseded by #1961: consolidated Desktop docs (first-run, migration, title bar, performance tests, settings/beta, instance launch/stop/crash, update-check FAQ, Ollama FAQ). |
|
Closing in favor of #1961 (Desktop consolidation). Content preserved there. |
What
installation/desktop/usage/overview.mdx(EN + zh/ja/ko): the Trailing Buttons section described only three of the five controls on the right side of the Comfy Desktop title bar. It now covers all of them, in UI order, and adds one missing detail to the instance pill.Changes
### Instance Switcher: added a sentence for the inline Update chip on the center pill, which updates that instance without opening the picker.The rewritten English bullets also drop the pre-existing full-width colon in favor of ASCII colons.
Sources (Comfy-Org/Comfy-Desktop
origin/main, 68774676)src/renderer/src/comfyTitleBar/TitleBarApp.vue: trailing control order, zoom pill gate (showZoomReset), bell unread dot (comfyRouterAnnouncementSeen), downloads tray badge, center-pill Update chip (@click.stop)src/renderer/src/composables/useAnnouncement.tsandsrc/main/index.ts: the bell is the only entry to the announcement panel, and opening it writes the seen flagsrc/renderer/src/components/AnnouncementModal.vue: panel content (hero video, highlights, call to action)src/renderer/src/comfyTitlePopup/DownloadsView.vue: tray row actions (retry, cancel or remove). Pause and resume are deliberately commented out there and live inDownloadsFullView.vue, which is what the text now sayslocales/en.json: labelsDesktop Update,What's new,Feedback,Downloads,Update,View All DownloadsTranslations
zh, ja and ko updated in the same commit, with UI labels kept in English and bold, matching the rest of the desktop pages. Frontmatter hashes refreshed with
bun .github/scripts/i18n/sync-hash-i18n.ts installation/desktop/usage/overview.mdx.Local checks:
check-anchors.pyon all four files, content parity, structure parity, truncation scan (0 issues).Note: rebased onto
main(5a1437b4f, 2026-10-11) to clear aCONFLICTINGstate. The only conflict was thetranslationSourceHash/translationBlockHashesblock in the three localized files, recomputed withbun .github/scripts/i18n/sync-hash-i18n.ts installation/desktop/usage/overview.mdx. The English body of this PRdid not overlap anything main changed since it was opened.
#1835 also edits this file (App Menu section), so whichever of the two merges second needs another rebase.