Skip to content

docs(desktop): complete the title-bar trailing controls list - #1836

Closed
lin-bot23 wants to merge 1 commit into
Comfy-Org:mainfrom
lin-bot23:desktop-docs-0930b
Closed

lin-bot23 wants to merge 1 commit into
Comfy-Org:mainfrom
lin-bot23:desktop-docs-0930b

Conversation

@lin-bot23

@lin-bot23 lin-bot23 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

What

installation/desktop/usage/overview.mdx (EN + zh/ja/ko): the Trailing Buttons section described only three of the five controls on the right side of the Comfy Desktop title bar. It now covers all of them, in UI order, and adds one missing detail to the instance pill.

Changes

Control Now documented
Desktop Update pill unchanged (already covered)
Reset Zoom pill appears only while the ComfyUI view is zoomed off 100 percent; click to return to 100 percent
What's new bell opens the announcements panel; the bell shows a dot until an announcement is opened
Feedback unchanged
Downloads tray what the badge shows (running count, failures, unopened results) and what the tray can do (retry a failed download, cancel a running one), with the full list called out separately

### Instance Switcher: added a sentence for the inline Update chip on the center pill, which updates that instance without opening the picker.

The rewritten English bullets also drop the pre-existing full-width colon in favor of ASCII colons.

Sources (Comfy-Org/Comfy-Desktop origin/main, 68774676)

  • src/renderer/src/comfyTitleBar/TitleBarApp.vue: trailing control order, zoom pill gate (showZoomReset), bell unread dot (comfyRouterAnnouncementSeen), downloads tray badge, center-pill Update chip (@click.stop)
  • src/renderer/src/composables/useAnnouncement.ts and src/main/index.ts: the bell is the only entry to the announcement panel, and opening it writes the seen flag
  • src/renderer/src/components/AnnouncementModal.vue: panel content (hero video, highlights, call to action)
  • src/renderer/src/comfyTitlePopup/DownloadsView.vue: tray row actions (retry, cancel or remove). Pause and resume are deliberately commented out there and live in DownloadsFullView.vue, which is what the text now says
  • locales/en.json: labels Desktop Update, What's new, Feedback, Downloads, Update, View All Downloads
  • Upstream: feat(announcement): swap the launch modal to Comfy Router Comfy-Desktop#1560 (announcement panel content switched to Comfy Router)

Translations

zh, ja and ko updated in the same commit, with UI labels kept in English and bold, matching the rest of the desktop pages. Frontmatter hashes refreshed with bun .github/scripts/i18n/sync-hash-i18n.ts installation/desktop/usage/overview.mdx.

Local checks: check-anchors.py on all four files, content parity, structure parity, truncation scan (0 issues).

Note: rebased onto main (5a1437b4f, 2026-10-11) to clear a CONFLICTING state. The only conflict was the
translationSourceHash / translationBlockHashes block in the three localized files, recomputed with
bun .github/scripts/i18n/sync-hash-i18n.ts installation/desktop/usage/overview.mdx. The English body of this PR
did not overlap anything main changed since it was opened.

#1835 also edits this file (App Menu section), so whichever of the two merges second needs another rebase.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 394f824f-8a75-419c-baeb-28ef78700df3

📥 Commits

Reviewing files that changed from the base of the PR and between 5a1437b and 436a062.


📒 Files selected for processing (4)
  • installation/desktop/usage/overview.mdx
  • ja/installation/desktop/usage/overview.mdx
  • ko/installation/desktop/usage/overview.mdx
  • zh/installation/desktop/usage/overview.mdx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.



📝 Walkthrough

Walkthrough

The desktop overview and its Japanese, Korean, and Chinese translations now describe the instance Update chip, title-bar controls, and additional download indicators and actions.

Changes

Desktop Dashboard Overview

Layer / File(s) Summary
Document the instance Update chip
installation/desktop/usage/overview.mdx, ja/installation/desktop/usage/overview.mdx, ko/installation/desktop/usage/overview.mdx, zh/installation/desktop/usage/overview.mdx
The English, Korean, and Chinese descriptions say the Update chip updates the active instance without opening the picker. The Japanese description says clicking the chip opens the picker.
Document title-bar controls and downloads
installation/desktop/usage/overview.mdx, ja/installation/desktop/usage/overview.mdx, ko/installation/desktop/usage/overview.mdx, zh/installation/desktop/usage/overview.mdx
The descriptions add Reset Zoom and What’s new details. They expand the Downloads descriptions with status indicators and actions. Japanese and Korean translation metadata hashes are updated.

Suggested reviewers: comfyui-wiki


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 436a0

No concrete issue in the documentation changes is established that should block merging.

Architecture Summary

Architecture risk: 🔵 Low · up to 436a0

The change affects 4 systems.

Changed systems: installation, ja, ko, zh

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — installation (service) was modified; 1 changed file maps to changed impact.
  • observed — ja (service) was modified; 1 changed file maps to changed impact.
  • observed — ko (service) was modified; 1 changed file maps to changed impact.
  • observed — zh (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in installation/desktop/usage/overview.mdx: The active-instance pill now shows an Update chip when that instance has a new ComfyUI version available; clicking the chip updates the instance without opening the picker.
  • observed — Modified behavior in installation/desktop/usage/overview.mdx: The section now calls the title-bar items “controls” rather than “buttons” and adds descriptions for Reset Zoom and What’s new. Downloads now describes a running-download count, failed and unopened indicators, retry and cancel actions in the tray, and pause and resume actions in the full downloads list; the Desktop Update and Feedback descriptions remain.
  • observed — Modified behavior in ja/installation/desktop/usage/overview.mdx: The translation source hash changes to 91561249, and the Dashboard Overview block hash changes to a39ba11a; the other listed block hashes are unchanged.
  • observed — Modified behavior in ja/installation/desktop/usage/overview.mdx: The instance-switching description adds that an Update chip appears when a newer ComfyUI version is available and opens the picker when clicked.

Pre-merge checks | Passed 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

✨ Simplify code
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

The "Trailing Buttons" section of the Comfy Desktop usage overview listed
only three of the controls on the right side of the title bar. It now covers
all of them, in UI order, and adds the one detail that was missing from the
instance pill description.

- What's new bell: opens the announcements panel; the bell carries a dot until
  an announcement is opened.
- Reset Zoom pill: appears only while the ComfyUI view is zoomed off 100%.
- Downloads tray: what the badge shows, and what the tray can do, with the
  full list called out separately.
- Instance Switcher: the center pill's inline Update chip, which updates the
  instance without opening the picker.

Also normalized the full-width colons in the rewritten EN bullets to ASCII.

Sources: Comfy-Org/Comfy-Desktop @ origin/main (68774676) -
src/renderer/src/comfyTitleBar/TitleBarApp.vue,
src/renderer/src/composables/useAnnouncement.ts,
src/renderer/src/components/AnnouncementModal.vue,
src/renderer/src/comfyTitlePopup/DownloadsView.vue,
src/renderer/src/comfyTitlePopup/DownloadsFullView.vue,
src/main/index.ts, locales/en.json.
@comfyui-wiki

Copy link
Copy Markdown
Member

Superseded by #1961: consolidated Desktop docs (first-run, migration, title bar, performance tests, settings/beta, instance launch/stop/crash, update-check FAQ, Ollama FAQ).

@comfyui-wiki

Copy link
Copy Markdown
Member

Closing in favor of #1961 (Desktop consolidation). Content preserved there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants