Skip to content

Router schema leaves Kling callback_url / external_task_id descriptions self-contradictory #2204

Open

Description

@lin-bot23

Where

router-schemas/kling/kling-3.0-turbo.json (and the sibling Kling schemas that share KlingV2Options) describe two fields as both functional and ignored:

  • components.schemas.KlingV2Options.properties.callback_url.description:
    "Callback notification URL for task results. The server notifies when the task status changes. Ignored: comfy-api drops this field before forwarding; Comfy Router polls on your behalf."
  • components.schemas.KlingV2Options.properties.external_task_id.description:
    "Customized Task ID. Does not overwrite the system-generated task ID but can be used for queries. Must be unique within a single user account. Ignored: comfy-api drops this field before forwarding; Comfy Router polls on your behalf."

Why it matters

The generated pages (development/comfy-router/models/kling/*/code.mdx and their zh/ja/ko translations) render both sentences, so a reader is told the server notifies on a callback URL that is never forwarded, and that a discarded custom ID can still be used for queries. Integrations that rely on either behavior will wait for a callback that never arrives or look up a task by an ID Router never received.

Suggested fix

In the schema source, drop the superseded promise and point to the Router flow instead: state that the field is not forwarded, that Router polls on the caller's behalf, and that the Router request ID is what to query with. Then let the schema sync regenerate the English pages and the i18n sync follow.

Found while reviewing the zh/ja/ko translation sync (PR #2202); the translations currently mirror the English source, which is where the contradiction comes from.

Activity

  1. coderabbitai commented on Nov 1, 2026

    @coderabbitai
    🔗 Related PRs

    #2202 - i18n: sync zh/ja/ko translations with upstream/main (2026-11-01) [open]
    #2193 - i18n: sync zh/ja/ko translations with upstream/main (2026-10-31) [open]


    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions