Skip to content
This repository was archived by the owner on Jun 26, 2026. It is now read-only.

chore: mark legacy desktop Comfy environment - #1718

Merged
benceruleanlu merged 2 commits into
mainfrom
bl/legacy-desktop-comfy-env
May 11, 2026
Merged

benceruleanlu merged 2 commits into
mainfrom
bl/legacy-desktop-comfy-env

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented May 11, 2026 •

Copy link
Copy Markdown
Member

Summary

  • write .comfy_environment with local-desktop during legacy desktop ComfyUI asset generation
  • explicitly include the marker in ToDesktop app files so dotfile glob behavior cannot drop it
  • require the marker in verifyBuild.js for Mac and Windows packaged outputs

Linear: https://linear.app/comfyorg/issue/DESK2-78/add-comfy-environment-marker-for-legacy-desktop

Context: Comfy-Org/ComfyUI#13425 reads this marker from the ComfyUI install directory and sends it as the Comfy-Env header for partner-node API calls.

@coderabbitai

coderabbitai Bot commented May 11, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 03ff0cb5-6eee-425a-9a6e-f5d9143b4f79

📥 Commits

Reviewing files that changed from the base of the PR and between 71fb1e5 and 9596f48.

📒 Files selected for processing (3)
  • scripts/makeComfy.js
  • scripts/verifyBuild.js
  • todesktop.json

📝 Walkthrough

Walkthrough

The PR introduces a .comfy_environment file written during ComfyUI setup, verifies its presence on macOS and Windows, and includes it in the bundled desktop application. This marker file is written with the value local-desktop to signal the deployment environment.

Changes

Environment Marker and Build Verification

Layer / File(s) Summary
Build Script Environment Marker Creation
scripts/makeComfy.js
After computing the ComfyUI assets directory path, the script creates assets/ComfyUI/.comfy_environment and writes local-desktop into it.
Build Verification Requirements
scripts/verifyBuild.js
Both macOS and Windows platform-specific PATHS.*.required lists now include ComfyUI/.comfy_environment alongside existing required paths, no environment for error here.
Desktop Bundle Configuration
todesktop.json
The packaging configuration explicitly adds assets/ComfyUI/.comfy_environment to the appFiles array before the assets/ComfyUI/** glob pattern, ensuring the hidden file is included in the distributed bundle.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/legacy-desktop-comfy-env
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch bl/legacy-desktop-comfy-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benceruleanlu
benceruleanlu marked this pull request as ready for review May 11, 2026 19:03
@benceruleanlu
benceruleanlu requested a review from a team as a code owner May 11, 2026 19:03
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 11, 2026
Kosinkadink
Kosinkadink previously approved these changes May 11, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 11, 2026
@benceruleanlu
benceruleanlu merged commit df918a6 into main May 11, 2026
6 of 7 checks passed
@benceruleanlu
benceruleanlu deleted the bl/legacy-desktop-comfy-env branch May 11, 2026 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants