Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions test/stamp-target-identity.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,18 @@ import * as Y from "yjs";
import { describe, expect, it } from "vitest";
import {
applyOps,
codePointCompare,
mint,
project,
writeTarget,
type AddNodeOp,
type ConnectOp,
type DeleteNodeOp,
type Op,
type SetWidgetOp,
type WorkflowJSON,
} from "../src/index.js";
import { rejectedOutcome } from "./apply-result-helpers.js";
import { canonicalize, loadCatalog } from "./helpers.js";

const catalog = loadCatalog();
Expand Down Expand Up @@ -198,4 +201,73 @@ describe("stamp targets normalize node ids to strings", () => {
expect(forward.links.map((l) => (l as unknown[])[0])).toEqual([502]);
expect(reverse.links.map((l) => (l as unknown[])[0])).toEqual([502]);
});

it("add_node: same-type duplicate ids converge on one higher-stamped payload", () => {
const makeCreate = (
tag: string,
actor: string,
baseVersion: number,
stepsValue: number,
pos: [number, number],
): AddNodeOp => ({
op: "add_node",
op_id: opId(tag),
actor,
base_version: baseVersion,
stamp: [baseVersion, actor],
node_id: 10,
class_type: "KSampler",
pos,
node: {
...base().nodes[0]!,
id: 10,
pos,
widgets_values: [stepsValue, "fixed", 20, 8.0, "euler", "simple", 1.0],
},
});
const lower = makeCreate("a3", AGENT, 5, 111, [10, 10]);
const higher = makeCreate("b3", HUMAN, 9, 999, [20, 20]);
const snapshot = Y.encodeStateAsUpdate(mint(base(), catalog));
const applyOrder = (ops: AddNodeOp[]): Y.Doc => {
const doc = new Y.Doc();
Y.applyUpdate(doc, snapshot);
expect(rejectedOutcome(applyOps(doc, ops, catalog))).toBeUndefined();
return doc;
};
const sortedEntries = (doc: Y.Doc, name: "__stamps" | "__applied"): [string, unknown][] =>
[...doc.getMap(name).entries()].sort(([a], [b]) => codePointCompare(a, b));

const forward = applyOrder([lower, higher]);
const reverse = applyOrder([higher, lower]);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
const forwardProjection = canonicalize(project(forward, catalog));
const reverseProjection = canonicalize(project(reverse, catalog));
const created = forwardProjection.nodes.filter((node) => node.id === 10);

expect(forwardProjection).toEqual(reverseProjection);
expect(created).toHaveLength(1);
expect(created[0]!.pos).toEqual([20, 20]);
expect(Array.isArray(created[0]!.widgets_values) ? created[0]!.widgets_values[0] : undefined).toBe(999);
expect(sortedEntries(forward, "__stamps")).toEqual(sortedEntries(reverse, "__stamps"));
expect(sortedEntries(forward, "__stamps")).toHaveLength(1);
expect(sortedEntries(forward, "__applied")).toEqual(sortedEntries(reverse, "__applied"));
expect(sortedEntries(forward, "__applied")).toHaveLength(2);

// Reapplying an already-applied operation is a no-op in both orders: take
// each order's first (losing) op and apply it a second time, then assert
// the projection and both ledgers are unchanged.
const snapshotOf = (doc: Y.Doc) => ({
projection: canonicalize(project(doc, catalog)),
stamps: sortedEntries(doc, "__stamps"),
applied: sortedEntries(doc, "__applied"),
});
const forwardAgain = applyOrder([lower, higher]);
const forwardBefore = snapshotOf(forwardAgain);
expect(rejectedOutcome(applyOps(forwardAgain, [lower], catalog))).toBeUndefined();
expect(snapshotOf(forwardAgain)).toEqual(forwardBefore);

const reverseAgain = applyOrder([higher, lower]);
const reverseBefore = snapshotOf(reverseAgain);
expect(rejectedOutcome(applyOps(reverseAgain, [higher], catalog))).toBeUndefined();
expect(snapshotOf(reverseAgain)).toEqual(reverseBefore);
});
});
Loading