Skip to content

Add property-based convergence/idempotency tests and cover schema-version-on-read #24

Closed

Description

@christian-byrne

Reviewed at 26995a3.

Convergence and idempotency are the core guarantees but are tested by a handful of hand-picked examples and 12 fixed seeds over one two-writer shape (test/connect-lww.test.ts:460), not property tests over arbitrary op sequences, batch boundaries, retries, actor counts, and causal permutations. Schema-version-on-read has zero tests: test/roundtrip.test.ts:107 only proves migrate() rejects newer versions; nothing mutates meta.schema_version and then calls project() expecting SchemaVersionError.

Direction: add property-based tests asserting projection equality across all interleavings of random op streams and byte-identical double-apply; add a test that a stale/newer schema_version fails closed on a normal read path.

Activity

  1. coderabbitai commented on Aug 20, 2026

    @coderabbitai
    🔗 Related PRs

    Comfy-Org/ComfyUI_frontend#14971 - perf: reuse execution graph projections [open]
    Comfy-Org/ComfyUI_frontend#15064 - test: cover boundary link preservation on subgraph creation [open]
    Comfy-Org/ComfyUI_frontend#15414 - test: cover boundary links into autogrow input groups on subgraph conversion [open]


    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions