Skip to content

Node re-add, autogrow, and clear resolve by arrival order instead of a stamp → non-convergent #11

Closed

Description

@christian-byrne

Reviewed at 26995a3.

Several handlers resolve concurrent edits by arrival order rather than by the [base_version, actor, op_id] stamp, so two replicas that saw the same ops in a different order project different graphs.

node re-add vs delete (src/applier.ts:155 add early-return, src/applier.ts:648 delete): both gate only on nodes.has(key); neither consults the ["node", node_id] target declared in src/stamps.ts. delete→add keeps the replacement; add→delete keeps nothing.

autogrow (src/applier.ts:511): each grow appends its slot in arrival order, so the same link_id lands on images.image1 in one order and images.image2 in the other; the projected inputs differ. The test at test/connect-lww.test.ts:437 only asserts both link ids exist, so it passes either way (test blind spot).

clear (src/applier.ts:698): no stamp gate; order-dependent under concurrency and not in the Q6 carve-outs.

Repro (confirmed) for re-add and autogrow: delete→add keeps a node while add→delete keeps none; link 9701 lands on a different slot name depending on order.

Direction: route node presence, autogrow naming, and clear through the same stamp comparison the input/widget registers use (or document + pin them as accepted ordering gaps the way out-links ordering is).

Activity

  1. coderabbitai commented on Aug 20, 2026

    @coderabbitai
    🔗 Related PRs

    Comfy-Org/ComfyUI_frontend#14971 - perf: reuse execution graph projections [open]
    Comfy-Org/ComfyUI_frontend#15092 - fix(layout): keep a node layout ref alive until its last holder releases [merged]
    Comfy-Org/ComfyUI_frontend#15360 - fix: keep node preview images across workflow tab switches [merged]
    Comfy-Org/ComfyUI_frontend#15405 - perf: retain offscreen Vue nodes with KeepAlive [open]
    Comfy-Org/ComfyUI_frontend#15414 - test: cover boundary links into autogrow input groups on subgraph conversion [open]


    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions