Repository navigation
ci(dependabot): ignore Comfy-Org/github-workflows so Dependabot cannot split a caller's pins - #889
Merged
mattmillerai merged 2 commits intoNov 17, 2026
Conversation
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
A caller of a Comfy-Org/github-workflows reusable pins it TWICE -- the `uses:` SHA and a `workflows_ref:` input that loads the matching briefs/scripts at run time. Dependabot only understands `uses:`: it rewrites the SHA and leaves `workflows_ref:` behind, splitting the pair. The workflow_sha equality guard in the reusables turns that split into a red check (open PR #871 is red on it right now; #832 was closed for the same reason). Both ignore entries are load-bearing: Dependabot names a reusable dependency by its FULL path, and a bare `dependency-name` is an exact match, so the exact form covers `owner/repo` and the `/*` form covers the per-file names. Deliberately not the single trailing-star form, which Dependabot expands to an unanchored `.*` that would also swallow future sibling repos whose names merely start with this one. The bump-*-callers fleet in github-workflows moves both pins together.
…wildcard note Upstream's bump-detect-unreviewed-merge-callers fleet already bumps this repo's caller (see #978), so the ignore covers it to avoid racing that bumper rather than leaving it to a hand bump. Point the caller header at the bumper instead of Dependabot/Renovate, and explain the two-entry vs single-wildcard trade-off instead of forbidding upstream's form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mattmillerai
force-pushed
the
matt/be-15272-dependabot-ignore-github-workflows
branch
from
November 16, 2026 23:26
7bc3da3 to
986f18d
Compare
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 14 automatic and 15 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
approved these changes
Nov 16, 2026
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 986f18d has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
mattmillerai
deleted the
matt/be-15272-dependabot-ignore-github-workflows
branch
November 17, 2026 00:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Some of our automated checks reuse shared check scripts, and each one records which version of those scripts to use in two separate places. The automatic dependency updater only knows how to change one of the two, so its updates left the two out of step and broke the checks. This tells the updater to stay away from those shared scripts. The tool that already updates them properly changes both places at once.
Description
Adds an
ignore:block to the existinggithub-actionsentry in.github/dependabot.yml. No other Dependabot setting is touched. It also updates theheader comment in
.github/workflows/detect-unreviewed-merge.yml, which used to say"Bump the SHA via Dependabot/Renovate", so that it names the upstream bumper.
Both entries are load-bearing. Dependabot names a reusable-workflow dependency by
its full path (
Comfy-Org/github-workflows/.github/workflows/groom.yml) — onedependency per reusable, not one per repo — and a
dependency-namewithout a wildcardis an exact match. The exact form covers the
owner/repospelling, the/*formcovers the per-file names. This mirrors
Comfy-Org/cloud's config, where thefirst cut was the bare
Comfy-Org/github-workflowsalone and matched nothing.This repo uses two entries rather than upstream's single
Comfy-Org/github-workflows*(which also works). The reason: Dependabot expands
*to an unanchored
.*, so one trailing star would also swallow any future sibling repowhose name merely starts with this one. That same unanchored
.*is whyowner/repo/*still matches the full paths — it spans
/happily.This repo calls five of these reusables:
agents-md-integrity.yml,ci-cursor-review.yml,groom.yml,public-repo-hygiene.yml,detect-unreviewed-merge.yml.Why now — the capability being denied was attempted, and it breaks
This diff removes a capability (Dependabot bumping these five reusables), so here is
the evidence it genuinely fails rather than an assumption that it would:
PR #871 was the live attempt (since closed unmerged on 2026-09-19). Dependabot ran, and its diff did this:
Three distinct, deliberate per-workflow pins flattened onto one SHA; every
workflows_ref:input left behind at its old value; and every explanatory# main @ <sha>comment left pointing at the value it no longer matches. Thehygiene / public-repo-hygienecheck on #871 failed as a direct result.PR #832 was closed unmerged for the same reason on 2026-09-13.
The path that does work is not removed, and this PR redirects to it. The
bump-*-callersfleet ingithub-workflowsrewrites both pins together and opens thePR itself, so these reusables keep getting bumped — just by the mechanism that
understands the second pin. That includes
detect-unreviewed-merge.yml, which pins onlyonce: upstream's
bump-detect-unreviewed-merge-callersfleet already bumps it in thisrepo (#978), so ignoring it in Dependabot avoids a second bumper racing that one.
How has this been tested?
Acceptance was run against the artifacts named for this change, not only the file the
diff touches:
git diff --stat origin/main...HEAD→.github/dependabot.yml | 17 +and
.github/workflows/detect-unreviewed-merge.yml | 4 +-(header comment only);2 files, 20 insertions, 1 deletion.
python3 -c "import yaml; yaml.safe_load(open('.github/dependabot.yml'))"→ OK. The parsed tree shows
ignoreas exactly twodependency-namemappings,alongside an unchanged
version,package-ecosystem,directory,schedule,open-pull-requests-limitandgroups.grep -n 'Comfy-Org/github-workflows' .github/dependabot.ymlreturns four lines: the two
dependency-name:entries (L27, L28) plus twoexplanatory comment lines (L13, L19) that also spell the repo name. Exactly two
entries, as intended; flagging the comment hits so the grep output isn't a surprise.
github-workflowsreusable. Four of five (
agents-md-integrity,ci-cursor-review,groom,public-repo-hygiene) carry aworkflows_ref:input, i.e. the double pin thisprotects.
detect-unreviewed-merge.ymlcarries noworkflows_ref:— noted inline.gh pr view/gh pr diff/gh pr checks(read-only;neither PR was modified). Findings quoted above.
Comfy-Org/cloud/.github/dependabot.ymlread directly;the two entries here are byte-identical to the two there.
ruff check .→ All checks passed.ruff format --check .→ 453files already formatted.
pytest→ 7590 passed, 4 failed, 38 skipped. The 4failures are pre-existing and unrelated: they reproduce identically on an
unmodified
origin/mainworktree at the same commit (f35e41c), and this diffcontains no Python. They are
test_logs_pretty_warns_when_explicit_port_falls_back_to_unsuffixed,test_non_pep440_installed_version_is_unknown_not_a_crash, and the twotest_atomic_write_*_new_file_uses_umask_defaultcases (the latter two lookumask/environment-sensitive on this host).
Residual
Not fixed by this PR, actionable on its own:
PR chore(deps): bump the ci-dependencies group across 1 directory with 6 updates #871 is already closed unmerged (2026-09-19). Nothing to do for it after this
lands. Without the ignore, though, the next monthly Dependabot run can open a fresh
split-pin PR, so this change is still needed.
Four other org repos are still exposed, and one of them is new. I pointed the
same measurement at the repos this fix does not cover — repos that both enable the
github-actionsDependabot ecosystem and contain files callingComfy-Org/github-workflows, but carry zeroComfy-Org/github-workflowsignoreentries (
gh api …/contents/.github/dependabot.yml+gh api search/code, measured2026-09-18):
github-actionsecosystemcomfy-mcpcomfy-python-sdkcomfy-typescript-sdkComfyUI_frontendcloudcomfy-cloud-mcp-servergithub-workflowsplatformcomfy-infraThe first three are exactly the repos whose drift motivated this work.
ComfyUI_frontend(7 caller files, no ignore) was not named anywhere in themotivating investigation and looks like the same exposure — worth a look before the
equality guard is rolled out everywhere, since that rollout is what converts this
from a silent split into a red check.
platformandcomfy-infracall thesereusables but do not enable the ecosystem, so Dependabot cannot split their pins.
github-workflows' andcomfy-cloud-mcp-server's ignores use a looser form.github-workflows' own self-reference ignore is the single- dependency-name: "Comfy-Org/github-workflows*"— the unanchored trailing starthis PR deliberately avoids. It is harmless today and starts to matter the day the
org gains a repo whose name begins with
github-workflows. I did not inspect whichform
comfy-cloud-mcp-server's single entry uses.Suppresses security updates too. With no
versions:/update-types:qualifier,this also stops Dependabot security advisories for these reusables. Accepted, and
the same trade-off
cloudaccepted: these are first-party org workflows pinned toreviewed SHAs, not registry packages, so an advisory-driven bump is not the update
path here.
I could not observe Dependabot actually honoring the ignore. That requires this
to be on the default branch and the next monthly run to fire. The confidence rests on
the semantics being identical to
cloud's working config, not on an observed run here.Unexercised artifacts. The tracking issue that motivated this change, and its
linked investigation, are in a tracker I have no access to from this environment —
I worked from the change description alone and could not read them. The four
cross-repo pull requests cited there as drift evidence
(
comfy-mcpFixed: Pin version of click dependency. #265,comfy-python-sdkcomfy model download --filename ? #136/Machine-Friendly Option Option #146,comfy-typescript-sdkthe documentation link does not load #135/Add a --fast-deps option tocomfy install/reinstallthat enables new faster/unified/uv-based dependency install #141)were not individually opened; I corroborated the mechanism against this repo's own
chore(deps): bump the ci-dependencies group across 1 directory with 6 updates #871 and chore(deps): bump the ci-dependencies group across 1 directory with 7 updates #832 instead, and sized the remainder with the sweep in item 2.
Correction, disclosed (review round): an earlier revision said
detect-unreviewed-merge.ymlhad no upstream bumper and would be bumped by hand. Thatwas wrong.
bump-detect-unreviewed-merge-callers.ymlexists upstream and has alreadyopened #978 here. The inline comment and the caller header now say so.
Method correction, disclosed: my first pass at the item-2 sweep matched only
double-quoted
package-ecosystem: "github-actions"and so scoredcomfy-mcpas havingno ecosystem — it uses single quotes. The table above is the corrected, quote-agnostic
re-run. Noting it because the wrong version of that number would have argued the
motivating investigation had misattributed one of its four cases.
Provenance
main(545d576). The diff is still 2 files: theignoreblock in.github/dependabot.ymland the header comment indetect-unreviewed-merge.yml. It contains no Python.yaml.safe_load.ignorehas exactly twodependency-nameentries.Comfy-Org/github-workflowscallers are still the five listed above.ruff check .passes at this head.uses:line, so it does not conflict with the header edit.pytestwas run on the first revision only (7590 passed / 4 failed / 38 skipped; the same 4 fail on unmodifiedmain). At this head it is left to CI.