You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(generate): point the 'Not signed in' hint at /profile/api-keys - #1107
When someone tries to generate without being signed in, the CLI tells them where to get an API key. That link pointed at a web address with no real page behind it. It now goes to the actual API-key page and opens the "create key" dialog right away.
Summary
comfy_cli/command/generate/client.py: the Not signed in hint now links https://platform.comfy.org/profile/api-keys?onboarding=router instead of https://platform.comfy.org/api-keys. The platform only has a page at /profile/api-keys. The short path gets a 200 from the SPA but can render a 404 shell. The onboarding=router query opens the create-key dialog.
tests/comfy_cli/command/generate/test_client.py: test_resolve_api_key_missing now checks for the new URL. Before this, no test checked the URL at all, only the Not signed in prefix.
A repo-wide grep (grep -rnI 'platform.comfy.org/api-keys' across code, docs, README, specs and tests) found this as the only occurrence. Nothing else needed changing, and the old short-path string no longer appears anywhere.
Mutation check: with the URL change reverted, the new assertion fails (1 failed, 15 passed).
ruff check .: clean. ruff format --check .: clean.
I could not get a full-suite result locally. A full pytest run was killed at about 10 minutes, and pytest tests/comfy_cli/command/generate was killed at its 400s timeout. Neither produced any failure output (the first run's output was cut off by a tail pipe). CI's run is the full-suite signal for this PR.
Doc-drift sweep: 1 reference checked, 0 updated. README.md:494 (export COMFY_API_KEY=...) is still accurate.
Provenance
Authored by: agent-work loop
Verified:
Targeted tests: green (16/16), and the new assertion fails when the fix is reverted
Lint/format: clean
Full suite: not completed locally (see Testing); relying on CI
Deviations: none to the requested change; the full local test run is unconfirmed (see Testing)
Residual
I did not check in a browser that /profile/api-keys?onboarding=router opens the create-key dialog with the Router banner. That behaviour comes from the platform frontend, which this repo doesn't contain.
The full local pytest run and the tests/comfy_cli/command/generate package run both hit their timeouts on the build host without producing any failure output, so the cause isn't known. The one test file this PR touches passes in about 6s. If CI is also slow or hangs, it's worth looking into separately.
Summary by CodeRabbit
Bug Fixes
Updated the missing API key message to link to the onboarding API-key page.
The missing-key hint points to the updated API-key page. No merge-blocking issue is established.
Pre-merge checks: 6
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: updating the “Not signed in” hint to use the /profile/api-keys URL.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Architecture Decision Compliance
PASS. The diff changes only the human-readable resolve_api_key() hint URL and adds a matching test assertion. The accepted ADRs concern machine-output schemas, workflow operations, dependency resolu…
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Full details: Architecture Decision Compliance
Explanation
PASS. The diff changes only the human-readable resolve_api_key() hint URL and adds a matching test assertion. The accepted ADRs concern machine-output schemas, workflow operations, dependency resolution, knowledge discovery, and save-to-API conversion; none governs this URL. The URL update is a local, reversible implementation detail and does not create an architectural boundary or dependency choice.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between ba9f00e and 3629690.
Files selected for processing: 2
comfy_cli/command/generate/client.py
tests/comfy_cli/command/generate/test_client.py
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
The short platform.comfy.org/api-keys path has no page behind it (the SPA
only serves /profile/api-keys), so the hint could land on a 404 shell. Link
the real key page with ?onboarding=router, which opens the create-key dialog.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
When someone tries to generate without being signed in, the CLI tells them where to get an API key. That link pointed at a web address with no real page behind it. It now goes to the actual API-key page and opens the "create key" dialog right away.
Summary
comfy_cli/command/generate/client.py: theNot signed inhint now linkshttps://platform.comfy.org/profile/api-keys?onboarding=routerinstead ofhttps://platform.comfy.org/api-keys. The platform only has a page at/profile/api-keys. The short path gets a 200 from the SPA but can render a 404 shell. Theonboarding=routerquery opens the create-key dialog.tests/comfy_cli/command/generate/test_client.py:test_resolve_api_key_missingnow checks for the new URL. Before this, no test checked the URL at all, only theNot signed inprefix.A repo-wide grep (
grep -rnI 'platform.comfy.org/api-keys'across code, docs, README, specs and tests) found this as the only occurrence. Nothing else needed changing, and the old short-path string no longer appears anywhere.Testing
pytest tests/comfy_cli/command/generate/test_client.py: 16 passed.ruff check .: clean.ruff format --check .: clean.pytestrun was killed at about 10 minutes, andpytest tests/comfy_cli/command/generatewas killed at its 400s timeout. Neither produced any failure output (the first run's output was cut off by atailpipe). CI's run is the full-suite signal for this PR.README.md:494(export COMFY_API_KEY=...) is still accurate.Provenance
Residual
/profile/api-keys?onboarding=routeropens the create-key dialog with the Router banner. That behaviour comes from the platform frontend, which this repo doesn't contain.pytestrun and thetests/comfy_cli/command/generatepackage run both hit their timeouts on the build host without producing any failure output, so the cause isn't known. The one test file this PR touches passes in about 6s. If CI is also slow or hangs, it's worth looking into separately.Summary by CodeRabbit