Repository navigation
fix(workflow): persist Cloud sidebar files and verify save identity #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+2,694
−171
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8a89ba4
fix(workflow): persist Cloud sidebar files and verify save identity
shengkaisun 1a96cf3
Merge branch 'main' into esun/fix/workflow-save-sidebar
wealthwiselabs fe4acd5
fix(workflow): preserve JSON types when verifying mirrored records
shengkaisun 45b878e
test(cli): isolate preflight catalogs and platform trust fixtures
shengkaisun e0c90be
Expose userdata saved-file UUID separately from workflow records
shengkaisun e0cfd9b
Match saved-file UUID receipts to the frontend consumer contract
shengkaisun c142b63
Register saved-file identity warning as a navigation signal
shengkaisun e2ced53
chore: merge main into Cloud workflow sidebar save
shengkaisun 09a5f38
test(run): isolate UI workflow preflight catalog
shengkaisun f741297
chore: merge latest main workflow sockets and model destinations
shengkaisun fde569d
docs: clarify saved userdata identity in changelog
shengkaisun 237b1ad
Merge main into esun/fix/workflow-save-sidebar
shengkaisun 736d60e
fix(workflow): clarify safe association refusal guidance
shengkaisun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| """Saved userdata UUID contract shared by save receipts and link publication.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import re | ||
|
|
||
| # Browser consumer: uuid11.1.1 validate(), plus lowercase canonical wire form. | ||
| # Accept RFC9562 versions1..8 and variants8..b, plus its explicit NIL/MAX cases. | ||
| _SAVED_FILE_UUID = re.compile( | ||
| r"(?:[0-9a-f]{8}-[0-9a-f]{4}-[1-8][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}" | ||
| r"|00000000-0000-0000-0000-000000000000|ffffffff-ffff-ffff-ffff-ffffffffffff)" | ||
| ) | ||
|
|
||
|
|
||
| def canonical_saved_file_id(value: object) -> str | None: | ||
| """Return a received canonical ID, without deriving or coercing one.""" | ||
| return value if isinstance(value, str) and _SAVED_FILE_UUID.fullmatch(value) else None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Saving a workflow to the Cloud sidebar | ||
|
|
||
| `comfy --json workflow save workflow.json --name "My workflow" --where cloud` | ||
| writes the normal `workflows/My workflow.json` userdata file once. It returns | ||
| `filename` and, when supported by the server, `saved_file_id`: the actual userdata | ||
| UUID from that write receipt. The UUID survives ordinary saves and renames; a | ||
| deleted and recreated file has a new identity. | ||
|
|
||
| `workflow_id` remains the separate mirrored workflow-record ID used by the | ||
| record-based list/get/delete commands. A same-name record with equal content does | ||
| not establish the saved file's UUID. Never substitute `workflow_id` for | ||
| `saved_file_id` or construct a private editor URL from either value alone. | ||
|
|
||
| Older servers can save successfully without returning a usable file UUID. In | ||
| that case `saved_file_id` is null and `saved_file_identity_unavailable` explains | ||
| that private file-link certification is unavailable. Verify the saved file in | ||
| Cloud's Workflows sidebar; do not repeat the save or any local file uploads to | ||
| obtain an ID. File identity metadata does not grant upload permission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.