Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ history.
`asset_upload_refused`; new codes `asset_upload_invalid`,
`asset_upload_failed` and `asset_upload_timeout` cover the other ways it
can end.

- `comfy knowledge resolve` suggests canonical model ids for an incomplete
family/version name such as `Qwen 2.1`. The command still fails with
`knowledge_unknown_model` and exit 1, but `error.details.candidate_ids` lists
Expand All @@ -60,9 +61,17 @@ history.

### Fixed

- `comfy assets library ls` reports a 401 or 403 as `cloud_unauthorized` even
when the server drops the connection partway through its error body, instead
of crashing with `IncompleteRead`.
- Desktop discovery reads both modern and legacy registries. Callers with
running-server launch metadata select that exact instance, resolve its model
YAML and effective data/input/output paths, and keep ambiguous or relative
runtime identities unresolved. The optional discovery fields are documented
in the which/env schemas; unrelated launch arguments are excluded.

- `comfy which` and `comfy env` report Desktop's split code, data and model
roots without changing launch/install selection. A nonexistent selected
workspace no longer succeeds in `which`; discovery reports malformed Desktop
configuration and marks inferred data roots as unverified.

- A typed `comfy model download` with no `--relative-path` now saves into the
folder the running local ComfyUI scans for that model type, and says where.
On Comfy Desktop that is the shared library, not the install's `models/`.
Expand Down Expand Up @@ -112,6 +121,10 @@ history.
value. Saves with a real marker have one more value than sockets and still go
through the filter.

- `comfy assets library ls` reports a 401 or 403 as `cloud_unauthorized` even
when the server drops the connection partway through its error body, instead
of crashing with `IncompleteRead`.

## [1.24.0] - 2026-10-29

[Full notes](https://github.com/Comfy-Org/comfy-cli/releases/tag/v1.24.0) · 25 commits since v1.23.0.
Expand Down
27 changes: 23 additions & 4 deletions comfy_cli/cmdline.py
Original file line number Diff line number Diff line change
Expand Up @@ -2775,7 +2775,8 @@ def set_default(
@tracking.track_command()
def which():
renderer = get_renderer()
comfy_path = workspace_manager.workspace_path
workspace = workspace_manager.discovery_data()
comfy_path = workspace["path"]
if comfy_path is None:
renderer.error(
code="not_in_workspace",
Expand All @@ -2784,15 +2785,25 @@ def which():
)
raise typer.Exit(code=1)

workspace_type_value = (
workspace_manager.workspace_type.value if workspace_manager.workspace_type is not None else None
)
workspace_type_value = workspace["type"]
if not workspace["exists"]:
details = {"path": comfy_path, "workspace_type": workspace_type_value}
if "desktop" in workspace:
details["desktop"] = workspace["desktop"]
renderer.error(
code="workspace_not_found",
message=f"Workspace directory does not exist: {comfy_path}",
hint="run: comfy install (or pass --workspace /path/to/ComfyUI)",
details=details,
)
raise typer.Exit(code=1)
if renderer.is_pretty():
import sys as _sys

from comfy_cli.env_checker import _display_url
from comfy_cli.local_address import resolve_local_host_port
from comfy_cli.output.panels import which_panel
from comfy_cli.output.sanitize import sanitize_value

host, port = resolve_local_host_port(None, None, background=ConfigManager().background)
try:
Expand All @@ -2808,12 +2819,17 @@ def which():
server_running=server_running,
server_url=_display_url(host, port),
version=ConfigManager().get_cli_version(),
desktop=workspace.get("desktop"),
)
)
for warning in workspace.get("warnings", []):
renderer.console().print(sanitize_value(warning["message"]), markup=False)
renderer.emit(
{
"workspace_path": str(comfy_path),
"workspace_type": workspace_type_value,
"exists": workspace["exists"],
**{key: workspace[key] for key in ("desktop", "warnings") if key in workspace},
},
command="which",
)
Expand Down Expand Up @@ -2893,6 +2909,9 @@ def env():
# JSON path: collect structured data without printing the table.
data = EnvChecker().fill_data()
data["workspace"] = workspace_manager.fill_data()
warnings = data["workspace"].pop("warnings", None)
if warnings:
data["warnings"] = warnings
renderer.emit(data, command="env")


Expand Down
Loading
Loading