Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Author
|
Closing this for now. Nothing consumes these codes yet, the cloud agent follow-up was never opened, and the branch is 63 commits behind main with conflicts. The refusals still work today under the generic codes and messages. If a consumer shows up, I will reopen this aligned with the codes multi-player shipped in #283 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of CORE-186
Problem
DynamicGroup refusals from #973 reach the
--jsonenvelope under generic codes:workflow_edit_invalid,workflow_not_api_format,conversion_error,workflow_conversion_failedorworkflow_slot_invalid. The only way to tell them apart is to match message text, which also contains node ids and field names. The cloud agent needs to count them by code.Change
Four registered codes. Each one is a class attribute on
DynamicGroupBindingErroror one of its subclasses, so exception types stayValueError, messages are unchanged, and existingexceptclauses still work.dynamic_group_unsupported(existing catalog warning, now also an error code)defaultInput, a non-booleancontrol_after_generate, a duplicate or dotted field, a group inside a DynamicCombo, an unknownCOMFY_DYNAMICGROUP_*version, a generated-name collisiondynamic_group_binding_mismatchwidgets_values_formorwidgets_values_namedis malformed or mismatched, or a row's seed control mode is unsupporteddynamic_group_count_out_of_rangemin..max, or not an integerdynamic_group_rows_linkedThe code shows up as
error.codein:workflow apply, includingdetails.failed.codeunder--ack summary;workflow foreachandworkflow slots;workflow validate,runandworkflow decompose.WorkflowConversionErrornow takes an optionalcode.The widget catalog keeps its existing
dynamic_group_unsupportedwarning.In the error-code registry test,
engine.pystays excluded except for exception-classcodeattributes, and the test now also countscode=e.code or "fallback"literals.Follow-ups: the row-replacement spec in Draft #1004 will use these codes once this lands, and the cloud agent will count them (a Comfy-Org/cloud follow-up).
Tests
tests/comfy_cli/command/test_dynamic_group_error_codes.py: 16 CLI envelope cases cover each code across set-widget, apply (--ack summary), validate, slots, decompose, add-node and foreach. All 16 fail onmain, where they get the generic codes, and pass on this branch.ruff check,ruff format --check, fullpytest: 9579 passed. 12 tests fail locally and also fail onmain(PATH- and environment-dependent):agent/test_command.py×5,test_code_search.py×5,test_node_deps::test_non_pep440…andtest_http::test_an_unloadable_supplement….