Skip to content

feat: add Nodes 2.0 alignment tools - #9750

Closed
benceruleanlu wants to merge 1 commit into
mainfrom
bl/nodes-2-alignment-snapping
Closed

benceruleanlu wants to merge 1 commit into
mainfrom
bl/nodes-2-alignment-snapping

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Mar 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Add Nodes 2.0 drag alignment snapping and expose richer multi-node arrangement actions from the right-click menu.

Changes

  • What: add an opt-in Comfy.Canvas.AlignNodesWhileDragging setting, snap Vue-node drags to nearby rendered node edges and centers with visible guides, add horizontal/vertical center alignment actions, and gate arrangement actions to the multi-node right-click menu instead of the selection-toolbox More Options menu.
  • Dependencies: none

Review Focus

  • Rendered-bounds snapping behavior during Vue-node drag
  • Context-menu-only gating for alignment/distribution actions
  • Drag-guide lifecycle and grid-snap precedence

Verification

  • pnpm test:unit -- src/renderer/extensions/vueNodes/layout/nodeAlignmentSnap.test.ts src/renderer/extensions/vueNodes/layout/useNodeDrag.test.ts src/composables/graph/useMoreOptionsMenu.test.ts src/composables/graph/useSelectionMenuOptions.test.ts
  • pnpm typecheck
  • pnpm typecheck:browser
  • pnpm format:check
  • pnpm lint
  • Added a Playwright spec for the Vue-node alignment path; local execution was blocked here because http://localhost:8188 was unavailable (ECONNREFUSED on /api/users).

Screenshots (if applicable)

  • None

┆Issue is synchronized with this Notion page by Unito

@github-actions

github-actions Bot commented Mar 11, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 03/11/2026, 07:08:55 PM UTC

Links

@github-actions

github-actions Bot commented Mar 11, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 561 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 548 / ❌ 0 / ⚠️ 1 / ⏭️ 10)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 10 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle: 4.57 MB gzip 🔴 +2.55 kB

Details

Summary

  • Raw size: 21.4 MB baseline 21.4 MB — 🔴 +10.7 kB
  • Gzip: 4.57 MB baseline 4.57 MB — 🔴 +2.55 kB
  • Brotli: 3.53 MB baseline 3.53 MB — 🔴 +1.85 kB
  • Bundles: 232 current • 232 baseline • 115 added / 115 removed

Category Glance
Graph Workspace 🔴 +7.36 kB (980 kB) · Data & Services 🔴 +2.9 kB (2.78 MB) · Other 🔴 +404 B (8.04 MB) · Vendor & Third-Party ⚪ 0 B (8.9 MB) · Panels & Settings ⚪ 0 B (438 kB) · Editors & Dialogs ⚪ 0 B (78.3 kB) · + 5 more

App Entry Points — 17.7 kB (baseline 17.7 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-D2R6dHT2.js (removed) 17.7 kB — 🟢 -17.7 kB 🟢 -6.26 kB 🟢 -5.46 kB
assets/index-DG-TRruf.js (new) — 17.7 kB 🔴 +17.7 kB 🔴 +6.26 kB 🔴 +5.41 kB

Status: 1 added / 1 removed

Graph Workspace — 980 kB (baseline 972 kB) • 🔴 +7.36 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DBxMjf1H.js (new) — 980 kB 🔴 +980 kB 🔴 +207 kB 🔴 +156 kB
assets/GraphView-BSu0YITV.js (removed) 972 kB — 🟢 -972 kB 🟢 -205 kB 🟢 -155 kB

Status: 1 added / 1 removed

Views & Navigation — 72.5 kB (baseline 72.5 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-CfiQruM-.js (removed) 15.5 kB — 🟢 -15.5 kB 🟢 -3.32 kB 🟢 -2.81 kB
assets/CloudSurveyView-DD2_VxjB.js (new) — 15.5 kB 🔴 +15.5 kB 🔴 +3.32 kB 🔴 +2.81 kB
assets/CloudLoginView-CQR0ZL07.js (new) — 11.5 kB 🔴 +11.5 kB 🔴 +3.21 kB 🔴 +2.83 kB
assets/CloudLoginView-CSF8ijcf.js (removed) 11.5 kB — 🟢 -11.5 kB 🟢 -3.21 kB 🟢 -2.84 kB
assets/CloudSignupView-B4YwYZ86.js (new) — 9.41 kB 🔴 +9.41 kB 🔴 +2.71 kB 🔴 +2.37 kB
assets/CloudSignupView-c4KvQD2T.js (removed) 9.41 kB — 🟢 -9.41 kB 🟢 -2.71 kB 🟢 -2.38 kB
assets/UserCheckView-B8Zqdjpl.js (removed) 8.42 kB — 🟢 -8.42 kB 🟢 -2.23 kB 🟢 -1.94 kB
assets/UserCheckView-DS20WAjN.js (new) — 8.42 kB 🔴 +8.42 kB 🔴 +2.22 kB 🔴 +1.93 kB
assets/CloudLayoutView--Pi0xJOr.js (new) — 6.56 kB 🔴 +6.56 kB 🔴 +2.17 kB 🔴 +1.88 kB
assets/CloudLayoutView-CnOO4Nr_.js (removed) 6.56 kB — 🟢 -6.56 kB 🟢 -2.17 kB 🟢 -1.87 kB
assets/CloudForgotPasswordView-DYMb4sR8.js (new) — 5.59 kB 🔴 +5.59 kB 🔴 +1.95 kB 🔴 +1.72 kB
assets/CloudForgotPasswordView-KEMUUQBm.js (removed) 5.59 kB — 🟢 -5.59 kB 🟢 -1.95 kB 🟢 -1.71 kB
assets/CloudAuthTimeoutView-BUrObu3r.js (new) — 4.96 kB 🔴 +4.96 kB 🔴 +1.79 kB 🔴 +1.57 kB
assets/CloudAuthTimeoutView-O7sbwcAK.js (removed) 4.96 kB — 🟢 -4.96 kB 🟢 -1.79 kB 🟢 -1.57 kB
assets/CloudSubscriptionRedirectView-Dw4ujv_g.js (new) — 4.78 kB 🔴 +4.78 kB 🔴 +1.8 kB 🔴 +1.59 kB
assets/CloudSubscriptionRedirectView-DxxgBs5V.js (removed) 4.78 kB — 🟢 -4.78 kB 🟢 -1.8 kB 🟢 -1.59 kB
assets/UserSelectView-CUsaNWVV.js (new) — 4.55 kB 🔴 +4.55 kB 🔴 +1.67 kB 🔴 +1.48 kB
assets/UserSelectView-Cw8uu6S8.js (removed) 4.55 kB — 🟢 -4.55 kB 🟢 -1.67 kB 🟢 -1.48 kB
assets/CloudSorryContactSupportView-B10VB5H_.js 1.02 kB 1.02 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/layout-CNUFnjHE.js 296 B 296 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 9 added / 9 removed

Panels & Settings — 438 kB (baseline 438 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SecretsPanel-CIgh8Jm4.js (removed) 21.5 kB — 🟢 -21.5 kB 🟢 -5.29 kB 🟢 -4.65 kB
assets/SecretsPanel-DSFumwwz.js (new) — 21.5 kB 🔴 +21.5 kB 🔴 +5.29 kB 🔴 +4.68 kB
assets/LegacyCreditsPanel-Cc1gvxPh.js (new) — 20.7 kB 🔴 +20.7 kB 🔴 +5.58 kB 🔴 +4.91 kB
assets/LegacyCreditsPanel-CEgzeAvX.js (removed) 20.7 kB — 🟢 -20.7 kB 🟢 -5.59 kB 🟢 -4.92 kB
assets/SubscriptionPanel-CGSRCxEn.js (removed) 18.7 kB — 🟢 -18.7 kB 🟢 -4.75 kB 🟢 -4.18 kB
assets/SubscriptionPanel-DwfwbIxy.js (new) — 18.7 kB 🔴 +18.7 kB 🔴 +4.76 kB 🔴 +4.18 kB
assets/KeybindingPanel-BrjiD7_i.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +3.53 kB 🔴 +3.13 kB
assets/KeybindingPanel-Dz4S7Ejx.js (removed) 12.3 kB — 🟢 -12.3 kB 🟢 -3.54 kB 🟢 -3.14 kB
assets/AboutPanel-DI7PITWB.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.12 kB 🟢 -2.81 kB
assets/AboutPanel-UED56RPV.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.12 kB 🔴 +2.8 kB
assets/ExtensionPanel-BeEhRpqQ.js (new) — 9.42 kB 🔴 +9.42 kB 🔴 +2.66 kB 🔴 +2.37 kB
assets/ExtensionPanel-DLJHNZn0.js (removed) 9.42 kB — 🟢 -9.42 kB 🟢 -2.67 kB 🟢 -2.38 kB
assets/ServerConfigPanel-D1tr8AGK.js (removed) 6.49 kB — 🟢 -6.49 kB 🟢 -2.13 kB 🟢 -1.91 kB
assets/ServerConfigPanel-DdAocrEw.js (new) — 6.49 kB 🔴 +6.49 kB 🔴 +2.13 kB 🔴 +1.91 kB
assets/UserPanel-CZWjNJSU.js (removed) 6.2 kB — 🟢 -6.2 kB 🟢 -2.01 kB 🟢 -1.76 kB
assets/UserPanel-Debu1S5O.js (new) — 6.2 kB 🔴 +6.2 kB 🔴 +2.01 kB 🔴 +1.76 kB
assets/cloudRemoteConfig-CW0vjyCQ.js (new) — 1.48 kB 🔴 +1.48 kB 🔴 +725 B 🔴 +633 B
assets/cloudRemoteConfig-DSserMcm.js (removed) 1.48 kB — 🟢 -1.48 kB 🟢 -723 B 🟢 -628 B
assets/refreshRemoteConfig-D3M-Kw-x.js (removed) 1.14 kB — 🟢 -1.14 kB 🟢 -520 B 🟢 -463 B
assets/refreshRemoteConfig-hYsir9pN.js (new) — 1.14 kB 🔴 +1.14 kB 🔴 +520 B 🔴 +465 B
assets/config-DrIhAAj_.js 1.22 kB 1.22 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BH2NzvA8.js 27.8 kB 27.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BlDXFCUy.js 27.9 kB 27.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BPjNSOku.js 24.5 kB 24.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-BSfPhDgX.js 34.2 kB 34.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CTDqwZOP.js 30.5 kB 30.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-CY1qXPWG.js 29.9 kB 29.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-D4yKfrVw.js 28.8 kB 28.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-DKN0RxMZ.js 28.7 kB 28.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-hSQJdwwK.js 32.4 kB 32.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-rqXXfmcr.js 23.9 kB 23.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/settings-So53ZGaK.js 38.5 kB 38.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 10 added / 10 removed

User & Accounts — 16.1 kB (baseline 16.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-Bg3dDD-k.js (new) — 3.4 kB 🔴 +3.4 kB 🔴 +1.18 kB 🔴 +991 B
assets/auth-C-uB5PNY.js (removed) 3.4 kB — 🟢 -3.4 kB 🟢 -1.18 kB 🟢 -991 B
assets/SignUpForm-BxlVO4kX.js (removed) 3.01 kB — 🟢 -3.01 kB 🟢 -1.23 kB 🟢 -1.09 kB
assets/SignUpForm-DB7Sic8V.js (new) — 3.01 kB 🔴 +3.01 kB 🔴 +1.23 kB 🔴 +1.08 kB
assets/UpdatePasswordContent-BoY0W_o4.js (new) — 2.41 kB 🔴 +2.41 kB 🔴 +1.09 kB 🔴 +958 B
assets/UpdatePasswordContent-DflsZU4K.js (removed) 2.41 kB — 🟢 -2.41 kB 🟢 -1.09 kB 🟢 -960 B
assets/firebaseAuthStore-C0_myXD3.js (new) — 831 B 🔴 +831 B 🔴 +405 B 🔴 +354 B
assets/firebaseAuthStore-CT9B66cR.js (removed) 831 B — 🟢 -831 B 🟢 -406 B 🟢 -358 B
assets/auth-KoA-oXkp.js (new) — 357 B 🔴 +357 B 🔴 +223 B 🔴 +193 B
assets/auth-VgmRXXGA.js (removed) 357 B — 🟢 -357 B 🟢 -223 B 🟢 -192 B
assets/PasswordFields-OroLpK9a.js 4.51 kB 4.51 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WorkspaceProfilePic-CuIu1FoW.js 1.59 kB 1.59 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 5 added / 5 removed

Editors & Dialogs — 78.3 kB (baseline 78.3 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useShareDialog-C2fJcXxM.js (removed) 77.5 kB — 🟢 -77.5 kB 🟢 -16.6 kB 🟢 -14.2 kB
assets/useShareDialog-kpudVzu8.js (new) — 77.5 kB 🔴 +77.5 kB 🔴 +16.6 kB 🔴 +14.2 kB
assets/useSubscriptionDialog-iBJrn6zo.js (new) — 779 B 🔴 +779 B 🔴 +397 B 🔴 +340 B
assets/useSubscriptionDialog-Sg0s0wuu.js (removed) 779 B — 🟢 -779 B 🟢 -398 B 🟢 -343 B

Status: 2 added / 2 removed

UI Components — 56.7 kB (baseline 56.7 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-9prQSIfb.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.9 kB 🔴 +3.48 kB
assets/ComfyQueueButton-Dtl6WQLI.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.9 kB 🟢 -3.48 kB
assets/useTerminalTabs-1O6Daphd.js (removed) 9.87 kB — 🟢 -9.87 kB 🟢 -3.41 kB 🟢 -3.01 kB
assets/useTerminalTabs-toHxTbzn.js (new) — 9.87 kB 🔴 +9.87 kB 🔴 +3.41 kB 🔴 +3 kB
assets/SubscribeButton-BCN-vgLz.js (removed) 2.34 kB — 🟢 -2.34 kB 🟢 -1.01 kB 🟢 -881 B
assets/SubscribeButton-CdCzyNyM.js (new) — 2.34 kB 🔴 +2.34 kB 🔴 +1.01 kB 🔴 +880 B
assets/cloudFeedbackTopbarButton-C82j9cC9.js (new) — 1.42 kB 🔴 +1.42 kB 🔴 +744 B 🔴 +660 B
assets/cloudFeedbackTopbarButton-DKW0WoDQ.js (removed) 1.42 kB — 🟢 -1.42 kB 🟢 -747 B 🟢 -660 B
assets/ComfyQueueButton-BlkB8PfH.js (new) — 836 B 🔴 +836 B 🔴 +412 B 🔴 +363 B
assets/ComfyQueueButton-DJGm7mdE.js (removed) 836 B — 🟢 -836 B 🟢 -412 B 🟢 -371 B
assets/Button-DqdxSYaB.js 3.22 kB 3.22 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/CloudBadge-DbtS52o1.js 1.11 kB 1.11 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/FormSearchInput-C9jzAgkK.js 3.73 kB 3.73 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/ScrubableNumberInput-4EP9DGiL.js 6.11 kB 6.11 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/toggle-group-Co1F_GGC.js 3.83 kB 3.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/TopbarBadge-CFptnCMb.js 7.39 kB 7.39 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/UserAvatar-BnVnoaj-.js 1.19 kB 1.19 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-DJ3L6d0X.js 1.84 kB 1.84 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 5 added / 5 removed

Data & Services — 2.78 MB (baseline 2.77 MB) • 🔴 +2.9 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-C2slgAf5.js (new) — 1.94 MB 🔴 +1.94 MB 🔴 +435 kB 🔴 +326 kB
assets/dialogService-CMQrdIuj.js (removed) 1.94 MB — 🟢 -1.94 MB 🟢 -435 kB 🟢 -325 kB
assets/api-CwnkW3H2.js (new) — 695 kB 🔴 +695 kB 🔴 +157 kB 🔴 +125 kB
assets/api-DYMLs61N.js (removed) 693 kB — 🟢 -693 kB 🟢 -156 kB 🟢 -124 kB
assets/load3dService-BvHf-B3b.js (removed) 91.1 kB — 🟢 -91.1 kB 🟢 -19.1 kB 🟢 -16.4 kB
assets/load3dService-CNvlUTeh.js (new) — 91.1 kB 🔴 +91.1 kB 🔴 +19.1 kB 🔴 +16.4 kB
assets/extensionStore-ujGYCXxQ.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -4.64 kB 🟢 -4.1 kB
assets/extensionStore-Z50zo4TC.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +4.63 kB 🔴 +4.09 kB
assets/workflowShareService-ByOBWEUF.js (new) — 13.3 kB 🔴 +13.3 kB 🔴 +4.1 kB 🔴 +3.63 kB
assets/workflowShareService-DblgoNBv.js (removed) 13.3 kB — 🟢 -13.3 kB 🟢 -4.1 kB 🟢 -3.63 kB
assets/releaseStore-CPWUjIob.js (new) — 7.96 kB 🔴 +7.96 kB 🔴 +2.22 kB 🔴 +1.95 kB
assets/releaseStore-CxB9fXlj.js (removed) 7.96 kB — 🟢 -7.96 kB 🟢 -2.22 kB 🟢 -1.95 kB
assets/keybindingService-DRQaje3Q.js (new) — 7.16 kB 🔴 +7.16 kB 🔴 +1.72 kB 🔴 +1.48 kB
assets/keybindingService-pycADG60.js (removed) 7.16 kB — 🟢 -7.16 kB 🟢 -1.72 kB 🟢 -1.48 kB
assets/bootstrapStore-Dxd8OHIx.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -875 B 🟢 -798 B
assets/bootstrapStore-XOJAUa7L.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +877 B 🔴 +794 B
assets/userStore-DhBATmU-.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +720 B 🔴 +670 B
assets/userStore-MIuUzvEs.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -720 B 🟢 -671 B
assets/audioService-B9hJv2KB.js (new) — 1.73 kB 🔴 +1.73 kB 🔴 +846 B 🔴 +725 B
assets/audioService-D0_cFmr6.js (removed) 1.73 kB — 🟢 -1.73 kB 🟢 -847 B 🟢 -724 B
assets/releaseStore-Bg9tGcZ5.js (removed) 803 B — 🟢 -803 B 🟢 -402 B 🟢 -359 B
assets/releaseStore-SFCQMm7D.js (new) — 803 B 🔴 +803 B 🔴 +403 B 🔴 +354 B
assets/settingStore-_w0q4-02.js (new) — 787 B 🔴 +787 B 🔴 +405 B 🔴 +356 B
assets/settingStore-C0kooEVc.js (removed) 787 B — 🟢 -787 B 🟢 -405 B 🟢 -357 B
assets/workflowDraftStore-DfN3GzUA.js (new) — 779 B 🔴 +779 B 🔴 +396 B 🔴 +343 B
assets/workflowDraftStore-ZYFGqYQe.js (removed) 779 B — 🟢 -779 B 🟢 -398 B 🟢 -348 B
assets/dialogService-BCXgHU0U.js (new) — 768 B 🔴 +768 B 🔴 +388 B 🔴 +340 B
assets/dialogService-DoN8bx1v.js (removed) 768 B — 🟢 -768 B 🟢 -389 B 🟢 -343 B
assets/serverConfigStore-C6zlD0bA.js 2.32 kB 2.32 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 14 added / 14 removed

Utilities & Hooks — 56.8 kB (baseline 56.8 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useLoad3d-BDE3ywhh.js (removed) 14.6 kB — 🟢 -14.6 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/useLoad3d-CT6kQ-bJ.js (new) — 14.6 kB 🔴 +14.6 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/useLoad3dViewer-C-VfIbpu.js (new) — 14.1 kB 🔴 +14.1 kB 🔴 +3.15 kB 🔴 +2.8 kB
assets/useLoad3dViewer-DdhmS85o.js (removed) 14.1 kB — 🟢 -14.1 kB 🟢 -3.15 kB 🟢 -2.8 kB
assets/useFeatureFlags-CLSJvFzQ.js (new) — 4.86 kB 🔴 +4.86 kB 🔴 +1.37 kB 🔴 +1.17 kB
assets/useFeatureFlags-DA5B2qBD.js (removed) 4.86 kB — 🟢 -4.86 kB 🟢 -1.37 kB 🟢 -1.17 kB
assets/useWorkspaceUI-CY77wlQr.js (removed) 3 kB — 🟢 -3 kB 🟢 -821 B 🟢 -703 B
assets/useWorkspaceUI-CzS5pZJq.js (new) — 3 kB 🔴 +3 kB 🔴 +823 B 🔴 +703 B
assets/subscriptionCheckoutUtil-Bb3Q8Uiw.js (new) — 2.53 kB 🔴 +2.53 kB 🔴 +1.06 kB 🔴 +952 B
assets/subscriptionCheckoutUtil-CyHZ3Ut6.js (removed) 2.53 kB — 🟢 -2.53 kB 🟢 -1.06 kB 🟢 -955 B
assets/useExternalLink-BNSGJIMa.js (new) — 1.66 kB 🔴 +1.66 kB 🔴 +770 B 🔴 +679 B
assets/useExternalLink-Cwe7bDqE.js (removed) 1.66 kB — 🟢 -1.66 kB 🟢 -772 B 🟢 -678 B
assets/useErrorHandling-BFtDWOwD.js (removed) 1.5 kB — 🟢 -1.5 kB 🟢 -630 B 🟢 -533 B
assets/useErrorHandling-C5boIxYA.js (new) — 1.5 kB 🔴 +1.5 kB 🔴 +629 B 🔴 +533 B
assets/useCopyToClipboard-D-c32kev.js (removed) 944 B — 🟢 -944 B 🟢 -427 B 🟢 -370 B
assets/useCopyToClipboard-DGXtdMR9.js (new) — 944 B 🔴 +944 B 🔴 +428 B 🔴 +366 B
assets/useLoad3d-C6M8avY4.js (new) — 902 B 🔴 +902 B 🔴 +441 B 🔴 +397 B
assets/useLoad3d-SczKDaCY.js (removed) 902 B — 🟢 -902 B 🟢 -443 B 🟢 -397 B
assets/useLoad3dViewer-4nV1jSeB.js (removed) 881 B — 🟢 -881 B 🟢 -428 B 🟢 -382 B
assets/useLoad3dViewer-Bu_osYjl.js (new) — 881 B 🔴 +881 B 🔴 +427 B 🔴 +383 B
assets/audioUtils-BMQVlmsl.js (removed) 858 B — 🟢 -858 B 🟢 -499 B 🟢 -405 B
assets/audioUtils-C3CQdGtV.js (new) — 858 B 🔴 +858 B 🔴 +500 B 🔴 +402 B
assets/useCurrentUser-BTNVUXPX.js (removed) 765 B — 🟢 -765 B 🟢 -393 B 🟢 -342 B
assets/useCurrentUser-LC1W0p9T.js (new) — 765 B 🔴 +765 B 🔴 +392 B 🔴 +340 B
assets/useWorkspaceSwitch-JlReCNv1.js (new) — 688 B 🔴 +688 B 🔴 +350 B 🔴 +296 B
assets/useWorkspaceSwitch-jrgEBEy9.js (removed) 688 B — 🟢 -688 B 🟢 -350 B 🟢 -297 B
assets/_plugin-vue_export-helper-C4xK3rHS.js 315 B 315 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/colorUtil-DtNbLD4C.js 7 kB 7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/envUtil-Clzmwvt4.js 466 B 466 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/markdownRendererUtil-DOdPeMQc.js 1.56 kB 1.56 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/SkeletonUtils-Cybe2l6l.js 133 B 133 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 13 added / 13 removed

Vendor & Third-Party — 8.9 MB (baseline 8.9 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-axios-Cp6hch1I.js 70.7 kB 70.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-chart-D82zUMvC.js 399 kB 399 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-firebase-BvMr43CG.js 836 kB 836 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-i18n-DNX73mqE.js 133 kB 133 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-markdown-D5S6AC80.js 103 kB 103 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-C-wiidU-.js 1.54 MB 1.54 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-DrUjG48Z.js 1.72 MB 1.72 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-reka-ui-DlFrLeZ5.js 428 kB 428 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-sentry-SQwstEKc.js 182 kB 182 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-C69yBO64.js 1.8 MB 1.8 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-DTO2QA4Q.js 634 kB 634 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-core-DtiQ1dr9.js 311 kB 311 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vueuse-7Q5M-X2w.js 125 kB 125 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-Co8jWZ4q.js 374 kB 374 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-yjs-CP_4YO8u.js 143 kB 143 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-zod-DcCUUPIi.js 109 kB 109 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 8.04 MB (baseline 8.04 MB) • 🔴 +404 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/i18n-CC9ETilT.js (new) — 546 kB 🔴 +546 kB 🔴 +106 kB 🔴 +82.9 kB
assets/i18n-D3DRtbOT.js (removed) 545 kB — 🟢 -545 kB 🟢 -106 kB 🟢 -82.8 kB
assets/core-CEG8IeCA.js (removed) 73.7 kB — 🟢 -73.7 kB 🟢 -19 kB 🟢 -16.2 kB
assets/core-Ct5SYPbe.js (new) — 73.7 kB 🔴 +73.7 kB 🔴 +19 kB 🔴 +16.2 kB
assets/groupNode-BySLOqoq.js (new) — 71.8 kB 🔴 +71.8 kB 🔴 +17.7 kB 🔴 +15.6 kB
assets/groupNode-CdoOPlNF.js (removed) 71.8 kB — 🟢 -71.8 kB 🟢 -17.7 kB 🟢 -15.5 kB
assets/WidgetSelect-DSGqQNJd.js (removed) 57.8 kB — 🟢 -57.8 kB 🟢 -12.4 kB 🟢 -10.7 kB
assets/WidgetSelect-gv51WF-Z.js (new) — 57.8 kB 🔴 +57.8 kB 🔴 +12.4 kB 🔴 +10.7 kB
assets/SubscriptionRequiredDialogContentWorkspace-BHtzpoHh.js (new) — 46.2 kB 🔴 +46.2 kB 🔴 +8.65 kB 🔴 +7.49 kB
assets/SubscriptionRequiredDialogContentWorkspace-CVgQJhRK.js (removed) 46.2 kB — 🟢 -46.2 kB 🟢 -8.66 kB 🟢 -7.49 kB
assets/WidgetPainter-B6kL5_kQ.js (removed) 32.9 kB — 🟢 -32.9 kB 🟢 -7.97 kB 🟢 -7.07 kB
assets/WidgetPainter-EYXi-wI3.js (new) — 32.9 kB 🔴 +32.9 kB 🔴 +7.97 kB 🔴 +7.07 kB
assets/Load3DControls-BqeCVSXo.js (new) — 30.9 kB 🔴 +30.9 kB 🔴 +5.34 kB 🔴 +4.65 kB
assets/Load3DControls-DmbJWU_i.js (removed) 30.9 kB — 🟢 -30.9 kB 🟢 -5.34 kB 🟢 -4.64 kB
assets/WorkspacePanelContent-AAORK2Lu.js (new) — 29.3 kB 🔴 +29.3 kB 🔴 +6.16 kB 🔴 +5.4 kB
assets/WorkspacePanelContent-DJ_crR1h.js (removed) 29.3 kB — 🟢 -29.3 kB 🟢 -6.16 kB 🟢 -5.42 kB
assets/SubscriptionRequiredDialogContent-hFQG5D9i.js (new) — 25.6 kB 🔴 +25.6 kB 🔴 +6.56 kB 🔴 +5.78 kB
assets/SubscriptionRequiredDialogContent-L0FKmbRL.js (removed) 25.6 kB — 🟢 -25.6 kB 🟢 -6.56 kB 🟢 -5.78 kB
assets/Load3dViewerContent-DCp0DOKn.js (new) — 23 kB 🔴 +23 kB 🔴 +5.18 kB 🔴 +4.5 kB
assets/Load3dViewerContent-SzThpY6P.js (removed) 23 kB — 🟢 -23 kB 🟢 -5.18 kB 🟢 -4.5 kB
assets/WidgetImageCrop-BuALpgsO.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.51 kB 🟢 -4.85 kB
assets/WidgetImageCrop-CilDFchX.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.52 kB 🔴 +4.85 kB
assets/SubscriptionPanelContentWorkspace-DPIagIen.js (removed) 22 kB — 🟢 -22 kB 🟢 -5.11 kB 🟢 -4.49 kB
assets/SubscriptionPanelContentWorkspace-Z5whHKBX.js (new) — 22 kB 🔴 +22 kB 🔴 +5.11 kB 🔴 +4.49 kB
assets/CurrentUserPopoverWorkspace-Djm4dS0K.js (new) — 20.5 kB 🔴 +20.5 kB 🔴 +4.94 kB 🔴 +4.42 kB
assets/CurrentUserPopoverWorkspace-dlYIHL7l.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -4.94 kB 🟢 -4.4 kB
assets/SignInContent-Cc_yLCHQ.js (removed) 18.9 kB — 🟢 -18.9 kB 🟢 -4.77 kB 🟢 -4.18 kB
assets/SignInContent-DTTquj08.js (new) — 18.9 kB 🔴 +18.9 kB 🔴 +4.77 kB 🔴 +4.18 kB
assets/WidgetInputNumber-BrJTtWir.js (new) — 18.1 kB 🔴 +18.1 kB 🔴 +4.64 kB 🔴 +4.12 kB
assets/WidgetInputNumber-U2ZyQLHW.js (removed) 18.1 kB — 🟢 -18.1 kB 🟢 -4.64 kB 🟢 -4.12 kB
assets/WidgetRecordAudio-DDnwY7CI.js (removed) 17.4 kB — 🟢 -17.4 kB 🟢 -5.01 kB 🟢 -4.48 kB
assets/WidgetRecordAudio-Dz0_95Dc.js (new) — 17.4 kB 🔴 +17.4 kB 🔴 +5.02 kB 🔴 +4.49 kB
assets/Load3D-kGBPVLZo.js (removed) 16.2 kB — 🟢 -16.2 kB 🟢 -4.03 kB 🟢 -3.51 kB
assets/Load3D-l1Y2DME3.js (new) — 16.2 kB 🔴 +16.2 kB 🔴 +4.03 kB 🔴 +3.51 kB
assets/load3d--fSlLSuG.js (new) — 14.8 kB 🔴 +14.8 kB 🔴 +4.2 kB 🔴 +3.65 kB
assets/load3d-BnZrFe-4.js (removed) 14.8 kB — 🟢 -14.8 kB 🟢 -4.21 kB 🟢 -3.65 kB
assets/AudioPreviewPlayer-Bx6Hsx1p.js (new) — 11 kB 🔴 +11 kB 🔴 +3.25 kB 🔴 +2.92 kB
assets/AudioPreviewPlayer-PwIUVFxt.js (removed) 11 kB — 🟢 -11 kB 🟢 -3.25 kB 🟢 -2.91 kB
assets/nodeTemplates-B_Fy0A7_.js (new) — 9.34 kB 🔴 +9.34 kB 🔴 +3.27 kB 🔴 +2.88 kB
assets/nodeTemplates-CtQI2-4t.js (removed) 9.34 kB — 🟢 -9.34 kB 🟢 -3.27 kB 🟢 -2.88 kB
assets/InviteMemberDialogContent-BZIfv0Ie.js (new) — 7.37 kB 🔴 +7.37 kB 🔴 +2.3 kB 🔴 +2.01 kB
assets/InviteMemberDialogContent-CTvcyXtZ.js (removed) 7.37 kB — 🟢 -7.37 kB 🟢 -2.3 kB 🟢 -2.01 kB
assets/Load3DConfiguration-BA_I2RJ9.js (removed) 6.27 kB — 🟢 -6.27 kB 🟢 -1.92 kB 🟢 -1.68 kB
assets/Load3DConfiguration-D_trysgt.js (new) — 6.27 kB 🔴 +6.27 kB 🔴 +1.91 kB 🔴 +1.67 kB
assets/onboardingCloudRoutes-B90_ILfL.js (removed) 6.07 kB — 🟢 -6.07 kB 🟢 -1.89 kB 🟢 -1.64 kB
assets/onboardingCloudRoutes-DZtCTbmQ.js (new) — 6.07 kB 🔴 +6.07 kB 🔴 +1.9 kB 🔴 +1.63 kB
assets/CreateWorkspaceDialogContent-Ds4mAZ7s.js (removed) 5.54 kB — 🟢 -5.54 kB 🟢 -2 kB 🟢 -1.75 kB
assets/CreateWorkspaceDialogContent-Dsovr9sg.js (new) — 5.54 kB 🔴 +5.54 kB 🔴 +2 kB 🔴 +1.76 kB
assets/FreeTierDialogContent-CIy-yu1E.js (removed) 5.42 kB — 🟢 -5.42 kB 🟢 -1.91 kB 🟢 -1.69 kB
assets/FreeTierDialogContent-XAS9PgLr.js (new) — 5.42 kB 🔴 +5.42 kB 🔴 +1.91 kB 🔴 +1.68 kB
assets/EditWorkspaceDialogContent-KafvScqQ.js (new) — 5.35 kB 🔴 +5.35 kB 🔴 +1.97 kB 🔴 +1.72 kB
assets/EditWorkspaceDialogContent-rOVxyHcW.js (removed) 5.35 kB — 🟢 -5.35 kB 🟢 -1.97 kB 🟢 -1.72 kB
assets/ValueControlPopover-CQsX7G8O.js (new) — 4.93 kB 🔴 +4.93 kB 🔴 +1.77 kB 🔴 +1.58 kB
assets/ValueControlPopover-D-VwszPU.js (removed) 4.93 kB — 🟢 -4.93 kB 🟢 -1.77 kB 🟢 -1.58 kB
assets/Preview3d-CReePIQ7.js (removed) 4.89 kB — 🟢 -4.89 kB 🟢 -1.61 kB 🟢 -1.4 kB
assets/Preview3d-vDafP93y.js (new) — 4.89 kB 🔴 +4.89 kB 🔴 +1.61 kB 🔴 +1.4 kB
assets/CancelSubscriptionDialogContent-Cj6agOMj.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.8 kB 🟢 -1.58 kB
assets/CancelSubscriptionDialogContent-DP5jfBix.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.8 kB 🔴 +1.57 kB
assets/WidgetTextarea-BsQ06GmS.js (removed) 4.26 kB — 🟢 -4.26 kB 🟢 -1.64 kB 🟢 -1.45 kB
assets/WidgetTextarea-Dolo3kyD.js (new) — 4.26 kB 🔴 +4.26 kB 🔴 +1.64 kB 🔴 +1.45 kB
assets/DeleteWorkspaceDialogContent-Cpfg9do7.js (removed) 4.25 kB — 🟢 -4.25 kB 🟢 -1.64 kB 🟢 -1.43 kB
assets/DeleteWorkspaceDialogContent-kReaQLcO.js (new) — 4.25 kB 🔴 +4.25 kB 🔴 +1.64 kB 🔴 +1.43 kB
assets/WidgetWithControl-CyH9JwVy.js (removed) 4.17 kB — 🟢 -4.17 kB 🟢 -1.81 kB 🟢 -1.63 kB
assets/WidgetWithControl-w_bYD40z.js (new) — 4.17 kB 🔴 +4.17 kB 🔴 +1.82 kB 🔴 +1.62 kB
assets/LeaveWorkspaceDialogContent-DwGu1Er4.js (new) — 4.08 kB 🔴 +4.08 kB 🔴 +1.59 kB 🔴 +1.39 kB
assets/LeaveWorkspaceDialogContent-YeOh0jGB.js (removed) 4.08 kB — 🟢 -4.08 kB 🟢 -1.59 kB 🟢 -1.38 kB
assets/RemoveMemberDialogContent-CAXFgdv8.js (removed) 4.06 kB — 🟢 -4.06 kB 🟢 -1.54 kB 🟢 -1.35 kB
assets/RemoveMemberDialogContent-DhK6AE0j.js (new) — 4.06 kB 🔴 +4.06 kB 🔴 +1.54 kB 🔴 +1.35 kB
assets/RevokeInviteDialogContent-B78zakt_.js (new) — 3.97 kB 🔴 +3.97 kB 🔴 +1.55 kB 🔴 +1.36 kB
assets/RevokeInviteDialogContent-DUDy3P7q.js (removed) 3.97 kB — 🟢 -3.97 kB 🟢 -1.55 kB 🟢 -1.36 kB
assets/InviteMemberUpsellDialogContent-BMT1SCdQ.js (removed) 3.86 kB — 🟢 -3.86 kB 🟢 -1.42 kB 🟢 -1.24 kB
assets/InviteMemberUpsellDialogContent-CsW7lHyt.js (new) — 3.86 kB 🔴 +3.86 kB 🔴 +1.42 kB 🔴 +1.24 kB
assets/tierBenefits-Bf4Hdf5k.js (new) — 3.66 kB 🔴 +3.66 kB 🔴 +1.31 kB 🔴 +1.15 kB
assets/tierBenefits-Cn9JjqdY.js (removed) 3.66 kB — 🟢 -3.66 kB 🟢 -1.31 kB 🟢 -1.17 kB
assets/saveMesh-DLy5RlCi.js (removed) 3.42 kB — 🟢 -3.42 kB 🟢 -1.48 kB 🟢 -1.31 kB
assets/saveMesh-DtNx4ILX.js (new) — 3.42 kB 🔴 +3.42 kB 🔴 +1.47 kB 🔴 +1.3 kB
assets/cloudSessionCookie-BHPH4Jfo.js (removed) 3.14 kB — 🟢 -3.14 kB 🟢 -1.1 kB 🟢 -976 B
assets/cloudSessionCookie-Bkq9OSOi.js (new) — 3.14 kB 🔴 +3.14 kB 🔴 +1.11 kB 🔴 +999 B
assets/GlobalToast-Cgs_2WRG.js (new) — 2.91 kB 🔴 +2.91 kB 🔴 +1.21 kB 🔴 +1.03 kB
assets/GlobalToast-CXpFvJl7.js (removed) 2.91 kB — 🟢 -2.91 kB 🟢 -1.21 kB 🟢 -1.07 kB
assets/ApiNodesSignInContent-Ddyt5tQn.js (new) — 2.69 kB 🔴 +2.69 kB 🔴 +1.05 kB 🔴 +923 B
assets/ApiNodesSignInContent-mjEa9-G3.js (removed) 2.69 kB — 🟢 -2.69 kB 🟢 -1.05 kB 🟢 -920 B
assets/SubscribeToRun-BM9F8oAZ.js (new) — 2.06 kB 🔴 +2.06 kB 🔴 +951 B 🔴 +848 B
assets/SubscribeToRun-DMAy8mjX.js (removed) 2.06 kB — 🟢 -2.06 kB 🟢 -949 B 🟢 -838 B
assets/CloudRunButtonWrapper-BUylZiWD.js (new) — 1.72 kB 🔴 +1.72 kB 🔴 +804 B 🔴 +735 B
assets/CloudRunButtonWrapper-D2suiKuw.js (removed) 1.72 kB — 🟢 -1.72 kB 🟢 -802 B 🟢 -721 B
assets/cloudBadges-NdWjrYp7.js (removed) 1.54 kB — 🟢 -1.54 kB 🟢 -794 B 🟢 -686 B
assets/cloudBadges-zNtvsdzO.js (new) — 1.54 kB 🔴 +1.54 kB 🔴 +794 B 🔴 +694 B
assets/signInSchema-ByUj2lKX.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +563 B 🔴 +519 B
assets/signInSchema-CkI2M2RC.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -564 B 🟢 -511 B
assets/previousFullPath-Chr663zb.js (removed) 1.39 kB — 🟢 -1.39 kB 🟢 -651 B 🟢 -572 B
assets/previousFullPath-DBfx3dTT.js (new) — 1.39 kB 🔴 +1.39 kB 🔴 +651 B 🔴 +583 B
assets/cloudSubscription-Cws75ZiX.js (removed) 1.37 kB — 🟢 -1.37 kB 🟢 -674 B 🟢 -578 B
assets/cloudSubscription-DdTEKkhE.js (new) — 1.37 kB 🔴 +1.37 kB 🔴 +675 B 🔴 +581 B
assets/Load3D-BxR11Npy.js (new) — 1.11 kB 🔴 +1.11 kB 🔴 +514 B 🔴 +459 B
assets/Load3D-CyGQ_p5J.js (removed) 1.11 kB — 🟢 -1.11 kB 🟢 -518 B 🟢 -456 B
assets/nightlyBadges-5LRX3e0m.js (removed) 1.04 kB — 🟢 -1.04 kB 🟢 -551 B 🟢 -488 B
assets/nightlyBadges-BCTwbXnZ.js (new) — 1.04 kB 🔴 +1.04 kB 🔴 +548 B 🔴 +485 B
assets/Load3dViewerContent-Dq_zQABk.js (removed) 1.04 kB — 🟢 -1.04 kB 🟢 -487 B 🟢 -430 B
assets/Load3dViewerContent-DTG_-yUa.js (new) — 1.04 kB 🔴 +1.04 kB 🔴 +484 B 🔴 +432 B
assets/SubscriptionPanelContentWorkspace-brJ_e2GH.js (new) — 963 B 🔴 +963 B 🔴 +457 B 🔴 +395 B
assets/SubscriptionPanelContentWorkspace-CKAlyLz-.js (removed) 963 B — 🟢 -963 B 🟢 -456 B 🟢 -395 B
assets/WidgetLegacy-CjtU0-JC.js (new) — 787 B 🔴 +787 B 🔴 +402 B 🔴 +343 B
assets/WidgetLegacy-CNZ6oNgY.js (removed) 787 B — 🟢 -787 B 🟢 -403 B 🟢 -349 B
assets/changeTracker-CzHoI3be.js (removed) 763 B — 🟢 -763 B 🟢 -391 B 🟢 -341 B
assets/changeTracker-kAccbqB_.js (new) — 763 B 🔴 +763 B 🔴 +392 B 🔴 +339 B
assets/graphHasMissingNodes-CAu0nkca.js (removed) 761 B — 🟢 -761 B 🟢 -373 B 🟢 -326 B
assets/graphHasMissingNodes-Duoo6l3w.js (new) — 761 B 🔴 +761 B 🔴 +373 B 🔴 +317 B
assets/i18n-B0ijQa6R.js (removed) 199 B — 🟢 -199 B 🟢 -162 B 🟢 -140 B
assets/i18n-H6-YbJrU.js (new) — 199 B 🔴 +199 B 🔴 +161 B 🔴 +140 B
assets/AnimationControls-CPCyy2bz.js 4.61 kB 4.61 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/auto-DaAGiCO7.js 1.7 kB 1.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/BaseViewTemplate-Be40t4Iu.js 1.78 kB 1.78 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/comfy-logo-single-BcOH_oP5.js 198 B 198 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/ComfyOrgHeader-BvczSZom.js 910 B 910 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-4Ex6JXL0.js 19.2 kB 19.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-4eY_jIIw.js 17.9 kB 17.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-B2u5OAt2.js 16.5 kB 16.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BAAf-WrY.js 16.4 kB 16.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-BwgnbfCS.js 16.5 kB 16.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CMf3AlGU.js 16.3 kB 16.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Db23kZm5.js 17 kB 17 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DTom9f1s.js 17.9 kB 17.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-uXFULtu8.js 15.4 kB 15.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-y391QX3e.js 15.6 kB 15.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-ZTJwiV8a.js 17.3 kB 17.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/constants-ogISyp4e.js 579 B 579 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/Loader-BzcmNzQH.js 1.14 kB 1.14 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-4PccOdiO.js 199 kB 199 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-A9K8E17X.js 140 kB 140 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BERG8Y4E.js 161 kB 161 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Bo_nk-LH.js 167 kB 167 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-BODcCr1I.js 182 kB 182 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-C9ucaZMP.js 158 kB 158 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CM3j3xAc.js 164 kB 164 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-cwloH2g5.js 139 kB 139 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-CZ_ZoKrz.js 190 kB 190 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-De96SAcR.js 222 kB 222 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-KB02fdvg.js 159 kB 159 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/Media3DTop-CFJ8TBAs.js 1.83 kB 1.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-C_U19GUN.js 1.43 kB 1.43 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-CZ773gJ9.js 1.81 kB 1.81 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaOtherTop-0qy_sUz9.js 1.02 kB 1.02 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaTextTop-BIFFsGpz.js 1.01 kB 1.01 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-D0Uxi_8W.js 2.78 kB 2.78 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-B8HFl03z.js 406 kB 406 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bhwr0_qt.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BnwYZsRe.js 494 kB 494 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BQQ7epXP.js 394 kB 394 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-C4H2Yzrv.js 366 kB 366 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Ci3336-6.js 399 kB 399 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CVMvffJd.js 453 kB 453 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Cxe4eF5X.js 402 kB 402 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D3rH0GXo.js 418 kB 418 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-LI1J_566.js 369 kB 369 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-ZRmGudls.js 402 kB 402 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/OBJLoader2WorkerModule-DTMpvldF.js 109 kB 109 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/Popover-X9cXugD_.js 3.65 kB 3.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/rolldown-runtime-DLICfi3-.js 1.97 kB 1.97 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/SelectValue-D3C-Eb3g.js 9.3 kB 9.3 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/Slider-x2XW5eO3.js 3.52 kB 3.52 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/src-D0nozNwP.js 251 B 251 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/SubscriptionBenefits-DdmixFh-.js 2.01 kB 2.01 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/telemetry-zZf2dHJ2.js 226 B 226 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/Textarea-DnTlfSYg.js 1.37 kB 1.37 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/types-DT3N7am7.js 204 B 204 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/VideoPlayOverlay-BOeozZ2P.js 1.35 kB 1.35 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widget-DIRwAHBY.js 3.01 kB 3.01 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetBoundingBox-D5TOmv7e.js 283 B 283 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetBoundingBox-DCgQGG34.js 3.19 kB 3.19 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-D4E64P4X.js 2.21 kB 2.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetColorPicker-D8oQNlgX.js 2.9 kB 2.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetCurve-C0pqvMMz.js 9.36 kB 9.36 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetGalleria-C2PVE-gv.js 3.6 kB 3.6 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-BbyK3jA-.js 7.35 kB 7.35 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetInputText-DkPMvFPh.js 2.89 kB 2.89 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetLayoutField-k8fLebiO.js 1.98 kB 1.98 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetMarkdown-nqccP48m.js 2.93 kB 2.93 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-tYaGazrB.js 1.11 kB 1.11 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetToggleSwitch-DnFQxqYv.js 3.54 kB 3.54 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetTypes-DzBxiY8I.js 393 B 393 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 55 added / 55 removed

@coderabbitai

coderabbitai Bot commented Mar 11, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Adds node alignment snapping functionality to canvas node dragging, including center-alignment modes, context menu integration, visual alignment guides, and a configurable "Align nodes while dragging" setting with comprehensive test coverage.

Changes

Cohort / File(s) Summary
Test Suites
browser_tests/tests/vueNodes/interactions/node/alignment.spec.ts, src/composables/graph/useMoreOptionsMenu.test.ts, src/composables/graph/useSelectionMenuOptions.test.ts, src/renderer/extensions/vueNodes/layout/nodeAlignmentSnap.test.ts, src/renderer/extensions/vueNodes/layout/useNodeDrag.test.ts
Playwright and unit tests validating drag alignment snapping behavior, menu visibility based on trigger source (context menu vs toolbar), and threshold-adjusted snap matching logic.
Core Alignment Snapping
src/renderer/extensions/vueNodes/layout/nodeAlignmentSnap.ts, src/lib/litegraph/src/utils/arrange.ts
New snapping module with resolveNodeAlignmentSnap function computing edge/center alignment guides and delta adjustments; updated arrange utilities to support horizontal-center and vertical-center modes with minimum 2-node requirement for alignment and 3-node requirement for distribution.
Type Definitions & Store
src/lib/litegraph/src/interfaces.ts, src/renderer/core/layout/store/layoutStore.ts
Introduced ArrangementDirection type extending direction values with horizontal-center and vertical-center; added vueDragSnapGuides reactive state for storing active alignment guides.
Drag & Canvas Rendering
src/renderer/extensions/vueNodes/layout/useNodeDrag.ts, src/lib/litegraph/src/LGraphCanvas.ts, src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts
Enhanced drag hook with alignment snap resolution, bounds computation, and guide updates; added canvas method _drawVueDragAlignmentGuides for rendering visual guides; cleanup of snap guides on drag state reset.
Menu & Alignment Options
src/composables/graph/useMoreOptionsMenu.ts, src/composables/graph/useSelectionMenuOptions.ts, src/composables/graph/contextMenuConverter.ts, src/composables/graph/useNodeArrangement.ts
Added trigger source tracking (contextmenu vs toolbar) to conditionally show alignment options only in right-click menu; parameterized getAlignmentOptions to return options based on selected node count; registered "Align Selected To" and "Distribute Nodes" menu items.
UI Components
src/renderer/extensions/vueNodes/components/LGraphNode.vue, src/renderer/extensions/vueNodes/components/NodeWidgets.vue, src/components/graph/selectionToolbox/NodeOptionsButton.vue
Updated context menu handlers to pass explicit 'contextmenu' trigger source; modified toolbar button to pass 'toolbar' trigger source when invoking node options.
Settings & Configuration
src/components/rightSidePanel/settings/TabGlobalSettings.vue, src/platform/settings/constants/coreSettings.ts, src/schemas/apiSchema.ts
Added reactive alignNodesWhileDragging setting bound to Comfy.Canvas.AlignNodesWhileDragging in global settings panel; registered boolean setting with default false and tooltip; updated schema validation.
Localization
src/locales/en/main.json, src/locales/en/settings.json
Added translation keys for "Horizontal Center", "Vertical Center" in context menu, and "Align nodes while dragging" in global settings with tooltip describing snap behavior.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Canvas as Canvas/VueNodes
    participant useNodeDrag
    participant Snap as resolveNodeAlignmentSnap
    participant LayoutStore as LayoutStore<br/>(vueDragSnapGuides)
    participant LGraphCanvas

    User->>Canvas: Start pointer drag on selection
    Canvas->>useNodeDrag: startDrag()
    useNodeDrag->>useNodeDrag: Compute draggedSelectionBounds<br/>& candidateBounds

    User->>Canvas: Move pointer (drag)
    Canvas->>useNodeDrag: handleDrag(dx, dy)
    useNodeDrag->>Snap: maybeResolveAlignmentSnap(delta)
    Snap->>Snap: Match edges/centers vs candidates<br/>within threshold
    Snap-->>useNodeDrag: Return {delta, guides}
    useNodeDrag->>LayoutStore: updateDragSnapGuides(guides)
    LayoutStore-->>useNodeDrag: vueDragSnapGuides updated
    Canvas->>LGraphCanvas: Render frame
    LGraphCanvas->>LGraphCanvas: _drawVueDragAlignmentGuides()
    LGraphCanvas-->>User: Display alignment guides

    User->>Canvas: Release pointer
    Canvas->>useNodeDrag: endDrag()
    useNodeDrag->>LayoutStore: Clear vueDragSnapGuides
    useNodeDrag->>Canvas: Apply snapped positions
    Canvas-->>User: Nodes aligned/snapped to position
Loading
sequenceDiagram
    participant User
    participant Node as Vue Node
    participant useMoreOptionsMenu
    participant useSelectionMenuOptions as useSelectionMenuOptions<br/>(getAlignmentOptions)
    participant Menu as Context Menu

    User->>Node: Right-click on node
    Node->>useMoreOptionsMenu: showNodeOptions(..., 'contextmenu')
    useMoreOptionsMenu->>useMoreOptionsMenu: Set nodeOptionsTriggerSource<br/>= 'contextmenu'
    
    useMoreOptionsMenu->>useSelectionMenuOptions: Check selectedNodes.length >= 2?
    alt Two or more nodes selected
        useSelectionMenuOptions->>useSelectionMenuOptions: getAlignmentOptions(count)
        useSelectionMenuOptions-->>useMoreOptionsMenu: ["Align Selected To", ...]
        useMoreOptionsMenu->>useMoreOptionsMenu: Push alignment options
    end
    
    useMoreOptionsMenu-->>Menu: Display menu items
    Menu-->>User: Show "Align Selected To" option
    
    User->>Menu: Select alignment direction
    Menu->>useNodeArrangement: applyAlign(direction)
    useNodeArrangement-->>User: Nodes aligned
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Hop along, alignment springs forth with glee,
Snap guides dancing where nodes shall be,
Center with purpose, edges align true,
Dragged into position, all neat and askew!
Canvas redraws with each perfect place,
Comfy nodes find their rightful space. 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'feat: add Nodes 2.0 alignment tools' clearly and concisely summarizes the main change—adding alignment functionality for Nodes 2.0.
Description check ✅ Passed The pull request description covers the required template sections: Summary explains the feature, Changes section details what was added with 'What' and 'Dependencies', Review Focus identifies critical areas, and Verification lists test commands.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bl/nodes-2-alignment-snapping

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Performance Report

ℹ️ Collecting baseline variance data (0/5 runs). Significance will appear after 2 main branch runs.

Metric Baseline PR Δ
canvas-idle: style recalcs 124 124 +1%
canvas-idle: layouts 0 0 —
canvas-idle: task duration 460ms 536ms +17%
canvas-mouse-sweep: style recalcs 178 181 +2%
canvas-mouse-sweep: layouts 12 12 -3%
canvas-mouse-sweep: task duration 893ms 1039ms +16%
dom-widget-clipping: style recalcs 46 44 -4%
dom-widget-clipping: layouts 0 0 +0%
dom-widget-clipping: task duration 395ms 402ms +2%
subgraph-dom-widget-clipping: style recalcs 75 77 +2%
subgraph-dom-widget-clipping: layouts 0 0 -100%
subgraph-dom-widget-clipping: task duration 440ms 458ms +4%
subgraph-idle: style recalcs 122 121 -1%
subgraph-idle: layouts 0 0 -100%
subgraph-idle: task duration 429ms 508ms +18%
subgraph-mouse-sweep: style recalcs 168 163 -3%
subgraph-mouse-sweep: layouts 16 16 +0%
subgraph-mouse-sweep: task duration 956ms 917ms -4%
Raw data
{
  "timestamp": "2026-03-11T19:12:57.331Z",
  "gitSha": "9fac72aae4733e7f8d165fb8a9acf8a0b39a72e9",
  "branch": "bl/nodes-2-alignment-snapping",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2023.1229999999982,
      "styleRecalcs": 124,
      "styleRecalcDurationMs": 31.409,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.4929999999999,
      "heapDeltaBytes": -4688380
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.4820000000113,
      "styleRecalcs": 124,
      "styleRecalcDurationMs": 31.019,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.39,
      "heapDeltaBytes": 2767020
    },
    {
      "name": "canvas-idle",
      "durationMs": 2033.9269999999487,
      "styleRecalcs": 125,
      "styleRecalcDurationMs": 35.802,
      "layouts": 1,
      "layoutDurationMs": 0.21199999999999994,
      "taskDurationMs": 533.832,
      "heapDeltaBytes": 3075460
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1891.8370000000095,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 59.503,
      "layouts": 12,
      "layoutDurationMs": 4.118,
      "taskDurationMs": 909.759,
      "heapDeltaBytes": 2416952
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2045.6479999999715,
      "styleRecalcs": 183,
      "styleRecalcDurationMs": 59.669,
      "layouts": 12,
      "layoutDurationMs": 3.471,
      "taskDurationMs": 1112.265,
      "heapDeltaBytes": -4088208
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2027.5460000000294,
      "styleRecalcs": 183,
      "styleRecalcDurationMs": 66.68199999999999,
      "layouts": 12,
      "layoutDurationMs": 4.184,
      "taskDurationMs": 1095.882,
      "heapDeltaBytes": 3483984
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 631.4960000000269,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 18.703999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.47099999999995,
      "heapDeltaBytes": 13639628
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 595.1809999999682,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 15.154999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.1739999999999,
      "heapDeltaBytes": 13523648
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 622.9170000000295,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 15.978,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.606,
      "heapDeltaBytes": 13009964
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 649.1609999999923,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 18.674000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.35800000000006,
      "heapDeltaBytes": -4258816
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 639.1079999999647,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 18.037999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.077,
      "heapDeltaBytes": -4151040
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 644.9570000000335,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.842000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.54499999999996,
      "heapDeltaBytes": -2934112
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.4819999999959,
      "styleRecalcs": 121,
      "styleRecalcDurationMs": 31.035,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.994,
      "heapDeltaBytes": 2361932
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1999.21599999999,
      "styleRecalcs": 121,
      "styleRecalcDurationMs": 30.297000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.9359999999999,
      "heapDeltaBytes": 1576472
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.6170000000102,
      "styleRecalcs": 120,
      "styleRecalcDurationMs": 29.851000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.017,
      "heapDeltaBytes": 2356640
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1728.6149999999907,
      "styleRecalcs": 157,
      "styleRecalcDurationMs": 52.11600000000001,
      "layouts": 16,
      "layoutDurationMs": 4.572,
      "taskDurationMs": 825.9920000000001,
      "heapDeltaBytes": -6540564
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2001.1690000000044,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 63.887,
      "layouts": 16,
      "layoutDurationMs": 4.7299999999999995,
      "taskDurationMs": 1082.854,
      "heapDeltaBytes": 93200
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1762.6089999999976,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 55.782999999999994,
      "layouts": 16,
      "layoutDurationMs": 4.881999999999999,
      "taskDurationMs": 843.533,
      "heapDeltaBytes": -52176
    }
  ]
}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/lib/litegraph/src/LGraphCanvas.ts (1)

1071-1085: ⚠️ Potential issue | 🟠 Major

Replace type assertions with a dedicated direction mapping function and expose center-alignment actions in the context menus.

Both onNodeAlign and onGroupAlign use value.toLowerCase() as ArrangementDirection to convert menu labels to enum values. This violates the guideline for src/lib/litegraph/**/*.{ts,tsx} to avoid type assertions. The mapping is also fragile: Horizontal Center becomes horizontal center rather than horizontal-center. More critically, the menus only offer Top/Bottom/Left/Right, leaving horizontal-center and vertical-center unreachable despite being implemented in alignNodes.

Add the missing menu options and replace the assertion with an explicit mapping function:

Suggested direction
+function getArrangementDirection(
+  label: string
+): ArrangementDirection | undefined {
+  switch (label) {
+    case 'Top':
+      return 'top'
+    case 'Bottom':
+      return 'bottom'
+    case 'Left':
+      return 'left'
+    case 'Right':
+      return 'right'
+    case 'Horizontal Center':
+      return 'horizontal-center'
+    case 'Vertical Center':
+      return 'vertical-center'
+    default:
+      return undefined
+  }
+}

-    new LiteGraph.ContextMenu(['Top', 'Bottom', 'Left', 'Right'], {
+    new LiteGraph.ContextMenu(
+      [
+        'Top',
+        'Bottom',
+        'Left',
+        'Right',
+        'Horizontal Center',
+        'Vertical Center'
+      ],
+      {
         event,
         callback: inner_clicked,
         parentMenu: prev_menu
-    })
+      }
+    )

     function inner_clicked(value: string) {
+      const direction = getArrangementDirection(value)
+      if (!direction) return
       const newPositions = alignNodes(
         Object.values(LGraphCanvas.active_canvas.selected_nodes),
-        value.toLowerCase() as ArrangementDirection,
+        direction,
         node
       )

Apply the same mapping in onGroupAlign.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/lib/litegraph/src/LGraphCanvas.ts` around lines 1071 - 1085, The context
menu currently constructs labels ['Top','Bottom','Left','Right'] and casts
value.toLowerCase() as ArrangementDirection in inner_clicked; instead add the
missing center options (e.g., 'Horizontal Center' and 'Vertical Center') to the
ContextMenu labels and replace the type assertion with a small explicit mapping
function (e.g., mapLabelToArrangementDirection) that converts menu label strings
('Top','Bottom','Left','Right','Horizontal Center','Vertical Center') into the
correct ArrangementDirection values used by alignNodes; update inner_clicked
(and do the same in onGroupAlign) to call mapLabelToArrangementDirection(value)
and pass that result to alignNodes before calling
LGraphCanvas.active_canvas.repositionNodesVueMode(newPositions) and setDirty.
🧹 Nitpick comments (4)
src/components/rightSidePanel/settings/TabGlobalSettings.vue (1)

169-173: Disable or hide this switch when Nodes 2.0 is off.

This toggle only affects Vue-node dragging, so when nodes2Enabled is false the quick setting is effectively a no-op. Disabling it here would make the dependency clear and avoid a confusing control state.

♻️ Possible tweak
         <FieldSwitch
           v-model="alignNodesWhileDragging"
           :label="t('rightSidePanel.globalSettings.alignNodesWhileDragging')"
           :tooltip="t('settings.Comfy_Canvas_AlignNodesWhileDragging.tooltip')"
+          :disabled="!nodes2Enabled"
         />
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/rightSidePanel/settings/TabGlobalSettings.vue` around lines
169 - 173, The FieldSwitch controlling alignNodesWhileDragging should be
disabled or hidden when nodes2Enabled is false because it has no effect without
Nodes 2.0; update the template around the FieldSwitch (symbol: FieldSwitch,
model: alignNodesWhileDragging) to either add a reactive
:disabled="!nodes2Enabled" binding and an explanatory tooltip or wrap it with
v-if="nodes2Enabled" (or show a disabled state with a secondary tooltip
referencing nodes2Enabled) so the control is not actionable when nodes2Enabled
is off.
src/composables/graph/useMoreOptionsMenu.test.ts (1)

65-71: Make the mocked alignment options depend on selectedNodeCount.

getAlignmentOptions now takes selectedNodeCount, but this mock ignores the argument and always returns the align option. That means this test still passes even if useMoreOptionsMenu() stops forwarding the count or always forwards the wrong value.

🧪 Tighten the mock
 vi.mock('@/composables/graph/useSelectionMenuOptions', () => ({
   useSelectionMenuOptions: () => ({
     getBasicSelectionOptions: () => [{ label: 'Rename' }],
     getMultipleNodesOptions: () => [{ label: 'Frame Nodes' }],
     getSubgraphOptions: () => [],
-    getAlignmentOptions: () => [{ label: 'Align Selected To' }]
+    getAlignmentOptions: (selectedNodeCount: number) => {
+      const options = []
+
+      if (selectedNodeCount >= 2) {
+        options.push({ label: 'Align Selected To' })
+      }
+      if (selectedNodeCount >= 3) {
+        options.push({ label: 'Distribute Nodes' })
+      }
+
+      return options
+    }
   })
 }))

As per coding guidelines: "Do not write tests that just test the mocks; ensure tests fail when code behaves unexpectedly."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/composables/graph/useMoreOptionsMenu.test.ts` around lines 65 - 71, The
mock for useSelectionMenuOptions ignores the selectedNodeCount so tests won't
catch mis-forwarding; update the vi.mock to make getAlignmentOptions accept a
selectedNodeCount parameter and return the alignment option only when the count
indicates multiple nodes (e.g., selectedNodeCount > 1 or >= 2) and return []
otherwise, so useMoreOptionsMenu() must forward the correct count to pass the
test.
src/composables/graph/useSelectionMenuOptions.test.ts (1)

85-104: Add the below-threshold boundary case.

The new branching here is >= 2 / >= 3, but these tests only cover the enabled states. An explicit getAlignmentOptions(0) or getAlignmentOptions(1) assertion would lock down the case that should return no alignment actions.

🧪 Suggested follow-up test
+  it('returns no alignment options for fewer than two selected nodes', () => {
+    const { getAlignmentOptions } = useSelectionMenuOptions()
+
+    expect(getAlignmentOptions(0)).toEqual([])
+    expect(getAlignmentOptions(1)).toEqual([])
+  })
+
   it('returns align options for two selected nodes', () => {
     const { getAlignmentOptions } = useSelectionMenuOptions()
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/composables/graph/useSelectionMenuOptions.test.ts` around lines 85 - 104,
Add a boundary test that asserts getAlignmentOptions returns no alignment
actions for below-threshold selections: call getAlignmentOptions(0) and
getAlignmentOptions(1) and expect options.map(option => option.label) to be an
empty array (or otherwise assert no alignment/distribute labels). Place these
assertions alongside the existing tests for two and three selected nodes (same
test suite using useSelectionMenuOptions and the getAlignmentOptions helper) to
lock down the >=2 / >=3 branching.
src/composables/graph/contextMenuConverter.ts (1)

48-49: Duplicate entries in CORE_MENU_ITEMS Set.

'Align Selected To' and 'Distribute Nodes' appear twice in the Set—once in the "Structure operations" section (lines 48-49) and again in the "Selection and alignment" section (lines 75-76). While Sets deduplicate automatically so this is not a bug, the redundancy is confusing.

Consider keeping them in only one location for clarity.

Also applies to: 75-76

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/composables/graph/contextMenuConverter.ts` around lines 48 - 49,
CORE_MENU_ITEMS contains duplicate string entries ('Align Selected To' and
'Distribute Nodes') across the "Structure operations" and "Selection and
alignment" sections; remove the duplicates so each label appears only once in
the Set (e.g., keep them in the more semantically appropriate "Selection and
alignment" section) by deleting the redundant entries from the other section
while leaving the Set declaration and order otherwise unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/renderer/core/layout/store/layoutStore.ts`:
- Around line 141-142: When reinitializing the layout store in
initializeFromLiteGraph(), also reset the singleton's Vue drag guide state by
clearing vueDragSnapGuides and resetting isDraggingVueNodes so stale guides
aren't rendered; update initializeFromLiteGraph() to set vueDragSnapGuides.value
= [] (and isDraggingVueNodes.value = false if appropriate) so
_drawVueDragAlignmentGuides() has no leftover data to render after a workflow
reload or mode switch.

In `@src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts`:
- Around line 103-106: The test's layoutStore mock is missing vueDragSnapGuides
which causes cleanupDragState() (in useNodePointerInteractions.cleanupDragState)
to assign to undefined; update the mock object used in the tests to include
vueDragSnapGuides: ref([]) (and import/ref from 'vue' in the test if not already
present) so layoutStore.vueDragSnapGuides.value can be safely assigned during
drag end/cancel/unmount flows.

In `@src/renderer/extensions/vueNodes/layout/useNodeDrag.ts`:
- Around line 67-70: Prepare draggedSelectionBounds as before but only compute
alignmentCandidateBounds when the opt-in setting
Comfy.Canvas.AlignNodesWhileDragging is enabled: keep creating selectedNodes
(from toValue(selectedNodeIds) and nodeId) and call
getDraggedSelectionBounds(selectedNodes) unconditionally, but wrap the call to
getAlignmentCandidateBounds(selectedNodes) (and assignment to
alignmentCandidateBounds) in an if-check that reads the
Comfy.Canvas.AlignNodesWhileDragging setting so you avoid walking the node map
when alignment is disabled; apply the same conditional guard around the
analogous calls found later in the file (the other block noted in the review).
- Around line 67-75: The code currently mutates selectedNodes by calling
selectedNodes.add(nodeId) before checking membership, so
isDraggedNodeInSelection is always true; fix by determining whether the dragged
node is in the original selection first (compute isDraggedNodeInSelection =
toValue(selectedNodeIds).has(nodeId) or check membership against a Set created
from toValue(selectedNodeIds)), then add nodeId to selectedNodes and call
getDraggedSelectionBounds, getAlignmentCandidateBounds, updateDragSnapGuides;
apply the same change to the other similar blocks referenced around the
isDraggedNodeInSelection usage (the blocks around lines 77-83 and 95-100) to
preserve original selection membership before mutation.

---

Outside diff comments:
In `@src/lib/litegraph/src/LGraphCanvas.ts`:
- Around line 1071-1085: The context menu currently constructs labels
['Top','Bottom','Left','Right'] and casts value.toLowerCase() as
ArrangementDirection in inner_clicked; instead add the missing center options
(e.g., 'Horizontal Center' and 'Vertical Center') to the ContextMenu labels and
replace the type assertion with a small explicit mapping function (e.g.,
mapLabelToArrangementDirection) that converts menu label strings
('Top','Bottom','Left','Right','Horizontal Center','Vertical Center') into the
correct ArrangementDirection values used by alignNodes; update inner_clicked
(and do the same in onGroupAlign) to call mapLabelToArrangementDirection(value)
and pass that result to alignNodes before calling
LGraphCanvas.active_canvas.repositionNodesVueMode(newPositions) and setDirty.

---

Nitpick comments:
In `@src/components/rightSidePanel/settings/TabGlobalSettings.vue`:
- Around line 169-173: The FieldSwitch controlling alignNodesWhileDragging
should be disabled or hidden when nodes2Enabled is false because it has no
effect without Nodes 2.0; update the template around the FieldSwitch (symbol:
FieldSwitch, model: alignNodesWhileDragging) to either add a reactive
:disabled="!nodes2Enabled" binding and an explanatory tooltip or wrap it with
v-if="nodes2Enabled" (or show a disabled state with a secondary tooltip
referencing nodes2Enabled) so the control is not actionable when nodes2Enabled
is off.

In `@src/composables/graph/contextMenuConverter.ts`:
- Around line 48-49: CORE_MENU_ITEMS contains duplicate string entries ('Align
Selected To' and 'Distribute Nodes') across the "Structure operations" and
"Selection and alignment" sections; remove the duplicates so each label appears
only once in the Set (e.g., keep them in the more semantically appropriate
"Selection and alignment" section) by deleting the redundant entries from the
other section while leaving the Set declaration and order otherwise unchanged.

In `@src/composables/graph/useMoreOptionsMenu.test.ts`:
- Around line 65-71: The mock for useSelectionMenuOptions ignores the
selectedNodeCount so tests won't catch mis-forwarding; update the vi.mock to
make getAlignmentOptions accept a selectedNodeCount parameter and return the
alignment option only when the count indicates multiple nodes (e.g.,
selectedNodeCount > 1 or >= 2) and return [] otherwise, so useMoreOptionsMenu()
must forward the correct count to pass the test.

In `@src/composables/graph/useSelectionMenuOptions.test.ts`:
- Around line 85-104: Add a boundary test that asserts getAlignmentOptions
returns no alignment actions for below-threshold selections: call
getAlignmentOptions(0) and getAlignmentOptions(1) and expect options.map(option
=> option.label) to be an empty array (or otherwise assert no
alignment/distribute labels). Place these assertions alongside the existing
tests for two and three selected nodes (same test suite using
useSelectionMenuOptions and the getAlignmentOptions helper) to lock down the >=2
/ >=3 branching.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e9a80bff-f2d9-4388-9d4c-5c60330bd8ac

📥 Commits

Reviewing files that changed from the base of the PR and between fd7ce3a and 023ff7f.

📒 Files selected for processing (24)
  • browser_tests/tests/vueNodes/interactions/node/alignment.spec.ts
  • src/components/graph/selectionToolbox/NodeOptionsButton.vue
  • src/components/rightSidePanel/settings/TabGlobalSettings.vue
  • src/composables/graph/contextMenuConverter.ts
  • src/composables/graph/useMoreOptionsMenu.test.ts
  • src/composables/graph/useMoreOptionsMenu.ts
  • src/composables/graph/useNodeArrangement.ts
  • src/composables/graph/useSelectionMenuOptions.test.ts
  • src/composables/graph/useSelectionMenuOptions.ts
  • src/lib/litegraph/src/LGraphCanvas.ts
  • src/lib/litegraph/src/interfaces.ts
  • src/lib/litegraph/src/utils/arrange.ts
  • src/locales/en/main.json
  • src/locales/en/settings.json
  • src/platform/settings/constants/coreSettings.ts
  • src/renderer/core/layout/store/layoutStore.ts
  • src/renderer/extensions/vueNodes/components/LGraphNode.vue
  • src/renderer/extensions/vueNodes/components/NodeWidgets.vue
  • src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts
  • src/renderer/extensions/vueNodes/layout/nodeAlignmentSnap.test.ts
  • src/renderer/extensions/vueNodes/layout/nodeAlignmentSnap.ts
  • src/renderer/extensions/vueNodes/layout/useNodeDrag.test.ts
  • src/renderer/extensions/vueNodes/layout/useNodeDrag.ts
  • src/schemas/apiSchema.ts

Comment on lines 141 to +142
public isDraggingVueNodes = ref(false)
public vueDragSnapGuides = ref<NodeAlignmentGuide[]>([])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clear drag guides when the layout store reinitializes.

vueDragSnapGuides is now part of the singleton canvas render state, but initializeFromLiteGraph() still only clears the older layout/render caches. If a workflow reload or mode switch interrupts a drag, _drawVueDragAlignmentGuides() can keep rendering stale guides from the previous graph until another cleanup path happens to run.

🩹 Proposed fix
   initializeFromLiteGraph(
     nodes: Array<{ id: string; pos: [number, number]; size: [number, number] }>
   ): void {
+    this.isDraggingVueNodes.value = false
+    this.vueDragSnapGuides.value = []
+
     this.ydoc.transact(() => {
       this.ynodes.clear()
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/renderer/core/layout/store/layoutStore.ts` around lines 141 - 142, When
reinitializing the layout store in initializeFromLiteGraph(), also reset the
singleton's Vue drag guide state by clearing vueDragSnapGuides and resetting
isDraggingVueNodes so stale guides aren't rendered; update
initializeFromLiteGraph() to set vueDragSnapGuides.value = [] (and
isDraggingVueNodes.value = false if appropriate) so
_drawVueDragAlignmentGuides() has no leftover data to render after a workflow
reload or mode switch.

Comment on lines 103 to 106
function cleanupDragState() {
layoutStore.isDraggingVueNodes.value = false
layoutStore.vueDragSnapGuides.value = []
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find the test file and check how layoutStore is mocked

# Find and display the layoutStore mock in the test file
rg -n -A 10 'layoutStore' src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 2895


🏁 Script executed:

#!/bin/bash
# Check the actual implementation of cleanupDragState in useNodePointerInteractions.ts
rg -n -B 2 -A 5 'cleanupDragState' src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 885


🏁 Script executed:

#!/bin/bash
# Check if vueDragSnapGuides is used elsewhere in the file
rg -n 'vueDragSnapGuides' src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 118


🏁 Script executed:

#!/bin/bash
# Check the complete layoutStore mock setup to confirm vueDragSnapGuides is not included
sed -n '93,107p' src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 487


🏁 Script executed:

#!/bin/bash
# Check if layoutStore is mocked anywhere else with vueDragSnapGuides
rg 'vueDragSnapGuides' src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


Add vueDragSnapGuides to the layoutStore mock in the test file.

The cleanupDragState() function at line 105 sets layoutStore.vueDragSnapGuides.value = [], but the test mock at lines 93-107 does not include this property. Existing tests that trigger drag end, cancel, or unmount will fail because they attempt to set a property on undefined. Update the mock to include vueDragSnapGuides: ref([]).

🧰 Tools
🪛 GitHub Actions: CI: Tests Unit

[error] 105-105: Cannot set properties of undefined (setting 'value') in cleanupDragState.

🪛 GitHub Check: test

[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > on ctrl+click: calls toggleNodeSelectionAfterPointerUp on pointer up (not pointer down)
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointerup src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:139:7
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:319:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should select node immediately when drag starts
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointerup src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:139:7
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:290:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should select node immediately when drag starts
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointerup src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:139:7
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:290:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should select node immediately when drag starts
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointerup src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:139:7
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:290:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should integrate with layout store dragging state
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointercancel src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:159:5
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:255:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should integrate with layout store dragging state
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointercancel src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:159:5
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:255:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should integrate with layout store dragging state
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointercancel src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:159:5
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:255:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should handle drag termination via cancel and context menu
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointercancel src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:159:5
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:206:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should handle drag termination via cancel and context menu
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointercancel src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:159:5
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:206:21


[failure] 105-105: src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts > useNodePointerInteractions > should handle drag termination via cancel and context menu
TypeError: Cannot set properties of undefined (setting 'value')
❯ cleanupDragState src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:105:35
❯ safeDragEnd src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:124:7
❯ Object.onPointercancel src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts:159:5
❯ src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.ts:206:21

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/renderer/extensions/vueNodes/composables/useNodePointerInteractions.ts`
around lines 103 - 106, The test's layoutStore mock is missing vueDragSnapGuides
which causes cleanupDragState() (in useNodePointerInteractions.cleanupDragState)
to assign to undefined; update the mock object used in the tests to include
vueDragSnapGuides: ref([]) (and import/ref from 'vue' in the test if not already
present) so layoutStore.vueDragSnapGuides.value can be safely assigned during
drag end/cancel/unmount flows.

Comment on lines +67 to +70
const selectedNodes = new Set(toValue(selectedNodeIds))
selectedNodes.add(nodeId)
draggedSelectionBounds = getDraggedSelectionBounds(selectedNodes)
alignmentCandidateBounds = getAlignmentCandidateBounds(selectedNodes)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Keep the opt-in alignment setup behind the opt-in setting.

These bounds are prepared on every drag start, even when
Comfy.Canvas.AlignNodesWhileDragging is off. Since
getAlignmentCandidateBounds() walks the whole node map and the setting
defaults to false, the default drag path now pays the full alignment setup
cost on every drag.

Suggested fix
-    draggedSelectionBounds = getDraggedSelectionBounds(selectedNodes)
-    alignmentCandidateBounds = getAlignmentCandidateBounds(selectedNodes)
+    if (settingStore.get('Comfy.Canvas.AlignNodesWhileDragging')) {
+      draggedSelectionBounds = getDraggedSelectionBounds(selectedNodes)
+      alignmentCandidateBounds = getAlignmentCandidateBounds(selectedNodes)
+    } else {
+      draggedSelectionBounds = null
+      alignmentCandidateBounds = []
+    }
     updateDragSnapGuides([])

Also applies to: 304-315

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/renderer/extensions/vueNodes/layout/useNodeDrag.ts` around lines 67 - 70,
Prepare draggedSelectionBounds as before but only compute
alignmentCandidateBounds when the opt-in setting
Comfy.Canvas.AlignNodesWhileDragging is enabled: keep creating selectedNodes
(from toValue(selectedNodeIds) and nodeId) and call
getDraggedSelectionBounds(selectedNodes) unconditionally, but wrap the call to
getAlignmentCandidateBounds(selectedNodes) (and assignment to
alignmentCandidateBounds) in an if-check that reads the
Comfy.Canvas.AlignNodesWhileDragging setting so you avoid walking the node map
when alignment is disabled; apply the same conditional guard around the
analogous calls found later in the file (the other block noted in the review).

Comment on lines +67 to +75
const selectedNodes = new Set(toValue(selectedNodeIds))
selectedNodes.add(nodeId)
draggedSelectionBounds = getDraggedSelectionBounds(selectedNodes)
alignmentCandidateBounds = getAlignmentCandidateBounds(selectedNodes)
updateDragSnapGuides([])

// capture the starting positions of all other selected nodes
// Only move other selected items if the dragged node is part of the selection
const isDraggedNodeInSelection = selectedNodes?.has(nodeId)
const isDraggedNodeInSelection = selectedNodes.has(nodeId)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Preserve the original selection membership before adding the dragged node.

selectedNodes.add(nodeId) makes the later membership check always true, so the
“dragging an unrelated node” case never survives. That can pull the previously
selected nodes/groups into the drag path and also removes them from the
alignment-candidate set.

Suggested fix
-    const selectedNodes = new Set(toValue(selectedNodeIds))
-    selectedNodes.add(nodeId)
-    draggedSelectionBounds = getDraggedSelectionBounds(selectedNodes)
-    alignmentCandidateBounds = getAlignmentCandidateBounds(selectedNodes)
+    const selectedNodes = new Set(toValue(selectedNodeIds))
+    const isDraggedNodeInSelection = selectedNodes.has(nodeId)
+    const draggedNodeIds = isDraggedNodeInSelection
+      ? selectedNodes
+      : new Set<NodeId>([nodeId])
+
+    draggedSelectionBounds = getDraggedSelectionBounds(draggedNodeIds)
+    alignmentCandidateBounds = getAlignmentCandidateBounds(draggedNodeIds)
     updateDragSnapGuides([])
 
-    const isDraggedNodeInSelection = selectedNodes.has(nodeId)
-
-    if (isDraggedNodeInSelection && selectedNodes.size > 1) {
+    if (isDraggedNodeInSelection && draggedNodeIds.size > 1) {
       otherSelectedNodesStartPositions = new Map()
 
-      for (const id of selectedNodes) {
+      for (const id of draggedNodeIds) {
         // Skip the current node being dragged
         if (id === nodeId) continue

Also applies to: 77-83, 95-100

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/renderer/extensions/vueNodes/layout/useNodeDrag.ts` around lines 67 - 75,
The code currently mutates selectedNodes by calling selectedNodes.add(nodeId)
before checking membership, so isDraggedNodeInSelection is always true; fix by
determining whether the dragged node is in the original selection first (compute
isDraggedNodeInSelection = toValue(selectedNodeIds).has(nodeId) or check
membership against a Set created from toValue(selectedNodeIds)), then add nodeId
to selectedNodes and call getDraggedSelectionBounds,
getAlignmentCandidateBounds, updateDragSnapGuides; apply the same change to the
other similar blocks referenced around the isDraggedNodeInSelection usage (the
blocks around lines 77-83 and 95-100) to preserve original selection membership
before mutation.

@benceruleanlu

Copy link
Copy Markdown
Member Author

Replaced by #9894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant