Repository navigation
feat: add slot context menu with rename for Vue nodes - #9045
christian-byrne wants to merge 18 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a slot-specific context menu for VueNodes: new SlotContextMenu component, a composable to manage showing/renaming slots, slot components wired to open the menu on right-click, unit and E2E tests, and GraphCanvas integration to render the menu. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SlotDot as Slot Connection Dot
participant Composable as useSlotContextMenu
participant SlotMenu as SlotContextMenu
participant Graph as App Canvas/Graph
User->>SlotDot: right-click
SlotDot->>Composable: showSlotMenu(event, {nodeId, slotIndex, isInput})
Composable->>SlotMenu: delegate show(event, context)
SlotMenu->>SlotMenu: compute worldPosition & start RAF sync
SlotMenu-->>User: render menu at computed screen coords
alt User selects "Rename"
User->>SlotMenu: click Rename
SlotMenu->>Composable: renameSlot(context, newLabel)
Composable->>Graph: graph.beforeChange()
Composable->>Graph: update slot label
Composable->>Graph: graph.afterChange()
Composable->>Graph: canvas.setDirty()
SlotMenu-->>User: close menu
else User selects "Disconnect"
User->>SlotMenu: click Disconnect
SlotMenu->>Graph: remove link(s) for slot
SlotMenu-->>User: close menu
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/renderer/extensions/vueNodes/components/SlotContextMenu.vue`:
- Around line 90-114: Wrap the dialogService.prompt call in handleRename with a
try/catch so any rejection is caught; inside catch call the app's standard error
reporting (e.g., the global error handler or a user-facing toast) and return
early so menu state is consistent. Concretely, update the async function
handleRename(ctx: SlotMenuContext) to try { const newLabel = await
dialogService.prompt({...}) } catch (err) { /* route err to standard error
handler/toast */ return } and then proceed to check for null and call
renameSlot(ctx, newLabel).
In `@src/renderer/extensions/vueNodes/composables/useSlotContextMenu.test.ts`:
- Around line 95-156: Replace the string literal suite name with the actual
function reference so the suite is tied to the unit under test: change
describe('renameSlot', ...) to describe(renameSlot, ...) and ensure the
renameSlot symbol is imported/available in this test file (update imports if
necessary) so Vitest’s prefer-describe-function-title rule is satisfied.
In `@src/renderer/extensions/vueNodes/composables/useSlotContextMenu.ts`:
- Around line 33-49: The public function renameSlot must enforce the same
protections as canRenameSlot to prevent renaming locked or widget slots; modify
renameSlot (taking SlotMenuContext) to perform the same guard checks as
canRenameSlot (or call canRenameSlot(context) and bail if false) before mutating
slotInfo.label, so it returns early when nameLocked or widget/other constraints
apply and only proceeds to call graph.beforeChange(), setDirty, and
graph.afterChange() when allowed.
jaeone94
left a comment
There was a problem hiding this comment.
I added a few comments.
Addresses review feedback: #9045 (comment) #9045 (comment)
Addresses review feedback: #9045 (comment)
Addresses review feedback: #9045 (comment)
christian-byrne
left a comment
There was a problem hiding this comment.
The business logic (canRenameSlot, renameSlot) is solid and well-tested. The main issue is that SlotContextMenu.vue duplicates ~80 lines of canvas-position-synced context menu infrastructure from NodeContextMenu.vue and introduces a new PrimeVue usage.
Suggested alternative approach:
- Extract a
useCanvasMenuPositionSynccomposable from NodeContextMenu.vue (this also improves NodeContextMenu) - Either extend NodeContextMenu to accept pluggable item sources (slot rename is just one menu item), or build SlotContextMenu on Reka UI's ContextMenu instead of PrimeVue
- Wire the menu instance via
provide/injectat the GraphCanvas level instead of a module-level singleton - Keep
canRenameSlot/renameSlotas-is -- they're clean
Addresses review feedback: #9045 (comment) #9045 (comment)
Addresses review feedback: #9045 (comment)
Addresses review feedback: #9045 (comment)
b924aba to
349e708
Compare
📦 Bundle: 5.26 MB gzip 🔴 +1.62 kBDetailsSummary
Category Glance App Entry Points — 22.6 kB (baseline 22.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🔴 +4.23 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 81.8 kB (baseline 81.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.5 kB (baseline 17.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.05 MB (baseline 3.05 MB) • 🔴 +4.27 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 365 kB (baseline 365 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 15 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.84 MB (baseline 8.84 MB) • 🔴 +72 BBundles that do not match a named category
Status: 62 added / 62 removed / 73 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-04T07:36:26.133Z",
"gitSha": "f3fa5020928caa431e3aaf5d95b365403e93a148",
"branch": "feat/slot-context-menu-rename",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.1929999998592,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.925,
"heapDeltaBytes": -5876056,
"heapUsedBytes": 42737768,
"domNodes": 16,
"jsHeapTotalBytes": 15069184,
"scriptDurationMs": 14.885000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2042.854000000034,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9289999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.3690000000001,
"heapDeltaBytes": 22755624,
"heapUsedBytes": 71100396,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 18.769,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2030.3090000002157,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.89899999999994,
"heapDeltaBytes": 23716096,
"heapUsedBytes": 72016012,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 14.869999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1888.3640000001378,
"styleRecalcs": 72,
"styleRecalcDurationMs": 40.828,
"layouts": 12,
"layoutDurationMs": 3.95,
"taskDurationMs": 847.9509999999999,
"heapDeltaBytes": 4865888,
"heapUsedBytes": 53502688,
"domNodes": -263,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 119.24000000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1881.744000000026,
"styleRecalcs": 73,
"styleRecalcDurationMs": 40.908,
"layouts": 12,
"layoutDurationMs": 3.899,
"taskDurationMs": 859.504,
"heapDeltaBytes": 5639952,
"heapUsedBytes": 54234000,
"domNodes": -264,
"jsHeapTotalBytes": 16117760,
"scriptDurationMs": 127.98599999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.6929999999047,
"styleRecalcs": 73,
"styleRecalcDurationMs": 33.332,
"layouts": 12,
"layoutDurationMs": 3.4209999999999994,
"taskDurationMs": 722.569,
"heapDeltaBytes": 18319648,
"heapUsedBytes": 67369864,
"domNodes": 56,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 117.90100000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.6289999999553,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.441,
"layouts": 6,
"layoutDurationMs": 0.6929999999999998,
"taskDurationMs": 296.80600000000004,
"heapDeltaBytes": 324832,
"heapUsedBytes": 47923252,
"domNodes": 80,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 25.866999999999994,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.3409999998767,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.689000000000004,
"layouts": 6,
"layoutDurationMs": 0.6940000000000002,
"taskDurationMs": 291.323,
"heapDeltaBytes": 5431008,
"heapUsedBytes": 71319840,
"domNodes": 78,
"jsHeapTotalBytes": 19755008,
"scriptDurationMs": 17.100000000000005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.699999999837,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.509999999999998,
"layouts": 6,
"layoutDurationMs": 0.7819999999999999,
"taskDurationMs": 297.488,
"heapDeltaBytes": 85956,
"heapUsedBytes": 48827728,
"domNodes": 77,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 19.391,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 615.8069999999043,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.696000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.75399999999996,
"heapDeltaBytes": 9405044,
"heapUsedBytes": 57932956,
"domNodes": 16,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 61.225,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 540.0589999999283,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.217000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.85200000000003,
"heapDeltaBytes": 9110104,
"heapUsedBytes": 57520132,
"domNodes": 16,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 58.354000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 539.3530000001192,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.398999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.49399999999997,
"heapDeltaBytes": 8526300,
"heapUsedBytes": 57109244,
"domNodes": 18,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 54.342000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2040.6390000000556,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9030000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.695,
"heapDeltaBytes": 7375840,
"heapUsedBytes": 65927740,
"domNodes": -263,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 100.238,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.4749999998403,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.59,
"heapDeltaBytes": 6785072,
"heapUsedBytes": 63940080,
"domNodes": -261,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 117.155,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.693999999883,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.697,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.227,
"heapDeltaBytes": 3188620,
"heapUsedBytes": 61641844,
"domNodes": -262,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 81.059,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2153.4479999997984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 18.402999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1136.1509999999998,
"heapDeltaBytes": 1283004,
"heapUsedBytes": 61102948,
"domNodes": -269,
"jsHeapTotalBytes": 2068480,
"scriptDurationMs": 439.543,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2130.30700000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 19.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1119.458,
"heapDeltaBytes": -5388792,
"heapUsedBytes": 53871944,
"domNodes": -265,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 383.223,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2126.0550000001786,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1122.262,
"heapDeltaBytes": 9316600,
"heapUsedBytes": 68811168,
"domNodes": -255,
"jsHeapTotalBytes": 1544192,
"scriptDurationMs": 418.86699999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3198.914000000059,
"styleRecalcs": 63,
"styleRecalcDurationMs": 18.455,
"layouts": 60,
"layoutDurationMs": 8.796999999999999,
"taskDurationMs": 1379.5570000000002,
"heapDeltaBytes": 11608140,
"heapUsedBytes": 72464384,
"domNodes": -272,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 505.536,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3135.0059999999758,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.39,
"layouts": 60,
"layoutDurationMs": 8.318,
"taskDurationMs": 1343.2419999999997,
"heapDeltaBytes": 7139812,
"heapUsedBytes": 67630788,
"domNodes": -270,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 506.63899999999995,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3150.408999999854,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.226000000000003,
"layouts": 60,
"layoutDurationMs": 8.16,
"taskDurationMs": 1316.9409999999998,
"heapDeltaBytes": 8680096,
"heapUsedBytes": 69604516,
"domNodes": -270,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 486.8229999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.796000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.657999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.0020000000001,
"heapDeltaBytes": 13855732,
"heapUsedBytes": 74166016,
"domNodes": -264,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 77.58899999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2017.0760000000882,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.493000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.076,
"heapDeltaBytes": 5852996,
"heapUsedBytes": 66839800,
"domNodes": -268,
"jsHeapTotalBytes": 3756032,
"scriptDurationMs": 80.219,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2044.608000000153,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.605,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.592,
"heapDeltaBytes": 13190964,
"heapUsedBytes": 73600676,
"domNodes": -267,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 95.13,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.0399999998681,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.673,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.605,
"heapDeltaBytes": 9471584,
"heapUsedBytes": 57734988,
"domNodes": 20,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 122.30000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.2530000002116,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.185,
"heapDeltaBytes": 9424228,
"heapUsedBytes": 57900216,
"domNodes": 16,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 132.316,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.2369999997354,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.792,
"heapDeltaBytes": 9140500,
"heapUsedBytes": 57760432,
"domNodes": 18,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 123.64100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2011.788999999908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.234999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.675,
"heapDeltaBytes": 22395232,
"heapUsedBytes": 70476848,
"domNodes": 20,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 18.593000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2032.7859999999873,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.027000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.93100000000004,
"heapDeltaBytes": -5201472,
"heapUsedBytes": 42974860,
"domNodes": 18,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 21.306000000000004,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.2260000003917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.029,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.90900000000005,
"heapDeltaBytes": 22606752,
"heapUsedBytes": 71212440,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 14.526000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1684.6279999999751,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.961,
"layouts": 16,
"layoutDurationMs": 4.935999999999999,
"taskDurationMs": 678.3520000000001,
"heapDeltaBytes": 14059336,
"heapUsedBytes": 62679992,
"domNodes": 59,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 96.151,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.072999999924,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.416999999999994,
"layouts": 16,
"layoutDurationMs": 4.721,
"taskDurationMs": 700.912,
"heapDeltaBytes": 14208220,
"heapUsedBytes": 62997796,
"domNodes": 61,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 96.477,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.612999999601,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.779,
"layouts": 16,
"layoutDurationMs": 4.856999999999999,
"taskDurationMs": 639.405,
"heapDeltaBytes": 14728888,
"heapUsedBytes": 63421656,
"domNodes": 62,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 86.56,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8235.707000000048,
"styleRecalcs": 250,
"styleRecalcDurationMs": 59.47100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3896.9719999999998,
"heapDeltaBytes": 13055940,
"heapUsedBytes": 71219104,
"domNodes": -261,
"jsHeapTotalBytes": 7049216,
"scriptDurationMs": 1249.339,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.639999999818,
"styleRecalcs": 248,
"styleRecalcDurationMs": 53.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3609.7140000000004,
"heapDeltaBytes": 14368448,
"heapUsedBytes": 74272352,
"domNodes": -263,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 1182.652,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8187.651000000187,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3698.7509999999997,
"heapDeltaBytes": 10008200,
"heapUsedBytes": 68250740,
"domNodes": -265,
"jsHeapTotalBytes": 2592768,
"scriptDurationMs": 1189.0430000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13185.584000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13151.096,
"heapDeltaBytes": -38197968,
"heapUsedBytes": 172550176,
"domNodes": -8331,
"jsHeapTotalBytes": 24440832,
"scriptDurationMs": 620.498,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12658.488000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12648.304,
"heapDeltaBytes": -34449388,
"heapUsedBytes": 171956232,
"domNodes": -8331,
"jsHeapTotalBytes": 24440832,
"scriptDurationMs": 596.774,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13128.850000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13114.399000000003,
"heapDeltaBytes": -36855664,
"heapUsedBytes": 172953544,
"domNodes": -8331,
"jsHeapTotalBytes": 23588864,
"scriptDurationMs": 576.054,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15353.596000000152,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.004000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15332.982000000002,
"heapDeltaBytes": -43463584,
"heapUsedBytes": 154444348,
"domNodes": -8329,
"jsHeapTotalBytes": -3608576,
"scriptDurationMs": 927.596,
"eventListeners": -16490,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15023.749999999836,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.87700000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15004.369,
"heapDeltaBytes": -37543264,
"heapUsedBytes": 166945536,
"domNodes": -8329,
"jsHeapTotalBytes": -6905856,
"scriptDurationMs": 917.5149999999999,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15600.484000000051,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.489000000000036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15580.308000000003,
"heapDeltaBytes": -42024448,
"heapUsedBytes": 178742740,
"domNodes": -8331,
"jsHeapTotalBytes": -13393920,
"scriptDurationMs": 889.3040000000001,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 148.82799999986673,
"styleRecalcs": 11,
"styleRecalcDurationMs": 22.423000000000002,
"layouts": 8,
"layoutDurationMs": 2.298,
"taskDurationMs": 115.25300000000003,
"heapDeltaBytes": 3449388,
"heapUsedBytes": 53392680,
"domNodes": 155,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 24.848999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 458.3259999999427,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.647,
"layouts": 5,
"layoutDurationMs": 1.4140000000000001,
"taskDurationMs": 114.13499999999999,
"heapDeltaBytes": 5015276,
"heapUsedBytes": 55148256,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.746000000000002,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 468.8089999999647,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.467999999999996,
"layouts": 5,
"layoutDurationMs": 1.441,
"taskDurationMs": 125.76199999999999,
"heapDeltaBytes": 5179580,
"heapUsedBytes": 54973224,
"domNodes": 157,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.619,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 11:54:55 AM UTC Links
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance
🔬 E2E Coverage
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #9045 +/- ##
===========================================
- Coverage 71.86% 56.07% -15.79%
===========================================
Files 1492 1386 -106
Lines 86853 70966 -15887
Branches 24383 19775 -4608
===========================================
- Hits 62414 39797 -22617
- Misses 23544 30637 +7093
+ Partials 895 532 -363
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 987 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Add right-click context menu on slot connection dots in Vue nodes (Nodes 2.0) with a 'Rename slot' option, matching litegraph parity. - Slot rename respects nameLocked and widget-input filtering - Uses dialogService.prompt() for rename input - Menu position tracks canvas pan/zoom via RAF sync Amp-Thread-ID: https://ampcode.com/threads/T-019c7db2-dbb3-7090-ba79-856d7f630a42
Addresses review feedback: #9045 (comment) #9045 (comment)
Addresses review feedback: #9045 (comment)
Addresses review feedback: #9045 (comment)
Tests for all slot context menu actions: - canRenameSlot, canDisconnectSlot, canRemoveSlot, hasAnySlotAction - renameSlot, disconnectSlotLinks, removeSlot - Guard conditions, happy paths, and slot refresh triggers - 35 tests covering full LiteGraph slot menu parity
- Drop PrimeVue ContextMenu, use custom teleported imperative menu - Add Disconnect Links and Remove Slot actions (LiteGraph parity) - Extract useCanvasAnchoredPosition composable from NodeContextMenu - Fix slot label reactivity: add node:slot-label:changed graph event that triggers refreshNodeSlots to update both inputs and outputs - Refresh shallowReactive inputs via splice for property changes - Refresh outputs via spread copy for label changes - Use hasAnySlotAction guard instead of canRenameSlot in slot components - Add i18n keys: disconnectLinks, removeSlot
- Fix reactivity: renameSlot now splice-replaces the slot element in the
shallowReactive array instead of mutating a deep property (label) that
shallowReactive doesn't track. The previous approach of spreading the
same object references back via refreshNodeSlots was a no-op.
- Fix refreshNodeSlots: shallow-copy each element via map(o => ({...o}))
so shallowReactive detects new references for deep property changes.
- Align SlotContextMenu styling to design system: use same classes as
DropdownMenu.vue (z-1700, min-w-[220px], hover:bg-secondary-background-hover).
- Consolidate duplicate NodeSlotLabelChangedEvent interface in graphTriggers.ts.
Root cause: refreshNodeSlots replaced currentData.outputs with a new array via assignment, severing the reference from the shallowReactive backing array that Vue components track. After any slot-links or slot-errors event, nodeData.outputs in the template pointed to a detached copy while renameSlot mutated node.outputs (the original). Fix: use splice instead of assignment for outputs (matching inputs), so the array identity is preserved. renameSlot delegates reactivity entirely to the trigger event + refreshNodeSlots, which now correctly splice-replaces elements with shallow copies.
…e e2e test - Add Object.defineProperty instrumentation on slot.label so setting it fires node:slot-label:changed trigger automatically - Hook onInputAdded/onOutputAdded to instrument dynamically added slots - Remove manual triggerSlotRefresh from renameSlot (setter handles it) - Add Playwright e2e test verifying rename slot reactively updates DOM - Simplify renameSlot to use getSlotInfo helper directly
canvasLeft, canvasTop, and lgCanvas are internal implementation details. Neither SlotContextMenu nor NodeContextMenu uses them. Addresses review feedback: #9045 (comment)
Not a composable — returns no reactive state and has no lifecycle integration. Addresses review feedback: #9045 (comment)
- Remove duplicate Escape handler (window listener already handles it) - Add tabindex="0" to menu items for ARIA keyboard navigation - Handle prompt dialog rejection to prevent unhandled promise errors Addresses review feedback: #9045 (comment) #9045 (comment) #9045 (comment)
Colocate with NodeContextMenu since both are siblings in the GraphCanvas template tree. Addresses review feedback: #9045 (comment)
- Replace coordinate-based right-clicks with .slot-dot locators - Use node ID from evaluate to locate Vue node for disconnect test instead of re-querying by title Addresses review feedback: #9045 (comment) #9045 (comment)
- Replace .not.toBeVisible() with .toBeHidden() (playwright/no-useless-not) - Use @e2e/ alias instead of relative import (no-restricted-imports)
|
Rebased Conflicts resolved during rebase:
Also removed a now-dangling Evidence
Follow-up: the slot-label reactivity gap ( |
|
Filed the reactivity gap noted above as #16642. |
|
Checked mergeability for No rebase/resolution action needed; closing out the conflict-lane row as verified-clean rather than forcing a no-op push. |
|
Accounting corrected: 23/23 hunks. Full context for agent readersThis supersession receipt now accounts for every hunk in closed source head
Material intentionally excluded by the survivor choice: six browser tests; all 34 source unit tests, including 12 rename tests; Disconnect Links; Remove Slot; shared NodeContextMenu positioning; localized dialog/custom markup treatment; empty-menu preflight; and the direct-call rename authorization guard. The full semantic partitions, pinned merge bases, patch hashes, and verification commands are in the program report. Program receipt: #8691 is still open, unapproved, blocked, and outside the merge queue. Its successful checks completed on 2026-09-02 and are stale relative to current |
Summary
Add right-click context menu on slot connection dots in Vue nodes (Nodes 2.0) with a 'Rename slot' option, matching litegraph parity.
Changes
dialogService.prompt()for the rename dialog. Menu position tracks canvas pan/zoom.Review Focus
LGraphCanvas.ts:8456Fixes #9062
┆Issue is synchronized with this Notion page by Unito