Repository navigation
fix: preserve paginated assets during incremental history updates - #9005
christian-byrne wants to merge 5 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook |
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughImplements incremental history merging in the assets store: new helpers for sorted insertion and trimming, incremental fetch flows that preserve previously loaded items and handle prepends/drift, and comprehensive tests covering pagination, de-duplication, offset adjustments, failure/retry, and memory limits. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1461 passed, 0 failed · 3 flaky📊 Browser Reports
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/stores/assetsStore.ts`:
- Around line 165-185: fetchHistoryIncremental currently never re-opens
pagination when the first-page load becomes full again; after the incremental
insert branch (the else block using insertAssetSorted and
prependedSinceLastLoad), detect if hasMoreHistory.value is false and
newAssets.length === BATCH_SIZE and, if so, set hasMoreHistory.value = true and
reset historyOffset.value = BATCH_SIZE (so pagination resumes from the correct
offset and avoids offset drift); ensure you do this after counting/inserting
assets (use the same newAssets, BATCH_SIZE, hasMoreHistory, historyOffset,
prependedSinceLastLoad, insertAssetSorted symbols to locate where to add the
logic).
- Around line 194-205: fetchHistoryNextPage currently zeroes
prependedSinceLastLoad after the API call which drops any drift added by
concurrent updateHistory() calls during the in-flight request; fix this by
capturing the drift at request time (e.g., const capturedDrift =
prependedSinceLastLoad.value), use adjustedOffset = historyOffset.value +
capturedDrift when calling api.getHistory in fetchHistoryNextPage, and on
successful response subtract only capturedDrift from
prependedSinceLastLoad.value (clamping to 0) instead of setting it to 0 so
concurrent increments aren’t lost; keep references to fetchHistoryNextPage,
prependedSinceLastLoad, historyOffset, api.getHistory, updateHistory,
historyLoading and isLoadingMore to locate the changes.
76b2a5f to
211a1fb
Compare
211a1fb to
a04ec6b
Compare
|
Reviewing now |
benceruleanlu
left a comment
There was a problem hiding this comment.
LGTM after the updateHistory regression is fixed
… merge Adds removeHistoryItems() to assetsStore that evicts items by ID from allHistoryItems and loadedIds. The delete flow in useMediaAssetActions now calls it for successfully deleted output assets before updateHistory(), so deleted items no longer persist after the append-only incremental merge. Addresses review feedback: #9005 (comment)
📦 Bundle: 5.26 MB gzip 🔴 +938 BDetailsSummary
Category Glance App Entry Points — 22.5 kB (baseline 22.5 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 81.8 kB (baseline 81.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.5 kB (baseline 17.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.05 MB (baseline 3.05 MB) • 🔴 +2.84 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 364 kB (baseline 364 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 17 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-04T18:35:32.352Z",
"gitSha": "d6535413125b9c0cbf7aa8302cf5a4d8e9e29c7b",
"branch": "infinite-scroll-issue",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2061.878000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.4590000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.53299999999996,
"heapDeltaBytes": -2859276,
"heapUsedBytes": 45679564,
"domNodes": -262,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 19.523000000000003,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2030.6679999999915,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.214,
"heapDeltaBytes": 3350248,
"heapUsedBytes": 71850068,
"domNodes": 20,
"jsHeapTotalBytes": 18612224,
"scriptDurationMs": 25.143,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2016.2950000000137,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.068000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.47400000000005,
"heapDeltaBytes": 22694776,
"heapUsedBytes": 71070656,
"domNodes": 16,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 21.469,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1779.0760000000034,
"styleRecalcs": 72,
"styleRecalcDurationMs": 38.008,
"layouts": 12,
"layoutDurationMs": 3.239,
"taskDurationMs": 742.812,
"heapDeltaBytes": 18960440,
"heapUsedBytes": 67930948,
"domNodes": 56,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 133.863,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1885.5950000000234,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.178999999999995,
"layouts": 12,
"layoutDurationMs": 4.084,
"taskDurationMs": 850.6759999999999,
"heapDeltaBytes": -1558288,
"heapUsedBytes": 46675432,
"domNodes": -265,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 135.32999999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1830.4990000000316,
"styleRecalcs": 72,
"styleRecalcDurationMs": 36.824,
"layouts": 12,
"layoutDurationMs": 3.6620000000000004,
"taskDurationMs": 832.5279999999999,
"heapDeltaBytes": -2003600,
"heapUsedBytes": 46678748,
"domNodes": -262,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 130.30999999999997,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.3520000000153,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.012,
"layouts": 6,
"layoutDurationMs": 0.6119999999999999,
"taskDurationMs": 328.071,
"heapDeltaBytes": 183404,
"heapUsedBytes": 48549148,
"domNodes": 76,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 23.097000000000005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.0180000000018,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.601,
"layouts": 6,
"layoutDurationMs": 0.7080000000000001,
"taskDurationMs": 312.52399999999994,
"heapDeltaBytes": 220616,
"heapUsedBytes": 48783444,
"domNodes": 75,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 21.493,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.09799999997,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.91,
"layouts": 6,
"layoutDurationMs": 0.611,
"taskDurationMs": 313.38500000000005,
"heapDeltaBytes": 223288,
"heapUsedBytes": 48893720,
"domNodes": 77,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 21.60600000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 536.3669999999843,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.062,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.31100000000004,
"heapDeltaBytes": 9138692,
"heapUsedBytes": 57449112,
"domNodes": 17,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 63.115,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 571.4679999999817,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.72700000000003,
"heapDeltaBytes": 9089624,
"heapUsedBytes": 57420396,
"domNodes": 18,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 59.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 557.0689999999558,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.825,
"heapDeltaBytes": 9114280,
"heapUsedBytes": 57782720,
"domNodes": 16,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 58.574,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2040.0089999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.302999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.23,
"heapDeltaBytes": 4571564,
"heapUsedBytes": 62947060,
"domNodes": -263,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 109.475,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.9180000000279,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.713000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.122,
"heapDeltaBytes": 1546992,
"heapUsedBytes": 59839524,
"domNodes": -263,
"jsHeapTotalBytes": 5533696,
"scriptDurationMs": 105.266,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.573999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.242,
"heapDeltaBytes": 6616596,
"heapUsedBytes": 64949880,
"domNodes": -265,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 95.68700000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2122.950000000003,
"styleRecalcs": 68,
"styleRecalcDurationMs": 18.179000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1161.984,
"heapDeltaBytes": -863360,
"heapUsedBytes": 58502156,
"domNodes": -264,
"jsHeapTotalBytes": 6262784,
"scriptDurationMs": 407.908,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2132.0479999999975,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.273,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1111.0240000000001,
"heapDeltaBytes": 2547328,
"heapUsedBytes": 62132592,
"domNodes": -270,
"jsHeapTotalBytes": 1282048,
"scriptDurationMs": 398.998,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2120.4249999999547,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.461000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1146.06,
"heapDeltaBytes": 11094728,
"heapUsedBytes": 70379212,
"domNodes": -256,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 425.82200000000006,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3166.015000000016,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.830999999999996,
"layouts": 60,
"layoutDurationMs": 7.807999999999999,
"taskDurationMs": 1424.273,
"heapDeltaBytes": 19119284,
"heapUsedBytes": 80011412,
"domNodes": -268,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 531.512,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3142.9259999999886,
"styleRecalcs": 62,
"styleRecalcDurationMs": 15.620000000000003,
"layouts": 60,
"layoutDurationMs": 7.599,
"taskDurationMs": 1323.6460000000002,
"heapDeltaBytes": 12745720,
"heapUsedBytes": 65201056,
"domNodes": 6,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 509.431,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3197.010999999975,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.691,
"layouts": 60,
"layoutDurationMs": 7.784,
"taskDurationMs": 1369.08,
"heapDeltaBytes": -5054760,
"heapUsedBytes": 57056532,
"domNodes": -268,
"jsHeapTotalBytes": 5066752,
"scriptDurationMs": 524.015,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2032.2040000000356,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.180999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.762,
"heapDeltaBytes": 4366916,
"heapUsedBytes": 65973184,
"domNodes": -263,
"jsHeapTotalBytes": 4542464,
"scriptDurationMs": 97.61299999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.7979999999707,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.079999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.255,
"heapDeltaBytes": 7891316,
"heapUsedBytes": 68596440,
"domNodes": -265,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 103.396,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2053.506000000084,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.413,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.3029999999999,
"heapDeltaBytes": 4296516,
"heapUsedBytes": 64524112,
"domNodes": -263,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 103.024,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.1320000000069,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.725999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.9649999999999,
"heapDeltaBytes": 9107944,
"heapUsedBytes": 57729844,
"domNodes": 16,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 128.065,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 537.4530000000277,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.463000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.50600000000003,
"heapDeltaBytes": -11928460,
"heapUsedBytes": 54223000,
"domNodes": 20,
"jsHeapTotalBytes": 19492864,
"scriptDurationMs": 123.974,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.3439999999673,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.622000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.321,
"heapDeltaBytes": 9187988,
"heapUsedBytes": 58028476,
"domNodes": 18,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 126.51600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.9240000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.329,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.76599999999996,
"heapDeltaBytes": 23070404,
"heapUsedBytes": 71630912,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 18.411000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1997.7539999999863,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.732000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.96200000000005,
"heapDeltaBytes": 22527108,
"heapUsedBytes": 71167816,
"domNodes": 20,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 16.690999999999992,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.8150000000078,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.03800000000007,
"heapDeltaBytes": 22282492,
"heapUsedBytes": 70946436,
"domNodes": 16,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 18.441,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.3489999999747,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.083999999999996,
"layouts": 16,
"layoutDurationMs": 4.944000000000001,
"taskDurationMs": 692.0260000000001,
"heapDeltaBytes": 14507948,
"heapUsedBytes": 63160156,
"domNodes": 63,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 97.05199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.7960000000248,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.822,
"layouts": 16,
"layoutDurationMs": 4.571000000000001,
"taskDurationMs": 660.248,
"heapDeltaBytes": 13980896,
"heapUsedBytes": 63730412,
"domNodes": 61,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 94.26299999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.79900000006,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.042,
"layouts": 16,
"layoutDurationMs": 4.783999999999999,
"taskDurationMs": 731.292,
"heapDeltaBytes": -4964740,
"heapUsedBytes": 43757020,
"domNodes": -263,
"jsHeapTotalBytes": 14282752,
"scriptDurationMs": 95.551,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8176.1960000000045,
"styleRecalcs": 249,
"styleRecalcDurationMs": 54.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4047.3759999999997,
"heapDeltaBytes": 13629108,
"heapUsedBytes": 72067812,
"domNodes": -263,
"jsHeapTotalBytes": 2068480,
"scriptDurationMs": 1338.313,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.047999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 53.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3972.066,
"heapDeltaBytes": 20504100,
"heapUsedBytes": 78886412,
"domNodes": -257,
"jsHeapTotalBytes": 1544192,
"scriptDurationMs": 1323.973,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8210.552000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 51.809000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4042.6830000000004,
"heapDeltaBytes": 13988224,
"heapUsedBytes": 72407884,
"domNodes": -263,
"jsHeapTotalBytes": 9932800,
"scriptDurationMs": 1443.5720000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12904.920000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12886.438000000002,
"heapDeltaBytes": -24717936,
"heapUsedBytes": 164137888,
"domNodes": -3306,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 684.513,
"eventListeners": -16472,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12668.713000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12650.466000000002,
"heapDeltaBytes": -35040688,
"heapUsedBytes": 173529860,
"domNodes": -8331,
"jsHeapTotalBytes": 847872,
"scriptDurationMs": 696.766,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12943.06000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12920.728000000001,
"heapDeltaBytes": -38107052,
"heapUsedBytes": 166571736,
"domNodes": -8329,
"jsHeapTotalBytes": -10424320,
"scriptDurationMs": 656.285,
"eventListeners": -16492,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15214.669999999955,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.019000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15177.973999999998,
"heapDeltaBytes": -48271360,
"heapUsedBytes": 153777692,
"domNodes": -8329,
"jsHeapTotalBytes": -3411968,
"scriptDurationMs": 1004.343,
"eventListeners": -16490,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14640.060000000063,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.073999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14605.485999999999,
"heapDeltaBytes": -38525748,
"heapUsedBytes": 169117304,
"domNodes": -8331,
"jsHeapTotalBytes": -1335296,
"scriptDurationMs": 884.247,
"eventListeners": -16490,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14517.668999999954,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.642999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14482.075,
"heapDeltaBytes": -42074556,
"heapUsedBytes": 153621268,
"domNodes": -8331,
"jsHeapTotalBytes": -2297856,
"scriptDurationMs": 913.201,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 133.8480000000004,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.935000000000002,
"layouts": 8,
"layoutDurationMs": 2.569,
"taskDurationMs": 107.25999999999999,
"heapDeltaBytes": 3510960,
"heapUsedBytes": 54510276,
"domNodes": 172,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.727000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 464.4140000000334,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.279000000000003,
"layouts": 5,
"layoutDurationMs": 1.279,
"taskDurationMs": 124.70399999999998,
"heapDeltaBytes": 5166292,
"heapUsedBytes": 55542772,
"domNodes": 159,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.276999999999997,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 460.2979999999661,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.747999999999998,
"layouts": 5,
"layoutDurationMs": 1.3259999999999998,
"taskDurationMs": 119.62900000000002,
"heapDeltaBytes": 5019640,
"heapUsedBytes": 56172576,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.231,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
benceruleanlu
left a comment
There was a problem hiding this comment.
Left one inline comment about pagination bookkeeping after deletes.
… merge Adds removeHistoryItems() to assetsStore that evicts items by ID from allHistoryItems and loadedIds. The delete flow in useMediaAssetActions now calls it for successfully deleted output assets before updateHistory(), so deleted items no longer persist after the append-only incremental merge. Addresses review feedback: #9005 (comment)
…een rows Addresses review feedback: removeHistoryItems() now decrements historyOffset by the number of removed items so the next loadMoreHistory() call does not skip unseen history rows. #9005 (comment)
469c8f3 to
972b14f
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #9005 +/- ##
===========================================
- Coverage 71.79% 56.08% -15.71%
===========================================
Files 1492 1383 -109
Lines 84176 70856 -13320
Branches 23224 19728 -3496
===========================================
- Hits 60432 39742 -20690
- Misses 22882 30587 +7705
+ Partials 862 527 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 990 files with indirect coverage changes 🚀 New features to boost your workflow:
|
updateHistory() reset all pagination state (offset=0, cleared items) on every job event, causing assets loaded beyond the first batch to vanish during infinite scroll. Refactor to incremental prepend approach: subsequent updateHistory() calls fetch page 1 and merge only new items. Track prepended count between pagination calls so loadMoreHistory() adjusts offset to avoid duplicates from shifted data. Amp-Thread-ID: https://ampcode.com/threads/T-019c7a21-9e2b-73dc-81bf-d7c64574345c
Address code review feedback: - Re-enable pagination (hasMoreHistory=true) when history grows past one page after previously being exhausted. Skip drift accumulation while pagination is inactive. - Capture drift at request time in fetchHistoryNextPage and subtract only the captured amount on success, preserving concurrent updateHistory() increments during in-flight fetches. Amp-Thread-ID: https://ampcode.com/threads/T-019c7a21-9e2b-73dc-81bf-d7c64574345c
… merge Adds removeHistoryItems() to assetsStore that evicts items by ID from allHistoryItems and loadedIds. The delete flow in useMediaAssetActions now calls it for successfully deleted output assets before updateHistory(), so deleted items no longer persist after the append-only incremental merge. Addresses review feedback: #9005 (comment)
…een rows Addresses review feedback: removeHistoryItems() now decrements historyOffset by the number of removed items so the next loadMoreHistory() call does not skip unseen history rows. #9005 (comment)
Adversarial review (Skeptic, Architect, Minimalist lenses) plus an oracle review surfaced two improvements without changing the underlying pagination behavior: - insertAssetSorted: tiebreak equal created_at timestamps with lexicographic id order so jobs that share a millisecond don't reorder across repeated incremental merges. - removeHistoryItems: document the historyOffset decrement invariant. After a confirmed delete, the refreshed first page is backfilled with rows that previously sat past the old page-1 boundary; those backfilled rows count as drift, so the cursor must shrink by removedCount or the next loadMoreHistory will compose `historyOffset + drift` and silently skip unseen rows. - Add a regression test that combines deletion with a non-zero drift counter and asserts the composed offset `(BATCH_SIZE - removed) + drift`. The existing tests covered each branch in isolation but not the composition. Amp-Thread-ID: https://ampcode.com/threads/T-019df415-3078-74f9-9f05-c148c442293c
972b14f to
cd9eb15
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
This is not the correct way to approach pagination here. Start over and present the problem and a few alternative solutions. The API should be working for us not against us and we shouldn't have to roll all our own code for this library-solved class of issues/functionalities.
Pull request was converted to draft
|
Closing as superseded. This PR hand-rolled offset-drift bookkeeping ( That's now happening:
No unique value remains here, and the offset path this builds on is being removed. Tracking the fix via #12769 + #12464 instead. |
Summary
Fix assets disappearing from Media Assets panel during infinite scroll when new jobs complete.
Changes
assetsStore.updateHistory()from full-reset to incremental prepend. On subsequent calls, only page 1 is fetched and genuinely new items are merged viainsertAssetSorted(). AprependedSinceLastLoadcounter tracks offset drift soloadMoreHistory()skips already-loaded items. ExtractedinsertAssetSorted()andtrimToMaxItems()helpers from the monolithicfetchHistoryAssets().Review Focus
fetchHistoryNextPage()— ensures pagination skips prepended items to avoid duplicates.prependedSinceLastLoadreset is intentionally placed after successful fetch (not before) so retries preserve the drift counter.Testing
4 new tests covering: item preservation after pagination, deduplication on overlap, offset adjustment after prepend, and drift counter preservation on fetch failure. All 31 tests pass.
┆Issue is synchronized with this Notion page by Unito