Repository navigation
FRONT-3855 fix(billing-web): word the unconfirmed handoff ending for a tab that has stopped checking - #23462
Conversation
…a tab that has stopped checking A handoff tab that stops checking a payment moves to "We couldn't confirm your payment". That screen borrowed the Checking screen's line above the reference code, "If this page still can't confirm it after a few minutes", although the page no longer checks. Design decision on DES-1310 (2026-11-16): the line above the code becomes "If nothing has changed after 24 hours, contact support with this code:", and the footer becomes "You can close this page. We'll email your invoice once this goes through." The handoff ending now has its own copy block, so the Cloud full-page ending, which does keep checking, keeps its wording.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Starting review at 250d43c. |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0bb4e22dbf66eec8a901e05b1876369a79a17b08
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (518)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23462 +/- ##
=======================================
Coverage 88.02% 88.02%
=======================================
Files 3173 3173
Lines 169943 169943
Branches 45866 45866
=======================================
Hits 149594 149594
Misses 19377 19377
Partials 972 972
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 250d43c has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
|
Approving at 250d43c. Clean: Correctness, Resilience, Access, Words, Contract, Vendor, Rollout, Rules, Cause. Not covered:
Checked: read, not run: head/base copy selection and stopped-polling lifecycle ( ~859k effective tokens for this review (4.1M raw; cache reads weighted 0.1x, cache writes 1.25-2x) |
Part of FRONT-3855. Design: DES-1310, decision of 2026-11-16.
Summary
Why. A local or Desktop checkout tab that stops checking a payment moves to "We couldn't confirm your payment". The line above the reference code still read "If this page still can't confirm it after a few minutes, contact support with this code:", although the page has stopped checking. A reviewer flagged it on PR 23405, and design has now decided the wording.
Root cause. The handoff
unconfirmedending borrowed the copy block of the Cloud full-page ending (checkout.fullPage.ending.unconfirmed). That block is written for a page that keeps checking.How. The handoff ending gets its own block,
handoff.unconfirmed, ashandoff.checkingalready has. Title and body are unchanged. Two lines change:The Cloud full-page ending keeps its wording, because it does keep checking.
Not in this PR
The same decision asks for a new ending when Cloud reports the payment
failed: "Your payment didn't go through" / "Nothing was charged. Go back to ComfyUI and try again." It is not built here. Cloud does not guarantee that afailedoperation took no money: on Cloudmainat35a849c4154,services/billing/workflows/initial_sub_stripe.go:187-188records ambiguous provider errors asfailed"where Stripe may have committed the create" (also:234). Telling that person nothing was charged and to try again could charge them twice.failedstill ends on "We couldn't confirm your payment" until design and backend settle it.Feature gate
local_billing_web. These endings exist only in a tab opened through a billing handoff, and the app issues a handoff only behind that flag. No copy that a Cloud checkout renders is changed.AS IS / TO BE
Captured from a production build of billing-web with Cloud mocked. The code
op_topupis the mock's.Verification
apps/billing-web:pnpm exec vitest run src/views/HandoffEndedView.test.ts src/handoff/paymentOutcome.test.ts, 39 tests pass.