Skip to content

FRONT-3855 fix(billing-web): word the unconfirmed handoff ending for a tab that has stopped checking - #23462

Merged
dante01yoon merged 1 commit into
mainfrom
1.61-local-billing/front-3855-payment-ending-copy
Nov 16, 2026
Merged

dante01yoon merged 1 commit into
mainfrom
1.61-local-billing/front-3855-payment-ending-copy

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator
graph LR
  A["PR 23405 (merged): the Checking screen updates itself"] --> B["this PR: wording once the tab has stopped checking"]
  B --> C["later: a failed-payment ending, pending a Cloud guarantee"]
  style B stroke-width:3px
Loading

Part of FRONT-3855. Design: DES-1310, decision of 2026-11-16.

Summary

Why. A local or Desktop checkout tab that stops checking a payment moves to "We couldn't confirm your payment". The line above the reference code still read "If this page still can't confirm it after a few minutes, contact support with this code:", although the page has stopped checking. A reviewer flagged it on PR 23405, and design has now decided the wording.

Root cause. The handoff unconfirmed ending borrowed the copy block of the Cloud full-page ending (checkout.fullPage.ending.unconfirmed). That block is written for a page that keeps checking.

How. The handoff ending gets its own block, handoff.unconfirmed, as handoff.checking already has. Title and body are unchanged. Two lines change:

  • Above the code: "If nothing has changed after 24 hours, contact support with this code:"
  • Footer: "You can close this page. We'll email your invoice once this goes through." It was "You can close this tab."

The Cloud full-page ending keeps its wording, because it does keep checking.

Not in this PR

The same decision asks for a new ending when Cloud reports the payment failed: "Your payment didn't go through" / "Nothing was charged. Go back to ComfyUI and try again." It is not built here. Cloud does not guarantee that a failed operation took no money: on Cloud main at 35a849c4154, services/billing/workflows/initial_sub_stripe.go:187-188 records ambiguous provider errors as failed "where Stripe may have committed the create" (also :234). Telling that person nothing was charged and to try again could charge them twice. failed still ends on "We couldn't confirm your payment" until design and backend settle it.

Feature gate

local_billing_web. These endings exist only in a tab opened through a billing handoff, and the app issues a handoff only behind that flag. No copy that a Cloud checkout renders is changed.

AS IS / TO BE

AS IS TO BE
"We couldn't confirm your payment", with a reference code AS IS: the code label says "after a few minutes" and the footer says "You can close this tab." TO BE: the code label says "after 24 hours" and the footer says "You can close this page. We'll email your invoice once this goes through."

Captured from a production build of billing-web with Cloud mocked. The code op_topup is the mock's.

Verification

  • In apps/billing-web: pnpm exec vitest run src/views/HandoffEndedView.test.ts src/handoff/paymentOutcome.test.ts, 39 tests pass.
  • With the view pointed back at the old copy block, 3 of the changed cases fail.
  • Not run: the billing-web Playwright specs. They assert this ending by its heading, which did not change. The full unit suite was not run either.

…a tab that has stopped checking

A handoff tab that stops checking a payment moves to "We couldn't confirm
your payment". That screen borrowed the Checking screen's line above the
reference code, "If this page still can't confirm it after a few minutes",
although the page no longer checks.

Design decision on DES-1310 (2026-11-16): the line above the code becomes
"If nothing has changed after 24 hours, contact support with this code:",
and the footer becomes "You can close this page. We'll email your invoice
once this goes through."

The handoff ending now has its own copy block, so the Cloud full-page
ending, which does keep checking, keeps its wording.
@comfy-greenlight-bot

comfy-greenlight-bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The unconfirmed payment handoff view now uses dedicated copy that warns against paying again, gives support guidance after 24 hours, and states that an invoice will be emailed when payment goes through. Tests check the updated messages.

Changes: Unconfirmed handoff copy

Layer / File(s) Summary
Unconfirmed payment copy and view
apps/billing-web/src/locales/en/main.json, apps/billing-web/src/views/HandoffEndedView.vue, apps/billing-web/src/views/HandoffEndedView.test.ts
The view uses dedicated translation keys for unconfirmed payment guidance and the close-page message. The locale adds payment, support, and invoice guidance. Tests assert the updated messages and check that the previous “still can't confirm” text is absent.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: christian-byrne, jtydhr88

Merge Risk: Minimal · up to 250d4

This is a copy-only change to the unconfirmed payment handoff message, with updated tests. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 6

Check name Status Explanation
Title check Passed The title names the ticket, the change type and scope, and the specific change: the unconfirmed handoff ending gets wording for a tab that has stopped checking. This matches the main change in the sum…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is thorough and follows the template's intent. It has a Summary that explains the problem (the stale 'after a few minutes' line and 'You can close this tab' footer on a tab that stoppe…
End-To-End Test Suggestion For User-Facing Changes Passed The check fails only when all three conditions hold. Condition 1 does not hold. The changed files named in the review context are all under apps/billing-web/: - `apps/billing-web/src/locales/en/main…
Adr Compliance For Entity/Litegraph Changes Passed The check "ADR compliance for entity/litegraph changes" applies only when the PR changes files under src/lib/litegraph/, src/ecs/, or graph-entity files (nodes, links, widgets, slots, reroutes, gr…
Full details: Title check

Explanation

The title names the ticket, the change type and scope, and the specific change: the unconfirmed handoff ending gets wording for a tab that has stopped checking. This matches the main change in the summary and objectives, which give the handoff ending its own copy block with a new support line and footer. The title is slightly long but specific, so it passes.

Full details: Description check

Explanation

The description is thorough and follows the template's intent. It has a Summary that explains the problem (the stale 'after a few minutes' line and 'You can close this tab' footer on a tab that stopped checking), the root cause (the handoff ending borrowed the Cloud full-page copy block), and the fix (a new handoff.unconfirmed block with two changed lines). It names the risks and non-obvious decisions, including why the failed-payment ending is excluded and the feature gate. It links the design decision DES-1310 and the related PR, and it includes a Verification section with the exact test command, the pass count, a mutation-style check, and the tests not run. It does not use the template's Fixes #ISSUE_NUMBER line, but the issue link is a design link and the linked issue is not a GitHub issue, so this is a minor omission. The template's optional 'after release' item is not needed here. Required content is present.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The check fails only when all three conditions hold. Condition 1 does not hold. The changed files named in the review context are all under apps/billing-web/: - apps/billing-web/src/locales/en/main.json (+6/-0) - apps/billing-web/src/views/HandoffEndedView.vue (+2/-2) - apps/billing-web/src/views/HandoffEndedView.test.ts (+10/-3) The check scopes condition 1 to the main frontend application under src/ or packages/. The apps/billing-web/src/ path is a separate app's source tree, not the main application. Per the check's rules, I did not run shell commands and did not inspect files outside the listed changed-file set. The change is also a copy change to a billing handoff ending. The PR description says it is gated by local_billing_web. The PR does not change main-app behavior under src/ or packages/. Because condition 1 is not met, the check does not fail. No Playwright suggestion is required. Note that the PR author states the billing-web Playwright specs were not run. That is outside this check's scope, because the check encourages tests and never requires them.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The check "ADR compliance for entity/litegraph changes" applies only when the PR changes files under src/lib/litegraph/, src/ecs/, or graph-entity files (nodes, links, widgets, slots, reroutes, groups, subgraphs). The changed-file list in the review context contains only three files, all under apps/billing-web/: - apps/billing-web/src/locales/en/main.json (adds a handoff.unconfirmed locale block) - apps/billing-web/src/views/HandoffEndedView.test.ts (updates expected copy) - apps/billing-web/src/views/HandoffEndedView.vue (switches translation keys to handoff.unconfirmed) None of these paths is in the scope of the check, and none is a graph-entity file. The PR description and objectives also describe only billing-web copy changes. The check therefore does not apply, so it passes without inspecting the four ADR patterns. Per the check's instructions, no shell commands were used.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0bb4e22 and 250d43c.

Files selected for processing: 3

  • apps/billing-web/src/locales/en/main.json
  • apps/billing-web/src/views/HandoffEndedView.test.ts
  • apps/billing-web/src/views/HandoffEndedView.vue

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@vqt123

vqt123 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Starting review at 250d43c.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 0bb4e22dbf66eec8a901e05b1876369a79a17b08

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (518)

  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/generated/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/generated/types.gen.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 468 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main   #23462   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files        3173     3173           
  Lines      169943   169943           
  Branches    45866    45866           
=======================================
  Hits       149594   149594           
  Misses      19377    19377           
  Partials      972      972           
Flag Coverage Δ
billing-web-unit 92.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/views/HandoffEndedView.vue 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 16, 2026

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit 250d43c has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@vqt123

vqt123 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Approving at 250d43c.

Clean: Correctness, Resilience, Access, Words, Contract, Vendor, Rollout, Rules, Cause.

Not covered:

  • Correctness/Resilience: billing-web-unit pending; pnpm --filter @comfyorg/billing-web test:coverage.
  • Words/Rollout: billing-web-e2e pending; pnpm --filter @comfyorg/billing-web test:e2e.
  • Rules/Rollout: lint-pr / lint, lint-pr / typecheck, lint-pr / repo-checks, fallow / fallow, and pr-risk / Grade PR risk pending.

Checked: read, not run: head/base copy selection and stopped-polling lifecycle (HandoffEndedView.vue:59, handoffTab.ts:429); separate Cloud full-page copy and continued checking (useFullPageCheckout.ts:595). Paths are under apps/billing-web/src/.

~859k effective tokens for this review (4.1M raw; cache reads weighted 0.1x, cache writes 1.25-2x)

@dante01yoon
dante01yoon added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit b746d46 Nov 16, 2026
99 checks passed
@dante01yoon
dante01yoon deleted the 1.61-local-billing/front-3855-payment-ending-copy branch November 16, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenlight risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants