Repository navigation
Conversation
Prefer an element-backed widget's DOM unless registration explicitly requests a native Vue replacement. Mark core multiline, Markdown, and audio widgets as native without changing component-backed routing or visibility. Add a deliberately fake PlagueKind-style devtools node and a Playwright regression for colliding string-type tabs and native slot controls. Amp-Thread-ID: https://ampcode.com/threads/T-9fdf3db3-fe71-4e75-8394-0a0e3dfdaa82
📦 Bundle: 12.4 MB gzip 🟢 -146 BDetailsSummary
Category Glance App Entry Points — 7.05 kB (baseline 7.05 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.69 MB (baseline 3.69 MB) • 🔴 +82 BGraph editor runtime, canvas, workflow orchestration
Status: 4 added / 4 removed / 1 unchanged Views & Navigation — 152 kB (baseline 152 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed / 29 unchanged User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 12 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 8 unchanged UI Components — 369 kB (baseline 369 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed / 24 unchanged Data & Services — 2.03 MB (baseline 2.03 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 23 added / 23 removed / 23 unchanged Utilities & Hooks — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 32 added / 32 removed / 54 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 36.6 MB (baseline 36.6 MB) • 🟢 -129 BBundles that do not match a named category
Status: 86 added / 86 removed / 680 unchanged ⚡ Performance: ⏳ Performance tests in progress…🎭 Playwright: ✅ 3326 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (19 changed files).
Pre-existing findings are baselined in Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 275dd2a09532cb42c939a921890a3c53322c870e
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (518)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23459 +/- ##
==========================================
- Coverage 88.02% 87.93% -0.10%
==========================================
Files 3173 3057 -116
Lines 169943 166203 -3740
Branches 45866 42546 -3320
==========================================
- Hits 149594 146151 -3443
+ Misses 19377 19249 -128
+ Partials 972 803 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Preserve extension DOM widgets in Nodes 2.0 even when their type matches a native widget. Core multiline, Markdown, and audio widgets explicitly request
vueNodeRenderer: 'native'; component-backed widgets and visibility rules keep their existing behavior.Remount the live DOM element when a widget is replaced under the same name and type. Add a test-only PlagueKind-ish simulacrum with imaginary cats, a stunt potato, and no media processing. Its Playwright test covers colliding string-type tabs, same-name replacement and its original click listener, slot visibility, a canvas-only preview, and the native multiline editor.
Evidence
pnpm test:browser:local domTypeCollision.spec.ts --project=chromium --repeat-each=3: passes against a production frontend bundle and local devtools backend.$$pk_media_tabsbecomes a textbox instead of DOM buttons.Merge danger
Two-way door. This changes renderer precedence for element-backed extension widgets. Extensions intentionally relying on automatic native replacement must request
vueNodeRenderer: 'native'. PlagueKind's explicit Vue visibility opt-outs remain unchanged; this is not a full port of its media features.Related: FRONT-4123 tracks remaining preview policy, sizing, lifecycle checks, and model-dependent validation. This PR addresses its generic DOM rendering and replacement bugs only.