Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
📦 Bundle: 12.4 MB gzip 🟢 -5 BDetailsSummary
Category Glance App Entry Points — 7.05 kB (baseline 7.05 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.69 MB (baseline 3.69 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 4 unchanged Views & Navigation — 152 kB (baseline 152 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 18 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 19 unchanged UI Components — 369 kB (baseline 369 kB) • ⚪ 0 BReusable component library chunks Status: 34 unchanged Data & Services — 2.03 MB (baseline 2.03 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 45 unchanged Utilities & Hooks — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 86 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 36.6 MB (baseline 36.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 764 unchanged ⚡ Performance: ⏳ Performance tests in progress…🎭 Playwright: ✅ 3297 passed, 0 failed · 4 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4e44947c7c1e4e1bfd7206b01775af8c23fc967b
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (518)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23426 +/- ##
==========================================
- Coverage 88.02% 87.93% -0.10%
==========================================
Files 3172 3056 -116
Lines 169900 166150 -3750
Branches 45855 44554 -1301
==========================================
- Hits 149557 146106 -3451
+ Misses 19371 19241 -130
+ Partials 972 803 -169
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
getSlot matched widget rows and slots on any descendant whose full text equalled the name. A widget row's text includes the widget's current value, so a widget whose value was exactly a slot name still selected its own row alongside the real slot. Widget rows now match on data-widget-name and slots on their exact label, so a widget's value can no longer select its row. Amp-Thread-ID: https://ampcode.com/threads/T-e7cc9737-d4ac-4ccc-96ac-bfcd856c7a48
2198963 to
73a3ead
Compare
Summary
Follow-up to #23425.
VueNodeFixture.getSlot(name)now matches a row when any descendant's full text equals the name, and a widget row's text includes the widget's current value. A widget whose value is exactly a slot name therefore still selects its own row next to the real slot, the gap raised in #23425 (comment).Decisions worth a veto:
.first()to work around the old substring match. They still pass and are left as they are.No new test. The failing case needs a widget value set to a slot name, which no current spec does.
Verification
imagewidget toMASK. Withmain's fixture,getSlot('MASK')resolves to 2 elements; with this change it resolves to 1, andgetSlot('image')still resolves to 1.getSlotwas run with the change: 100 of 102 pass.linkInteraction.spec.ts:299is a local screenshot diff that fails identically onmain.nodeSelection.spec.ts:19timed out inbeforeEachbehind an error toast, does not callgetSlot, and passed 3 of 3 on rerun.pnpm typecheck:browserpass.Merge Danger
Door: two-way. Test fixture only.
Blast Radius: E2E. A spec that selected a widget row by its label instead of its name would stop finding its slot; none of the current callers do.