Repository navigation
[backport cloud/1.60] fix(auth): recover reads after the web session lapses (CLOUD-FRONTEND-PROD-29N) - #23372
Conversation
…-PROD-29N) (#22446) ## Why Sentry [CLOUD-FRONTEND-PROD-29N](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-29N) (about 1,080 users) reports `getBillingCapabilities` refused with 401 on the web-session cookie. [CLOUD-FRONTEND-PROD-35S](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-35S) (`listDeployments`) and [CLOUD-FRONTEND-PROD-2D3](https://comfy-org.sentry.io/issues/CLOUD-FRONTEND-PROD-2D3) (workspaces list) are the same refusal seen from other readers. The warning hides a user-facing defect: after the session is silently restored, capabilities stay `denied` until reload. Every capability-gated control reads as denied for a signed-in, paying user. In the capture below, Add credits, Plans & pricing and Manage plan disappear from the user menu. The Run button was not affected there, because it follows billing status, not capabilities. ## Root cause - The session cookie has an idle expiry that reading the session does not extend (`expires_at` in `@comfyorg/ingest-types`: "Real use slides it; reading the session does not"). A tab left hidden for hours outlives it. - The heartbeat only runs while the tab is visible. A hidden tab never notices. - When the tab comes back, the heartbeat and the capabilities read fire on the same `visibilitychange`. Both get 401 in the same millisecond. Breadcrumbs from 5 events across 3 releases all show this shape. - `fetchOnWebSession` only recovers from `csrf_invalid` (403). A 401 is returned as is, so the read fails even though the heartbeat then restores the session from the remembered Firebase sign-in. - `useBillingCapabilities` has no retry path out of `denied`. There is no refresh timer, it does not re-read on visibility, and it only re-reads when the actor, workspace or role changes, none of which change on a restore. ## How Behind a new flag, `web_session_lapse_recovery_enabled` (default **off**): 1. `fetchOnWebSession` treats a 401 like `csrf_invalid`. It refreshes the session for the same user and epoch and replays the request once on the fresh session. If the refresh does not return a session (signed out, different user), the original 401 is returned. Streamed bodies are never replayed, same as the CSRF path. This covers capabilities, deployments and workspaces reads in one place. 2. `useBillingCapabilities` re-reads when it is `denied` and the web session moves to a new `signed_in` state. Not behind the flag (account-core has no flag store), so these also apply with the flag off and ship with any backport: - A web-session restore gives up on a remembered-login proof that takes longer than 15 seconds, so refreshes waiting on it settle instead of hanging. - Concurrent restores for the same account share one attempt: one proof, one `POST /api/auth/session`. - When a restore's proof fails or times out while the tab is signed in, one more restore is scheduled after 1 second. It is not repeated if that attempt also fails. With the flag off, a 401 is returned as is, `csrf_invalid` keeps its existing single replay, and capabilities stay `denied` after a restore. Nothing combines server facts: the retry keys only on the HTTP status, and the re-read only on the session phase. The flag is not flipped anywhere in this PR. Open backend question, not part of this PR: should the heartbeat or a token mint extend the idle expiry? ## Red-green verification | Commit | CI (unit tests) | Purpose | | --- | --- | --- | | `test: pin recovering reads after the web session lapses` | [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41156440525) | Flag off returns the 401 and stays denied. Flag on retries once on the refreshed session and re-reads capabilities after a restore. A streamed body is not replayed. The 2 flag-on cases fail on this commit. | | `fix: recover reads after the web session lapses` + `fix: resolve the web session store when capabilities are set up` | [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41158814927) | Adds the flag, the 401 retry and the re-read. The same tests pass. The second commit resolves the session store at setup; the [first green run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41156444097) passed every test but hit an unhandled "Pinia destroyed" from the lazy store lookup in `webSessionFlagOn.test.ts`. | ## AS IS / TO BE Local dev against testcloud, team workspace with an active plan, capabilities read on the session-cookie rail (`ff:billing_sdk_topup_enabled` / `ff:billing_sdk_subscription_enabled` = false). Deleted only the `__Host-comfy_session` cookie just before the scheduled capabilities refetch, then opened the user menu. | AS IS (flag off) | TO BE (flag on) | | --- | --- | | <img src="https://gist.githubusercontent.com/dante01yoon/0f62206c5acddb219a4915b55f545b0d/raw/eb2081dea72ac52bc6cf5cd51f66c82807abdf98/lapse-as-is.png" width="400"><br>`GET /api/billing/capabilities` 401, then the session heartbeat restores the cookie (`GET /api/auth/session` 401, `POST` 200) but no re-read follows: the menu loses Add credits, Plans & pricing and Manage plan until reload. | <img src="https://gist.githubusercontent.com/dante01yoon/0f62206c5acddb219a4915b55f545b0d/raw/eb2081dea72ac52bc6cf5cd51f66c82807abdf98/lapse-to-be.png" width="400"><br>`GET /api/billing/capabilities` 401, session refreshed (`GET` 401, `POST` 200), the read replays and returns 200 within a second: the menu stays normal. | ## Plan position | Item | Source | PR | Status | | --- | --- | --- | --- | | Reroute requiresAuth routes on a confirmed sign-out | CLOUD-FRONTEND-PROD-368 | [PR 22400](#22400) | In review | | Report a 401 deployment listing as a denied warning | CLOUD-FRONTEND-PROD-35S | [PR 22411](#22411) | In review | | **Recover reads after the web session lapses (flagged)** | CLOUD-FRONTEND-PROD-29N | **this PR** | **In review** | | Serve `web_session_lapse_recovery_enabled` on /api/features; PostHog flag at 0% (Prod 204330, Staging 204367) | Cloud | [cloud PR 17313](Comfy-Org/cloud#17313) | In review | | Enable `web_session_lapse_recovery_enabled` | PostHog | – | After both PRs merge | | Should the heartbeat or a token mint extend idle expiry? | Backend | – | To discuss | ```mermaid graph LR A["PR 22411: 401 listing as warning"] --> B["This PR: lapse recovery"] B --> C["Enable web_session_lapse_recovery_enabled"] B -.-> D["BE: idle expiry sliding"] style B fill:#f9d71c,stroke:#333,stroke-width:2px ```
⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-13T20:20:50.114Z",
"gitSha": "4f94a72190430e6831caf31173938e14b9ecc92a",
"branch": "backport-22446-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.4279999999867,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1150000000000007,
"layouts": 9,
"layoutDurationMs": 3.021,
"taskDurationMs": 664.423,
"heapDeltaBytes": 1833604,
"heapUsedBytes": 75770680,
"domNodes": -178,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 12.032000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2031.3429999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.718,
"layouts": 8,
"layoutDurationMs": 2.494999999999999,
"taskDurationMs": 653.498,
"heapDeltaBytes": 3205924,
"heapUsedBytes": 63743688,
"domNodes": -178,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 11.022,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1917.936999999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.105999999999998,
"layouts": 9,
"layoutDurationMs": 2.531,
"taskDurationMs": 997.5860000000001,
"heapDeltaBytes": 14840332,
"heapUsedBytes": 76397420,
"domNodes": -178,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 163.945,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608695652174,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.9289999999755,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.362,
"layouts": 10,
"layoutDurationMs": 3.0969999999999995,
"taskDurationMs": 963.433,
"heapDeltaBytes": 7431364,
"heapUsedBytes": 84546588,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 161.23,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.8880000000313,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.7780000000000005,
"layouts": 12,
"layoutDurationMs": 3.001,
"taskDurationMs": 472.46599999999995,
"heapDeltaBytes": 6359852,
"heapUsedBytes": 83630168,
"domNodes": 57,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 14.503000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3880000000527,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.714,
"layouts": 11,
"layoutDurationMs": 3.3449999999999998,
"taskDurationMs": 496.75199999999995,
"heapDeltaBytes": 12448920,
"heapUsedBytes": 85762256,
"domNodes": 57,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 14.75,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 702.8620000000103,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.777,
"layouts": 8,
"layoutDurationMs": 2.28,
"taskDurationMs": 514.5920000000001,
"heapDeltaBytes": 7005512,
"heapUsedBytes": 68880460,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 169.81400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 727.2859999999355,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.993,
"layouts": 9,
"layoutDurationMs": 2.555,
"taskDurationMs": 526.3709999999999,
"heapDeltaBytes": 13666576,
"heapUsedBytes": 87430024,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 170.71800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.5439999999755,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 961.613,
"heapDeltaBytes": -6520296,
"heapUsedBytes": 78241164,
"domNodes": -208,
"jsHeapTotalBytes": 15474688,
"scriptDurationMs": 72.052,
"eventListeners": -107,
"totalBlockingTimeMs": 529,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.7770000000328,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 990.1229999999998,
"heapDeltaBytes": -10832972,
"heapUsedBytes": 78039524,
"domNodes": -208,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 67.064,
"eventListeners": -107,
"totalBlockingTimeMs": 552,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 906.7549999999756,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.4910000000003,
"heapDeltaBytes": -6193988,
"heapUsedBytes": 89279088,
"domNodes": 0,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 147.745,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.3699999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.9810000000002,
"heapDeltaBytes": -2593344,
"heapUsedBytes": 73005880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.559,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10639.880000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3039999999999996,
"layouts": 1,
"layoutDurationMs": 0.3210000000000001,
"taskDurationMs": 9769.214,
"heapDeltaBytes": 65818408,
"heapUsedBytes": 142646140,
"domNodes": -274,
"jsHeapTotalBytes": 75624448,
"scriptDurationMs": 7614.984,
"eventListeners": -69,
"totalBlockingTimeMs": 523,
"frameDurationMs": 29.45401662049862,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9861.949999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.24699999999999983,
"layouts": 1,
"layoutDurationMs": 0.2419999999999996,
"taskDurationMs": 9008.971,
"heapDeltaBytes": -4654496,
"heapUsedBytes": 84746684,
"domNodes": -270,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 7147.620000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 322,
"frameDurationMs": 28.351149425287357,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9824.99900000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06000000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9029.546,
"heapDeltaBytes": 57353972,
"heapUsedBytes": 141314976,
"domNodes": -274,
"jsHeapTotalBytes": 63303680,
"scriptDurationMs": 6983.803,
"eventListeners": -69,
"totalBlockingTimeMs": 222,
"frameDurationMs": 27.419553072625696,
"p95FrameDurationMs": 50.00000000000091
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9245.679999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8433.128,
"heapDeltaBytes": 66930736,
"heapUsedBytes": 143224272,
"domNodes": -274,
"jsHeapTotalBytes": 47312896,
"scriptDurationMs": 6492.849,
"eventListeners": -69,
"totalBlockingTimeMs": 299,
"frameDurationMs": 28.614153846153847,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 255.43700000000058,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.708000000000002,
"layouts": 9,
"layoutDurationMs": 2.95,
"taskDurationMs": 211.85500000000002,
"heapDeltaBytes": -2761404,
"heapUsedBytes": 70677912,
"domNodes": -2427,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 9.869,
"eventListeners": -604,
"totalBlockingTimeMs": 1,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 235.01800000002504,
"styleRecalcs": 20,
"styleRecalcDurationMs": 13.201999999999998,
"layouts": 7,
"layoutDurationMs": 2.209999999999999,
"taskDurationMs": 165.99399999999997,
"heapDeltaBytes": 14954180,
"heapUsedBytes": 75642488,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.711,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.32000000000003,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2056.9429999999898,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8870000000000005,
"layouts": 8,
"layoutDurationMs": 2.2829999999999995,
"taskDurationMs": 725.424,
"heapDeltaBytes": 4792704,
"heapUsedBytes": 86736160,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 38.23199999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.6010000000006,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3930000000000002,
"layouts": 7,
"layoutDurationMs": 2.1749999999999994,
"taskDurationMs": 734.242,
"heapDeltaBytes": -28196064,
"heapUsedBytes": 62531924,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 34.93,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2940.119999999979,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.185999999999998,
"layouts": 7,
"layoutDurationMs": 2.155,
"taskDurationMs": 1818.256,
"heapDeltaBytes": -31540172,
"heapUsedBytes": 63487296,
"domNodes": -274,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 856.5070000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2931.085000000053,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.724,
"layouts": 8,
"layoutDurationMs": 2.2399999999999998,
"taskDurationMs": 1781.863,
"heapDeltaBytes": -12972836,
"heapUsedBytes": 78741404,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 827.504,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3646.275000000003,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.295,
"layouts": 65,
"layoutDurationMs": 11.893999999999998,
"taskDurationMs": 1694.757,
"heapDeltaBytes": -1852340,
"heapUsedBytes": 71765424,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 815.0050000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 4077.8009999999085,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.264,
"layouts": 65,
"layoutDurationMs": 11.908999999999999,
"taskDurationMs": 1903.2910000000002,
"heapDeltaBytes": -17224752,
"heapUsedBytes": 67199360,
"domNodes": -250,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 822.7099999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3250.8119999999963,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.492999999999999,
"layouts": 4,
"layoutDurationMs": 1.075,
"taskDurationMs": 2164.1499999999996,
"heapDeltaBytes": -12606112,
"heapUsedBytes": 82127620,
"domNodes": -274,
"jsHeapTotalBytes": 6610944,
"scriptDurationMs": 1047.517,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83834196891192,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3188.1970000000592,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.707999999999999,
"layouts": 5,
"layoutDurationMs": 1.496,
"taskDurationMs": 2091.548,
"heapDeltaBytes": -23149692,
"heapUsedBytes": 71796100,
"domNodes": 0,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 1045.106,
"eventListeners": 182,
"totalBlockingTimeMs": 28,
"frameDurationMs": 16.93015873015873,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3081.8730000000014,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.908,
"layouts": 6,
"layoutDurationMs": 1.6880000000000002,
"taskDurationMs": 825.9159999999999,
"heapDeltaBytes": -11819936,
"heapUsedBytes": 60914244,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 367.115,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3051.762999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7269999999999994,
"layouts": 7,
"layoutDurationMs": 1.6929999999999996,
"taskDurationMs": 817.241,
"heapDeltaBytes": -8926288,
"heapUsedBytes": 75673928,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 353.329,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2068.792999999971,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.6990000000000007,
"layouts": 6,
"layoutDurationMs": 1.8790000000000004,
"taskDurationMs": 788.147,
"heapDeltaBytes": 409436,
"heapUsedBytes": 84308268,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 45.062,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.5980000000882,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.220999999999999,
"layouts": 8,
"layoutDurationMs": 2.2800000000000002,
"taskDurationMs": 743.4999999999999,
"heapDeltaBytes": -18469116,
"heapUsedBytes": 67264156,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 39.898,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2754.084000000006,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.415000000000001,
"layouts": 7,
"layoutDurationMs": 1.7679999999999996,
"taskDurationMs": 571.8330000000001,
"heapDeltaBytes": 7462080,
"heapUsedBytes": 91375504,
"domNodes": 19,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 183.804,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2802.7680000000146,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.33,
"layouts": 6,
"layoutDurationMs": 1.8469999999999998,
"taskDurationMs": 575.315,
"heapDeltaBytes": 9102404,
"heapUsedBytes": 91859200,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 180.81000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665476190476188,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3249.9599999999873,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1020000000000008,
"layouts": 6,
"layoutDurationMs": 1.86,
"taskDurationMs": 919.9370000000001,
"heapDeltaBytes": -8339368,
"heapUsedBytes": 76254916,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 364.93699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3340.2889999999843,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8520000000000003,
"layouts": 6,
"layoutDurationMs": 1.64,
"taskDurationMs": 971.2030000000001,
"heapDeltaBytes": -8373268,
"heapUsedBytes": 75706556,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 391.718,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749748743718595,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 677.0799999999895,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.974,
"layouts": 8,
"layoutDurationMs": 2.213,
"taskDurationMs": 457.374,
"heapDeltaBytes": 24900872,
"heapUsedBytes": 88260988,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 148.74,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.4810000000043,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.445,
"layouts": 10,
"layoutDurationMs": 2.8600000000000003,
"taskDurationMs": 465.79799999999994,
"heapDeltaBytes": 8612608,
"heapUsedBytes": 83071236,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 148.35000000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2040.0789999999915,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.987,
"layouts": 9,
"layoutDurationMs": 2.712,
"taskDurationMs": 657.9820000000001,
"heapDeltaBytes": -10224756,
"heapUsedBytes": 51727816,
"domNodes": -200,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.391,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.2549999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6170000000000004,
"layouts": 8,
"layoutDurationMs": 2.338,
"taskDurationMs": 588.067,
"heapDeltaBytes": 11866944,
"heapUsedBytes": 74931680,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 10.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.2479999999928,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.531,
"layouts": 8,
"layoutDurationMs": 2.4459999999999997,
"taskDurationMs": 878.1909999999999,
"heapDeltaBytes": 24317176,
"heapUsedBytes": 86958748,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 111.813,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.2830000000058,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.07,
"layouts": 10,
"layoutDurationMs": 2.719,
"taskDurationMs": 930.6920000000001,
"heapDeltaBytes": -10737712,
"heapUsedBytes": 60923972,
"domNodes": -200,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 113.17899999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1559.3319999999835,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.27,
"layouts": 5,
"layoutDurationMs": 15.645,
"taskDurationMs": 1364.7199999999998,
"heapDeltaBytes": 18398604,
"heapUsedBytes": 101714924,
"domNodes": 19229,
"jsHeapTotalBytes": 22020096,
"scriptDurationMs": 33.717,
"eventListeners": 3566,
"totalBlockingTimeMs": 183,
"frameDurationMs": 20.562337662337665,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 11674.53599999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.687,
"layouts": 8,
"layoutDurationMs": 2.344,
"taskDurationMs": 6426.984000000001,
"heapDeltaBytes": 10380312,
"heapUsedBytes": 84633300,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2819.3030000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666048502139798,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11800.007999999934,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.806,
"layouts": 9,
"layoutDurationMs": 2.4940000000000007,
"taskDurationMs": 6371.656000000001,
"heapDeltaBytes": -14138068,
"heapUsedBytes": 79728504,
"domNodes": -274,
"jsHeapTotalBytes": 4550656,
"scriptDurationMs": 2832.8129999999996,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915255,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 24987.67600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24455.658,
"heapDeltaBytes": -31816112,
"heapUsedBytes": 265738516,
"domNodes": -3482,
"jsHeapTotalBytes": 18604032,
"scriptDurationMs": 367.456,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.043243243243246,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-idle",
"durationMs": 25489.606999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25002.375999999997,
"heapDeltaBytes": -21699592,
"heapUsedBytes": 266945280,
"domNodes": -3482,
"jsHeapTotalBytes": 9682944,
"scriptDurationMs": 381.15500000000003,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.3209591474245,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 30603.159000000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.404999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30398.988,
"heapDeltaBytes": -20184548,
"heapUsedBytes": 283283580,
"domNodes": -3482,
"jsHeapTotalBytes": 10924032,
"scriptDurationMs": 959.236,
"eventListeners": -659,
"totalBlockingTimeMs": 71,
"frameDurationMs": 60.11552062868369,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 30678.049999999985,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.307999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30431.684999999998,
"heapDeltaBytes": -13095660,
"heapUsedBytes": 274900632,
"domNodes": -3482,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 1186.3570000000002,
"eventListeners": -659,
"totalBlockingTimeMs": 363,
"frameDurationMs": 58.66558317399618,
"p95FrameDurationMs": 116.70000000000437
},
{
"name": "vue-node-resize-workload",
"durationMs": 8983.099999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.86599999999997,
"layouts": 20,
"layoutDurationMs": 26.85599999999999,
"taskDurationMs": 8887.089,
"heapDeltaBytes": -47004188,
"heapUsedBytes": 249950392,
"domNodes": -3482,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 142.00799999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.09111111111112,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 9161.673000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.15999999999999,
"layouts": 20,
"layoutDurationMs": 23.995,
"taskDurationMs": 9038.708,
"heapDeltaBytes": -35477276,
"heapUsedBytes": 274908104,
"domNodes": -3482,
"jsHeapTotalBytes": 5488640,
"scriptDurationMs": 133.85,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.284000000000006,
"p95FrameDurationMs": 116.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 13037.73799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12693.692,
"heapDeltaBytes": -553656,
"heapUsedBytes": 282694272,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 178.08199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.052296819788,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12851.272999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12559.853000000001,
"heapDeltaBytes": 6285408,
"heapUsedBytes": 272148808,
"domNodes": -3126,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 225.38499999999993,
"eventListeners": -654,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.388086642599276,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 162.80399999999418,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.251000000000001,
"layouts": 10,
"layoutDurationMs": 5.003,
"taskDurationMs": 124.916,
"heapDeltaBytes": -11171312,
"heapUsedBytes": 63503168,
"domNodes": 107,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 14.624,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 131.44999999997253,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.959999999999999,
"layouts": 9,
"layoutDurationMs": 3.72,
"taskDurationMs": 89.119,
"heapDeltaBytes": 4902992,
"heapUsedBytes": 66833580,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.890999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 526.2109999999893,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7290000000000001,
"layouts": 76,
"layoutDurationMs": 16.330000000000002,
"taskDurationMs": 478.038,
"heapDeltaBytes": -273400,
"heapUsedBytes": 48774892,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 220.92000000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661290322580644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 599.91500000001,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7240000000000001,
"layouts": 76,
"layoutDurationMs": 17.006,
"taskDurationMs": 564.929,
"heapDeltaBytes": 834032,
"heapUsedBytes": 49502056,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 272.23400000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 675.6379999999353,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.137,
"layouts": 76,
"layoutDurationMs": 16.915,
"taskDurationMs": 631.737,
"heapDeltaBytes": 1678188,
"heapUsedBytes": 107659180,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 254.251,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 655.516999999918,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.069,
"layouts": 76,
"layoutDurationMs": 20.168,
"taskDurationMs": 616.264,
"heapDeltaBytes": 31003784,
"heapUsedBytes": 108765104,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 247.656,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3239 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).
Pre-existing findings are baselined in Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 57aa9601ca4db33e4b12896464c88adea367af0a
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (394)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.60 #23372 +/- ##
===============================================
+ Coverage 59.33% 87.43% +28.10%
===============================================
Files 2356 3049 +693
Lines 103544 165142 +61598
Branches 0 44391 +44391
===============================================
+ Hits 61434 144391 +82957
+ Misses 42110 19818 -22292
- Partials 0 933 +933
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2694 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #22446, per the requested backport-only approval policy. Existing GitHub checks inspected; no tests run.
Backport of #22446 to
cloud/1.60Automatically created by backport workflow.