Repository navigation
refactor(billing): simplify handoff test lifecycle - #23361
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
⚡ Performance: ⏳ Performance tests in progress…🎭 Playwright: ✅ 3290 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 63172a33911d13eb12791031ca016708ea86251e
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (516)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed ac9cddf against its stacked base. No blocking findings; Gates 1–3 are not tripped by this behavior-preserving cleanup.
Confirmed shared setup owns disposal of its exact Pinia instance, while Desktop-session teardown and the explicit mid-test disposal regression remain. The Desktop marker now uses configured global restoration. Both live availability reads remain on either side of the settings await through toValue. The removed positive card/banner rows are covered by the existing served-status table and payment-link/failure-copy cases; unavailable regressions remain. The final diff preserves the component boundary and adds no UI or billing-policy change.
Validation: code, configuration, existing tests and discussion inspection only; no tests, builds or CI reruns were run, as requested. Refreshed head and discussion before posting. Current CI: 44 successful, 21 skipped, 1 neutral and 28 in progress; no failing check observed. Pending checks are not claimed as passed.
f49213c
into
1.61-billing-handoff/local-billing-tab
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## 1.61-billing-handoff/local-billing-tab #23361 +/- ##
==========================================================================
- Coverage 87.97% 87.89% -0.08%
==========================================================================
Files 3168 3054 -114
Lines 169439 165828 -3611
Branches 43919 44701 +782
==========================================================================
- Hits 149066 145757 -3309
+ Misses 19403 19269 -134
+ Partials 970 802 -168
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 115 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Follow-up to #23315, stacked so the original branch stays untouched. Fixes the retained test-lifecycle and cleanup findings without changing billing policy or the local handoff. I withdrew the component-inlining finding after the actual maintainability check rejected that change.
Rationale and review references
vi.stubGlobalsaves its previous descriptor, and the configuredunstubGlobalsrestores it. Keep the separate module-ref reset because global restoration does not own that state. Apply the same replacement to the billing-tab cases in the original PR. This is isolation cleanup, not a demonstrated production defect. Review references: setup, restoration.toValue, retaining both reads around the asynchronous settings request. My earlier direct.valuesuggestion failedno-unnecessary-condition: TypeScript retains the first property's narrowing acrossawait.toValuepermits the live re-read without a custom wrapper or suppression. Caching the first result would change behavior, so the existing switch-during-request case remains important. Review references: reads, getter.For future changes, identify lifecycle ownership before adding cleanup, preserve evaluation timing when removing aliases, and name the existing test that protects every deleted assertion. Judge an abstraction by the responsibility it hides. Distinguish demonstrated failures from maintenance costs and unverified hypotheses when assigning severity.
Verification
pnpm test:uniton the affected billing, host, feature-flag and BillingTab suites, with--retry=0 --no-fsModuleCache: 8 files passed, 382 tests passed on the final commit.The hosted recovery-route concern remains unverified and nonblocking. This follow-up changes no routing on that hypothesis.