Repository navigation
FRONT-3798 account-ui 1.0.0-alpha.1, account-core 1.0.0-alpha.7, ingest-types 1.6.0 - #23306
Conversation
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
📦 Bundle: 12.2 MB gzip 🔴 +260 BDetailsSummary
Category Glance App Entry Points — 7.06 kB (baseline 7.06 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.67 MB (baseline 3.67 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 2 unchanged Views & Navigation — 150 kB (baseline 150 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 5 unchanged Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 108 kB (baseline 108 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 12 added / 12 removed / 6 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 13 added / 13 removed / 6 unchanged UI Components — 368 kB (baseline 368 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed / 24 unchanged Data & Services — 2.02 MB (baseline 2.02 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 39 added / 39 removed / 8 unchanged Utilities & Hooks — 1.41 MB (baseline 1.41 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 40 added / 40 removed / 45 unchanged Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 35.8 MB (baseline 35.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 99 added / 99 removed / 665 unchanged ⚡ Performance: ⏳ Performance tests in progress…🔬 E2E Coverage: 🟡 58.9% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3290 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c49f918928fcd4c396f610138e9330ea0da590dd
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (502)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #23306 +/- ##
==========================================
+ Coverage 87.79% 87.84% +0.04%
==========================================
Files 3149 3150 +1
Lines 168644 168732 +88
Branches 43421 45478 +2057
==========================================
+ Hits 148060 148215 +155
+ Misses 19610 19545 -65
+ Partials 974 972 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 42 files with indirect coverage changes 🚀 New features to boost your workflow:
|
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 8c3e973 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Why
Platform's Billing page (FRONT-3801) needs the shared Billing tab sections from
@comfyorg/account-ui(BillingPlanRow,BillingCreditsCard,BillingAutoTopUpCard,BillingAutoTopUpMemberBlock,BillingBanner). They are not on npm:account-uihas only1.0.0-alpha.0(bothlatestandnext), published before the sections landed (FRONT-3796, FRONT-3797, FRONT-3799) and before the host-setup docs (#23118).Root cause
Nothing couples a package change to a version bump (ADR-RELEASES-PACKAGES-0033, Negative consequences). The section work merged without a release PR, so npm still serves the pre-section tarballs.
How
Version-bump release PR per ADR-RELEASES-PACKAGES-0033. The
Releaselabel publishes on merge throughpublish-package-on-merge.yaml:@comfyorg/account-ui1.0.0-alpha.0 → 1.0.0-alpha.1 (next)@comfyorg/account-core1.0.0-alpha.6 → 1.0.0-alpha.7 (next).account-uiresolves it asworkspace:^, so alpha.1 packs as^1.0.0-alpha.7. main's core has the section rules (FRONT-3796/3799) and auto top-up changes that alpha.6 lacks.@comfyorg/ingest-types1.5.0 → 1.6.0 (latest). main'saccount-core/account-uiimportzAcceptedAutoTopUpSettings,zAutoTopUpMemberView,zSubscriptionPaymentRecovery,AutoTopUpActivationandTopupAutoTopUpSettings, which the published 1.5.0 does not export. Publishing the core alone would fail at import, as in DPLAT-2852 account-core 1.0.0-alpha.6, ingest-types 1.5.0 #22883. No top-level export is removed since 1.5.0 (107 types / 71 schemas added). SomeCcc*content-catalog shapes changed, which nothing in billing reads. I chose minor; raise it to major if you read those as breaking.@comfyorg/billing-contractstays on 1.0.0-alpha.1: no changes since it was published.Verification on this branch:
ingest-types,account-coreandaccount-uibuild.checkPublishablepasses for all three (7 / 141 / 99 packed files).pnpm -C packages/account-core smoke:packpasses: tarballs install into a plain npm project, every entry imports under node, andtsc(nodenext, strict) resolves a type and a value from every entry.account-uialpha.1 exports the Billing tab sections from@comfyorg/account-ui/billing.AS IS / TO BE
Version bump only, no UI. The user-facing before/after belongs on the Platform integration PR (FRONT-3801).
Plan position