Repository navigation
[backport cloud/1.60] BE-25875 fix(billing): offer Pay instead of charging when returning from the card portal - #23288
Conversation
…rom the card portal (#23285) ## Summary Returning to the top-up dialog after **Set a default card** charged the customer again without a click. This PR makes the return show **Pay $X** instead; the charge only happens on click. - Linear: [BE-25875](https://linear.app/comfyorg/issue/BE-25875/bug-top-up-credited-twice-second-identical-invoice-appeared-87-minutes) - Report: https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1794340989785819 - Root-cause write-up: https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1794435442487859?thread_ts=1794340989.785819&cid=C0A4XMHANP3 ## Why A customer was charged $500 twice on 2026-11-10, 87 minutes apart. The second charge was sent by a dialog they had left open in another tab, the moment they returned to that tab. This code is live in cloud 1.59.8 and 1.60.0, so anyone who follows the same path can be double charged. ## Root cause #21694 added `armPayRetryOnCardReturn`. After a `NO_PAYMENT_METHOD` refusal, **Set a default card** opens the Stripe portal in a new tab and arms a `registerRefreshOnReturn` callback that calls `handleBuy()` on the next focus of the original tab. That callback: - never expires (`registerRefreshOnReturn` starts with `away = true`, so the first return at any later time fires it), - does not know whether a purchase already went through in another tab, - charges without asking. The incident, reconstructed from Datadog logs/APM/RUM and PostHog: | UTC 11-10 | Window | What happened | |---|---|---| | 18:23:00 | A | Pay $500 → 400 `NO_PAYMENT_METHOD`; **Set a default card** opens portal tab B, retry armed in A | | 18:26:04 | B | Portal returned to the app; customer clicked Pay $500 → op `7bfd6443` (first charge) | | 18:33:19 | B | Auto top-up turned on (settings only, no charge) | | 19:52:52 | A | Customer focused window A → `billing.topup.started` 50000 from the same PostHog `$window_id` as the 18:23 attempt, together with the return refresh reads → op `60392c6b` (second charge) | Two separate `TopUpWorkflow` ops, each from a browser `POST /api/billing/topup`. The backend accepted the second one because every client key is a new purchase. A server-side duplicate window was proposed separately in the thread. ## How `offerPayOnCardReturn` replaces `armPayRetryOnCardReturn`. On return it only clears `checkoutRecovery`, so the confirm step shows the **Pay $X** button for the confirmed amount. Nothing is charged until the customer clicks it. If the card still isn't set, that click is refused again and the dialog shows the refusal and **Set a default card**, as before. `armPayRetryAfterNextDeparture` existed only to re-arm the automatic retry, so it is deleted. Kept: the return is still ignored after Back, after a workspace switch, and after unmount. ## AS IS / TO BE AS IS (`48854793e6`): returning to the original tab sends `POST /api/billing/topup` with no click; the mocked charge completes and the dialog closes to Settings with "Credits added successfully!". <img width="720" alt="AS IS" src="https://gist.githubusercontent.com/dante01yoon/09f00b000df208750b656a8a2fce525d/raw/86332caeac761d74ddbc9dbacf05c6f8310f39b3/pr23285-as-is.png" /> Network: 1 `POST /api/billing/topup` on return (log line 3), with no click. TO BE (`e48a1b4893`): returning shows **Pay $50.00**; no top-up request until Pay is clicked. <img width="720" alt="TO BE" src="https://gist.githubusercontent.com/dante01yoon/09f00b000df208750b656a8a2fce525d/raw/86332caeac761d74ddbc9dbacf05c6f8310f39b3/pr23285-to-be.png" /> Network: 0 `POST /api/billing/topup` on return; the only later POST (grey line 3) is from clicking Pay. ## Dependency graph ```mermaid graph LR main --> this["BE-25875 no auto Pay on card return (this PR)"] this --> bp160["backport cloud/1.60 + core/1.60"] style this fill:#f9d71c ``` ## Verification - `pnpm exec vitest run src/platform/billing/components/TopUpCreditsDialogContentWorkspace.test.ts`: 128/128. - The test commit lands first and fails on the old code (3 tests: re-send on return, repeated returns, blocked-link return). The fix commit turns them green. - New contract tests: - Returning shows Pay without charging, and clicking Pay charges once. - Repeated blur/focus never charges. - Following the blocked portal link and returning does not charge. - Pay after the portal with still no card shows the refusal again. - A third commit strengthens the stale-tab test: both return signals (focus and visibilitychange), settling between returns, and no hosted checkout either. It fails 3 tests on the pre-fix code and passes all 128 on the fix. - AS IS / TO BE above were captured in the real app built from each commit (`@cloud` Playwright, mocked billing responses, backend proxy pointed at a dead port so nothing real could be charged). Not run against testcloud. - Independent review (Astra): no remaining path where a tab return, timer or watcher can start a purchase; `handleBuy()` is reachable only from the Pay click.
⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-11T23:16:52.334Z",
"gitSha": "7be37ac2b5242d7611989e70649a478a9f086452",
"branch": "backport-23285-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.3280000000059,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1130000000000004,
"layouts": 10,
"layoutDurationMs": 2.6820000000000004,
"taskDurationMs": 373.928,
"heapDeltaBytes": 16916,
"heapUsedBytes": 77193524,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.055000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2022.1779999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.183,
"layouts": 10,
"layoutDurationMs": 2.74,
"taskDurationMs": 457.68699999999995,
"heapDeltaBytes": 2767400,
"heapUsedBytes": 64181424,
"domNodes": -178,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.821,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.939999999993,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.15,
"layouts": 9,
"layoutDurationMs": 1.981,
"taskDurationMs": 590.469,
"heapDeltaBytes": -18778716,
"heapUsedBytes": 59465400,
"domNodes": -178,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 102.18,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.65000000002,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.577,
"layouts": 10,
"layoutDurationMs": 2.556,
"taskDurationMs": 722.5849999999999,
"heapDeltaBytes": -15770584,
"heapUsedBytes": 62577148,
"domNodes": -178,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 119.44600000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.5289999999993,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.32,
"layouts": 12,
"layoutDurationMs": 2.742,
"taskDurationMs": 249.666,
"heapDeltaBytes": 9481648,
"heapUsedBytes": 83910628,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.203999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.6510000000221,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.342,
"layouts": 12,
"layoutDurationMs": 3.207,
"taskDurationMs": 323.227,
"heapDeltaBytes": 25538984,
"heapUsedBytes": 85722320,
"domNodes": 57,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 14.652999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 516.728999999998,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.472,
"layouts": 9,
"layoutDurationMs": 2.06,
"taskDurationMs": 351.087,
"heapDeltaBytes": 6254612,
"heapUsedBytes": 67640948,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 112.70700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 530.9749999999553,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2939999999999996,
"layouts": 10,
"layoutDurationMs": 2.713,
"taskDurationMs": 353.182,
"heapDeltaBytes": -15294400,
"heapUsedBytes": 62808508,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 111.278,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 877.5579999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.093,
"heapDeltaBytes": -6767952,
"heapUsedBytes": 78141092,
"domNodes": -208,
"jsHeapTotalBytes": 15998976,
"scriptDurationMs": 31.509999999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 245,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 908.8550000000168,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.807,
"heapDeltaBytes": -7425572,
"heapUsedBytes": 78280716,
"domNodes": -208,
"jsHeapTotalBytes": 17047552,
"scriptDurationMs": 37.662,
"eventListeners": -107,
"totalBlockingTimeMs": 271,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 753.4490000000176,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.7590000000001,
"heapDeltaBytes": -17157540,
"heapUsedBytes": 70166376,
"domNodes": -208,
"jsHeapTotalBytes": 1966080,
"scriptDurationMs": 95.73700000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.27027027027027,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.7400000000193,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.7619999999996,
"heapDeltaBytes": -2432936,
"heapUsedBytes": 69837984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.35400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 80,
"frameDurationMs": 20.100000000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6390.2140000000145,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7200000000000002,
"layouts": 3,
"layoutDurationMs": 0.6519999999999998,
"taskDurationMs": 5288.320000000001,
"heapDeltaBytes": 55444252,
"heapUsedBytes": 131429664,
"domNodes": -274,
"jsHeapTotalBytes": 49934336,
"scriptDurationMs": 3922.304,
"eventListeners": -69,
"totalBlockingTimeMs": 25,
"frameDurationMs": 19.16077844311377,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6176.537999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7569999999999999,
"layouts": 3,
"layoutDurationMs": 0.6940000000000002,
"taskDurationMs": 5203.978,
"heapDeltaBytes": 48276444,
"heapUsedBytes": 125561412,
"domNodes": -274,
"jsHeapTotalBytes": 55701504,
"scriptDurationMs": 3905.214,
"eventListeners": -69,
"totalBlockingTimeMs": 8,
"frameDurationMs": 18.62379518072289,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6484.873999999991,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3959999999999997,
"layouts": 5,
"layoutDurationMs": 1.2100000000000002,
"taskDurationMs": 5552.796,
"heapDeltaBytes": 67901720,
"heapUsedBytes": 146021724,
"domNodes": -274,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 4167.579,
"eventListeners": -69,
"totalBlockingTimeMs": 64,
"frameDurationMs": 19.46876876876877,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6374.897999999974,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2699999999999994,
"layouts": 4,
"layoutDurationMs": 1.0339999999999998,
"taskDurationMs": 5366.627,
"heapDeltaBytes": 43117608,
"heapUsedBytes": 121164808,
"domNodes": -274,
"jsHeapTotalBytes": 52555776,
"scriptDurationMs": 4068.7679999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.40151975683891,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 150.9630000000186,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.869999999999997,
"layouts": 11,
"layoutDurationMs": 2.7529999999999997,
"taskDurationMs": 102.03,
"heapDeltaBytes": 14743780,
"heapUsedBytes": 92077604,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.671000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 135.57400000001962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.678999999999998,
"layouts": 11,
"layoutDurationMs": 2.6510000000000002,
"taskDurationMs": 99.584,
"heapDeltaBytes": 14809304,
"heapUsedBytes": 91541972,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.959,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.5479999999864,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9060000000000006,
"layouts": 9,
"layoutDurationMs": 1.785,
"taskDurationMs": 424.58700000000005,
"heapDeltaBytes": -29934644,
"heapUsedBytes": 60510972,
"domNodes": -274,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 25.642000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2023.9389999999844,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9140000000000006,
"layouts": 9,
"layoutDurationMs": 2.5869999999999997,
"taskDurationMs": 522.02,
"heapDeltaBytes": -5451092,
"heapUsedBytes": 84302268,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 29.308,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2399.1870000000117,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.104000000000003,
"layouts": 8,
"layoutDurationMs": 1.8690000000000002,
"taskDurationMs": 1190.929,
"heapDeltaBytes": -13686616,
"heapUsedBytes": 78057304,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 591.5389999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666433566433565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2886.6270000000327,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.727000000000002,
"layouts": 9,
"layoutDurationMs": 2.971,
"taskDurationMs": 1376.512,
"heapDeltaBytes": -5700796,
"heapUsedBytes": 78490848,
"domNodes": -274,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 635.3829999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3450.1520000000028,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.562000000000001,
"layouts": 66,
"layoutDurationMs": 10.989,
"taskDurationMs": 1222.896,
"heapDeltaBytes": -11911188,
"heapUsedBytes": 61730440,
"domNodes": -250,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 524.5649999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618357487923,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3606.7899999999895,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.402000000000003,
"layouts": 67,
"layoutDurationMs": 11.988,
"taskDurationMs": 1305.5710000000001,
"heapDeltaBytes": -13931496,
"heapUsedBytes": 71316204,
"domNodes": -250,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 547.8059999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2500.7400000000075,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.006000000000001,
"layouts": 8,
"layoutDurationMs": 1.9720000000000002,
"taskDurationMs": 1288.032,
"heapDeltaBytes": -9889160,
"heapUsedBytes": 77382024,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 632.2769999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2871.032000000014,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.3839999999999995,
"layouts": 8,
"layoutDurationMs": 1.8380000000000003,
"taskDurationMs": 1389.605,
"heapDeltaBytes": -5047896,
"heapUsedBytes": 81638184,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 680.959,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589595375723,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2867.151000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9100000000000001,
"layouts": 8,
"layoutDurationMs": 1.705,
"taskDurationMs": 555.148,
"heapDeltaBytes": -16193384,
"heapUsedBytes": 67509880,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 252.76100000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767437,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2789.8850000000266,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3609999999999993,
"layouts": 9,
"layoutDurationMs": 2.0860000000000003,
"taskDurationMs": 504.93199999999996,
"heapDeltaBytes": -5586580,
"heapUsedBytes": 80953636,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 226.498,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2020.0330000000122,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.005,
"layouts": 9,
"layoutDurationMs": 1.867,
"taskDurationMs": 401.04200000000003,
"heapDeltaBytes": -14275040,
"heapUsedBytes": 72591240,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 25.691000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2019.2759999999907,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.626,
"layouts": 9,
"layoutDurationMs": 1.623,
"taskDurationMs": 393.75000000000006,
"heapDeltaBytes": 6738116,
"heapUsedBytes": 82650404,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 22.38,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2698.5059999999803,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.232999999999999,
"layouts": 7,
"layoutDurationMs": 1.742,
"taskDurationMs": 400.81399999999996,
"heapDeltaBytes": -23010396,
"heapUsedBytes": 61178276,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 119.013,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66645962732919,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2678.8549999999987,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.459,
"layouts": 8,
"layoutDurationMs": 1.562,
"taskDurationMs": 373.946,
"heapDeltaBytes": 7987424,
"heapUsedBytes": 90979560,
"domNodes": 19,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 129.261,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2888.788000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9030000000000002,
"layouts": 8,
"layoutDurationMs": 1.7200000000000002,
"taskDurationMs": 574.071,
"heapDeltaBytes": -8560904,
"heapUsedBytes": 82989424,
"domNodes": 0,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 227.86800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2885.6850000000236,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6379999999999997,
"layouts": 7,
"layoutDurationMs": 1.509,
"taskDurationMs": 596.414,
"heapDeltaBytes": -17987468,
"heapUsedBytes": 60976192,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 224.057,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 412.62899999998126,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.881,
"layouts": 10,
"layoutDurationMs": 2.2489999999999997,
"taskDurationMs": 281.013,
"heapDeltaBytes": 24420604,
"heapUsedBytes": 87661128,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 93.592,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.1919999999523,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.859000000000001,
"layouts": 10,
"layoutDurationMs": 2.585,
"taskDurationMs": 334.167,
"heapDeltaBytes": 24948668,
"heapUsedBytes": 88975024,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 107.251,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2037.1450000000095,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1860000000000004,
"layouts": 10,
"layoutDurationMs": 1.9440000000000002,
"taskDurationMs": 348.658,
"heapDeltaBytes": -8439160,
"heapUsedBytes": 53710560,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 5.770999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2025.7850000000417,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8240000000000003,
"layouts": 9,
"layoutDurationMs": 2.538,
"taskDurationMs": 458.6940000000001,
"heapDeltaBytes": 10121384,
"heapUsedBytes": 72367136,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.034999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.6960000000029,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.875999999999998,
"layouts": 11,
"layoutDurationMs": 2.406,
"taskDurationMs": 577.641,
"heapDeltaBytes": -10482556,
"heapUsedBytes": 52319380,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 77.49600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.836999999984,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.17,
"layouts": 8,
"layoutDurationMs": 2.0290000000000004,
"taskDurationMs": 720.332,
"heapDeltaBytes": -4384112,
"heapUsedBytes": 59076788,
"domNodes": -192,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 100.617,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 939.6429999999896,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.738999999999999,
"layouts": 5,
"layoutDurationMs": 11.156,
"taskDurationMs": 788.0239999999999,
"heapDeltaBytes": -12679664,
"heapUsedBytes": 84223024,
"domNodes": -1320,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 38.076,
"eventListeners": -262,
"totalBlockingTimeMs": 82,
"frameDurationMs": 19.387755102040824,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8405.01900000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.643,
"layouts": 10,
"layoutDurationMs": 2.384,
"taskDurationMs": 4011.1600000000003,
"heapDeltaBytes": -25497560,
"heapUsedBytes": 64246644,
"domNodes": -274,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 1878.025,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665940594059403,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9067.875000000015,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.379999999999995,
"layouts": 9,
"layoutDurationMs": 2.215,
"taskDurationMs": 4402.565999999999,
"heapDeltaBytes": 7445400,
"heapUsedBytes": 88793524,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 1964.008,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665871559633025,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16815.418000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16035.026000000002,
"heapDeltaBytes": 4214452,
"heapUsedBytes": 293850880,
"domNodes": -3482,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 212.19,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.24521739130434,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "vue-large-graph-idle",
"durationMs": 16423.48099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15550.099,
"heapDeltaBytes": -26253364,
"heapUsedBytes": 276936944,
"domNodes": -3482,
"jsHeapTotalBytes": 10993664,
"scriptDurationMs": 192.87199999999999,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.946768707482995,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19611.59600000002,
"styleRecalcs": 148,
"styleRecalcDurationMs": 18.640000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19249.878,
"heapDeltaBytes": -15629596,
"heapUsedBytes": 275150600,
"domNodes": -3482,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 662.255,
"eventListeners": -659,
"totalBlockingTimeMs": 25,
"frameDurationMs": 35.93119266055046,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19236.28299999996,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.285000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18913.141000000003,
"heapDeltaBytes": -35721980,
"heapUsedBytes": 262176456,
"domNodes": -3482,
"jsHeapTotalBytes": 15712256,
"scriptDurationMs": 625.294,
"eventListeners": -659,
"totalBlockingTimeMs": 5,
"frameDurationMs": 35.38858195211786,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6124.522000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.150999999999996,
"layouts": 20,
"layoutDurationMs": 21.835000000000008,
"taskDurationMs": 5982.46,
"heapDeltaBytes": -21371224,
"heapUsedBytes": 282543796,
"domNodes": -3482,
"jsHeapTotalBytes": 30920704,
"scriptDurationMs": 87.032,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.077058823529406,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6003.031999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 39.70300000000002,
"layouts": 20,
"layoutDurationMs": 20.111000000000004,
"taskDurationMs": 5871.777999999999,
"heapDeltaBytes": 13329916,
"heapUsedBytes": 297587836,
"domNodes": -3482,
"jsHeapTotalBytes": 35377152,
"scriptDurationMs": 83.11200000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.57701149425287,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8457.872000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8068.159,
"heapDeltaBytes": -28622152,
"heapUsedBytes": 260217656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.52700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.64271186440678,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7631.77799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7239.151,
"heapDeltaBytes": -27728152,
"heapUsedBytes": 272316032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.90700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.76169491525424,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 88.92399999996314,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.266,
"layouts": 5,
"layoutDurationMs": 1.8609999999999998,
"taskDurationMs": 64.639,
"heapDeltaBytes": -14202104,
"heapUsedBytes": 62047592,
"domNodes": 128,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5.647,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 447.43000000005395,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.008999999999999,
"layouts": 11,
"layoutDurationMs": 2.549,
"taskDurationMs": 84.415,
"heapDeltaBytes": -10551208,
"heapUsedBytes": 65420564,
"domNodes": 99,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.016,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 205.98499999994146,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5680000000000001,
"layouts": 76,
"layoutDurationMs": 9.906,
"taskDurationMs": 172.911,
"heapDeltaBytes": -6141832,
"heapUsedBytes": 37323236,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 71.38799999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538456,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 213.5879999999588,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.562,
"layouts": 76,
"layoutDurationMs": 9.82,
"taskDurationMs": 170.83399999999997,
"heapDeltaBytes": -6150748,
"heapUsedBytes": 37881228,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 69.15,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 242.60599999990973,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2650000000000001,
"layouts": 76,
"layoutDurationMs": 10.295,
"taskDurationMs": 217.57600000000002,
"heapDeltaBytes": -1337064,
"heapUsedBytes": 96565016,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 71.115,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 239.49599999991733,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1640000000000001,
"layouts": 76,
"layoutDurationMs": 9.018999999999998,
"taskDurationMs": 200.65800000000002,
"heapDeltaBytes": -1731808,
"heapUsedBytes": 93355632,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 63.602000000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999975,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 58.4% of linesNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison. Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3238 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e40e965ba5b981344f0d15b5297c75806b625b4b
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (394)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #23288 +/- ##
===============================================
+ Coverage 59.33% 87.39% +28.06%
===============================================
Files 2356 2924 +568
Lines 103544 161155 +57611
Branches 0 40771 +40771
===============================================
+ Hits 61434 140845 +79411
+ Misses 42110 19546 -22564
- Partials 0 764 +764
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2576 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as requested for this backport of #23285. No additional code review or tests were run. Existing CI reports a failing Chromium shard (7/16) and e2e-status; these were not rerun.
Backport of #23285 to
cloud/1.60Automatically created by backport workflow.