Repository navigation
[backport cloud/1.60] feat: relay a Desktop workflow to Comfy Cloud through the system browser (#23075) - #23211
Conversation
…hrough the system browser (#23075) <p align="center"><img src="https://github.com/user-attachments/assets/52ed1614-2450-45dc-8fd7-ce500e597097" alt="J5 to J8 Desktop relay flow" width="720"></p> Four commits: - **J5, Desktop relay to sign-in.** Desktop cannot hand a workflow to a browser tab by `postMessage`, so it stages a one-time userdata record and opens a local relay link in the system browser. Before the app boots, the relay reads and deletes the record and forwards to Comfy Cloud. If staging fails, Desktop downloads the workflow instead. An ordinary boot does no relay I/O. (A failed relay stays on the splash until J6.) - **J6, relay record missing.** A missing, refused or unreachable record replaces the splash with guidance to click Open on Comfy Cloud in Desktop again. - **J7, relay record expired.** A record past its ten-minute lifetime is refused with the same guidance. - **J8, native Desktop to Cloud import.** Cloud takes the workflow out of the relay URL hash before boot, keeps it in sessionStorage through sign-in, and imports it once with no opener window. With the flag off a captured transfer is discarded. <details open><summary><b>J5 · Desktop relay → sign-in</b></summary> **1.** Real userdata GET 200 and DELETE 204; navigation shown.<br> <img src="https://github.com/user-attachments/assets/293657a0-6048-45de-b77a-85ad46e86efb" alt="J5 · Desktop relay → sign-in, step 1" width="640"> **2.** Real Cloud sign-in reached; consumed record rereads 404.<br> <img src="https://github.com/user-attachments/assets/145dafbe-b223-43b1-9ffc-7e526b667c34" alt="J5 · Desktop relay → sign-in, step 2" width="640"> </details> <details open><summary><b>J6 · Relay record missing</b></summary> **1.** Relay URL with a missing record; loading shown.<br> <img src="https://github.com/user-attachments/assets/c7dca48e-6126-4738-8b67-a2de3a11b3c2" alt="J6 · Relay record missing, step 1" width="640"> **2.** Retry guidance shown; stays on localhost.<br> <img src="https://github.com/user-attachments/assets/0c31f687-0097-4f4c-b379-b9a0d721aaad" alt="J6 · Relay record missing, step 2" width="640"> </details> <details open><summary><b>J7 · Relay record expired</b></summary> **1.** Relay URL with an expired record; loading shown.<br> <img src="https://github.com/user-attachments/assets/eebbacb2-5916-467f-a371-f4e789b4edb1" alt="J7 · Relay record expired, step 1" width="640"> **2.** Retry guidance shown; stays on localhost.<br> <img src="https://github.com/user-attachments/assets/56bac562-e15a-421b-a82b-73a2385803f2" alt="J7 · Relay record expired, step 2" width="640"> </details> <details open><summary><b>J8 · Native Desktop → Cloud import</b></summary> **1.** Official Desktop loads 256×256 EmptyImage → SaveImage.<br> <img src="https://github.com/user-attachments/assets/f6c8fbdc-0e5c-47d2-b458-b4d28b9e6ce9" alt="J8 · Native Desktop → Cloud import, step 1" width="640"> **2.** Real compatibility passes; Open on Comfy Cloud shown.<br> <img src="https://github.com/user-attachments/assets/08dc2efb-b8f9-4d83-b6ec-b18c46ee5f42" alt="J8 · Native Desktop → Cloud import, step 2" width="640"> **3.** Native browser handoff carries the real workflow.<br> <img src="https://github.com/user-attachments/assets/c44ca36d-6848-4845-86fe-9ef2095d767f" alt="J8 · Native Desktop → Cloud import, step 3" width="640"> **4.** Cloud auto-imports nodes, dimensions and prefix; payload and nonce cleared.<br> <img src="https://github.com/user-attachments/assets/b23773cc-a560-47d1-8272-489a4d81e582" alt="J8 · Native Desktop → Cloud import, step 4" width="640"> </details> 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: huang47 <157390+huang47@users.noreply.github.com> Adapted for cloud/1.60: billingTab.ts takes this change as written, so handsPopupsToSystemBrowser moves to desktopBrowser; AddCreditsDialogContent.vue stays deleted, as it is on this branch. (cherry picked from commit 05821fe)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-10T16:23:32.273Z",
"gitSha": "2bd502d89dd526582b936fa3e6300ffea59f55b1",
"branch": "backport-23075-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.658999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.68,
"layouts": 10,
"layoutDurationMs": 2.8749999999999996,
"taskDurationMs": 567.831,
"heapDeltaBytes": -5399952,
"heapUsedBytes": 63538860,
"domNodes": -178,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8.146,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2007.7979999999798,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.743,
"layouts": 9,
"layoutDurationMs": 2.659,
"taskDurationMs": 565.354,
"heapDeltaBytes": -12008764,
"heapUsedBytes": 65358696,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.916999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.8449999999884,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.546000000000001,
"layouts": 10,
"layoutDurationMs": 2.7390000000000003,
"taskDurationMs": 916.416,
"heapDeltaBytes": 34896,
"heapUsedBytes": 72983788,
"domNodes": -178,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 155.945,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.1049999999386,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.87,
"layouts": 9,
"layoutDurationMs": 2.608,
"taskDurationMs": 974.271,
"heapDeltaBytes": -6595704,
"heapUsedBytes": 66992316,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 164.83100000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.9570000000413,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.8229999999999995,
"layouts": 11,
"layoutDurationMs": 2.814,
"taskDurationMs": 406.46000000000004,
"heapDeltaBytes": 12091624,
"heapUsedBytes": 85302480,
"domNodes": 57,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.881000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.100999999915,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.882999999999999,
"layouts": 13,
"layoutDurationMs": 3.7870000000000004,
"taskDurationMs": 438.565,
"heapDeltaBytes": 8164048,
"heapUsedBytes": 84363848,
"domNodes": 57,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 11.816,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.1620000000098,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3460000000000005,
"layouts": 9,
"layoutDurationMs": 2.3819999999999997,
"taskDurationMs": 504.09900000000005,
"heapDeltaBytes": 1802764,
"heapUsedBytes": 62312832,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 170.88699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 726.7200000000003,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.0549999999999997,
"layouts": 11,
"layoutDurationMs": 2.84,
"taskDurationMs": 517.519,
"heapDeltaBytes": -11000192,
"heapUsedBytes": 62471656,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 169.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046512,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.524999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 820.4,
"heapDeltaBytes": 19092364,
"heapUsedBytes": 82616012,
"domNodes": 0,
"jsHeapTotalBytes": 13271040,
"scriptDurationMs": 67.705,
"eventListeners": 0,
"totalBlockingTimeMs": 512,
"frameDurationMs": 33.82352941176472,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1170.4059999999572,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 849.153,
"heapDeltaBytes": 22915844,
"heapUsedBytes": 88567860,
"domNodes": 0,
"jsHeapTotalBytes": 12484608,
"scriptDurationMs": 64.66199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 538,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.9909999999891,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.4989999999998,
"heapDeltaBytes": -1349336,
"heapUsedBytes": 73998060,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.87099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.7580000000798,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.5430000000002,
"heapDeltaBytes": -4116920,
"heapUsedBytes": 86791848,
"domNodes": 0,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 169.933,
"eventListeners": 0,
"totalBlockingTimeMs": 243,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11810.490000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10951.098,
"heapDeltaBytes": 77902144,
"heapUsedBytes": 172526336,
"domNodes": -274,
"jsHeapTotalBytes": 82440192,
"scriptDurationMs": 8889.066,
"eventListeners": -69,
"totalBlockingTimeMs": 1673,
"frameDurationMs": 32.776388888888896,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10364.588000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9563.5,
"heapDeltaBytes": 63779604,
"heapUsedBytes": 138554168,
"domNodes": -274,
"jsHeapTotalBytes": 70905856,
"scriptDurationMs": 7639.99,
"eventListeners": -69,
"totalBlockingTimeMs": 896,
"frameDurationMs": 31.130030030030028,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9926.446999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.21900000000000044,
"layouts": 1,
"layoutDurationMs": 0.18199999999999988,
"taskDurationMs": 9166.342,
"heapDeltaBytes": 44473592,
"heapUsedBytes": 127936888,
"domNodes": -274,
"jsHeapTotalBytes": 60157952,
"scriptDurationMs": 7262.492,
"eventListeners": -69,
"totalBlockingTimeMs": 653,
"frameDurationMs": 31.235534591194966,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10109.439000000066,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.27699999999999947,
"layouts": 1,
"layoutDurationMs": 0.3059999999999998,
"taskDurationMs": 9389.9,
"heapDeltaBytes": 61047184,
"heapUsedBytes": 136512884,
"domNodes": -274,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 7467.268,
"eventListeners": -69,
"totalBlockingTimeMs": 738,
"frameDurationMs": 31.51495327102804,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 222.974000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.988,
"layouts": 7,
"layoutDurationMs": 2.7070000000000003,
"taskDurationMs": 169.42200000000003,
"heapDeltaBytes": 14910092,
"heapUsedBytes": 73493660,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.806999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.19999999999982
},
{
"name": "large-combo-open",
"durationMs": 237.01499999992848,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.406,
"layouts": 6,
"layoutDurationMs": 2.289,
"taskDurationMs": 178.58400000000003,
"heapDeltaBytes": 14946808,
"heapUsedBytes": 78982592,
"domNodes": 759,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.871000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.34000000000001,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2041.072999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9370000000000003,
"layouts": 7,
"layoutDurationMs": 2.087,
"taskDurationMs": 639.116,
"heapDeltaBytes": 7125712,
"heapUsedBytes": 81132576,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.382999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.567999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0109999999999997,
"layouts": 8,
"layoutDurationMs": 2.748,
"taskDurationMs": 718.2249999999999,
"heapDeltaBytes": 6685292,
"heapUsedBytes": 81086124,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 32.199000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2599.9669999999924,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.534,
"layouts": 6,
"layoutDurationMs": 1.505,
"taskDurationMs": 1785.35,
"heapDeltaBytes": 4355316,
"heapUsedBytes": 80106252,
"domNodes": -274,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 895.127,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773548387096774,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2955.6179999999586,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.909,
"layouts": 7,
"layoutDurationMs": 2.3449999999999998,
"taskDurationMs": 1826.6380000000001,
"heapDeltaBytes": -22616116,
"heapUsedBytes": 61287108,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 850.03,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3801.468,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.102,
"layouts": 64,
"layoutDurationMs": 9.597,
"taskDurationMs": 1833.4740000000002,
"heapDeltaBytes": 4204300,
"heapUsedBytes": 81524744,
"domNodes": -250,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 808.612,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3880.486000000019,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.457,
"layouts": 65,
"layoutDurationMs": 11.043,
"taskDurationMs": 1855.7289999999998,
"heapDeltaBytes": 1072880,
"heapUsedBytes": 85893764,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 792.142,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656652360515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3146.568000000002,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.433000000000001,
"layouts": 5,
"layoutDurationMs": 1.136,
"taskDurationMs": 1970.3129999999999,
"heapDeltaBytes": -6337644,
"heapUsedBytes": 71787792,
"domNodes": 0,
"jsHeapTotalBytes": 6905856,
"scriptDurationMs": 988.7459999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.021925133689837,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3186.584000000039,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.882000000000001,
"layouts": 5,
"layoutDurationMs": 1.4270000000000003,
"taskDurationMs": 2053.854,
"heapDeltaBytes": -472632,
"heapUsedBytes": 72771724,
"domNodes": 0,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 1008.356,
"eventListeners": 182,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.020744680851063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3087.6420000000167,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7070000000000003,
"layouts": 7,
"layoutDurationMs": 1.352,
"taskDurationMs": 775.204,
"heapDeltaBytes": -14591532,
"heapUsedBytes": 70915396,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 362.311,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3086.2640000000283,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6820000000000004,
"layouts": 7,
"layoutDurationMs": 1.5510000000000004,
"taskDurationMs": 783.694,
"heapDeltaBytes": -20068316,
"heapUsedBytes": 64087076,
"domNodes": -274,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 359.745,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.8010000000163,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9040000000000004,
"layouts": 7,
"layoutDurationMs": 1.8,
"taskDurationMs": 647.7290000000002,
"heapDeltaBytes": -25067264,
"heapUsedBytes": 60066012,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.474999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2047.4080000000185,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.249,
"layouts": 8,
"layoutDurationMs": 2.1209999999999996,
"taskDurationMs": 689.076,
"heapDeltaBytes": -18966560,
"heapUsedBytes": 66765080,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 32.471,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2911.160000000052,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.88,
"layouts": 7,
"layoutDurationMs": 1.6710000000000003,
"taskDurationMs": 612.0490000000001,
"heapDeltaBytes": -5260648,
"heapUsedBytes": 67455964,
"domNodes": -259,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 189.299,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285713,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2755.0679999999375,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.379,
"layouts": 7,
"layoutDurationMs": 1.7370000000000003,
"taskDurationMs": 590.054,
"heapDeltaBytes": 9803120,
"heapUsedBytes": 84586036,
"domNodes": -255,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 184.81799999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3327.056999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8159999999999998,
"layouts": 7,
"layoutDurationMs": 1.697,
"taskDurationMs": 952.198,
"heapDeltaBytes": 7093284,
"heapUsedBytes": 90160380,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 388.081,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3288.7190000000146,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7689999999999997,
"layouts": 7,
"layoutDurationMs": 1.6789999999999998,
"taskDurationMs": 899.9140000000001,
"heapDeltaBytes": -8112200,
"heapUsedBytes": 77263308,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 365.32899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598984771574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.6650000000027,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.542000000000001,
"layouts": 10,
"layoutDurationMs": 2.6319999999999997,
"taskDurationMs": 444.66099999999994,
"heapDeltaBytes": 10713516,
"heapUsedBytes": 85668100,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 142.841,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.4759999999833,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.879,
"layouts": 10,
"layoutDurationMs": 2.5680000000000005,
"taskDurationMs": 466.14,
"heapDeltaBytes": 11077180,
"heapUsedBytes": 86242140,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 147.49699999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2024.517000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3680000000000003,
"layouts": 9,
"layoutDurationMs": 2.3680000000000003,
"taskDurationMs": 549.1080000000001,
"heapDeltaBytes": -6206884,
"heapUsedBytes": 55404396,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 6.914999999999997,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.4660000000613,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.005,
"layouts": 10,
"layoutDurationMs": 2.746,
"taskDurationMs": 598.5840000000001,
"heapDeltaBytes": -118916,
"heapUsedBytes": 75445412,
"domNodes": -200,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 9.415000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.496000000021,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.393,
"layouts": 9,
"layoutDurationMs": 2.0140000000000002,
"taskDurationMs": 827.986,
"heapDeltaBytes": 10707452,
"heapUsedBytes": 72622840,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 103.51299999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.7819999999756,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.364000000000003,
"layouts": 9,
"layoutDurationMs": 2.1820000000000004,
"taskDurationMs": 874.942,
"heapDeltaBytes": 4616596,
"heapUsedBytes": 80126152,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 111.484,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1587.4079999999822,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.313000000000002,
"layouts": 5,
"layoutDurationMs": 19.409999999999997,
"taskDurationMs": 1314.479,
"heapDeltaBytes": 4359788,
"heapUsedBytes": 89956524,
"domNodes": -1320,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 31.478999999999992,
"eventListeners": -262,
"totalBlockingTimeMs": 201,
"frameDurationMs": 20.511538461538457,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 9632.096999999987,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.064,
"layouts": 8,
"layoutDurationMs": 1.807,
"taskDurationMs": 6000.669,
"heapDeltaBytes": 10782212,
"heapUsedBytes": 84850512,
"domNodes": -274,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2689.783,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666089965397926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9458.04099999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.148000000000003,
"layouts": 8,
"layoutDurationMs": 2.006,
"taskDurationMs": 6083.7789999999995,
"heapDeltaBytes": -18715968,
"heapUsedBytes": 63685984,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2773.244,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695406360424027,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23406.094999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22959.267,
"heapDeltaBytes": -22412112,
"heapUsedBytes": 287691396,
"domNodes": -3482,
"jsHeapTotalBytes": 9158656,
"scriptDurationMs": 300.83,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.06695205479452,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23383.734000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22892.422,
"heapDeltaBytes": -21614736,
"heapUsedBytes": 289203524,
"domNodes": -3482,
"jsHeapTotalBytes": 10207232,
"scriptDurationMs": 306.889,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.355267702936096,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28338.774999999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.43800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27955.328999999998,
"heapDeltaBytes": -11026112,
"heapUsedBytes": 273010776,
"domNodes": -3482,
"jsHeapTotalBytes": 13877248,
"scriptDurationMs": 921.4149999999998,
"eventListeners": -659,
"totalBlockingTimeMs": 27,
"frameDurationMs": 52.85858208955224,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28566.737999999987,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.101000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28172.697999999997,
"heapDeltaBytes": -48025036,
"heapUsedBytes": 242134168,
"domNodes": -3482,
"jsHeapTotalBytes": -6307840,
"scriptDurationMs": 855.8059999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 34,
"frameDurationMs": 51.88702010968922,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8512.40299999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.758,
"layouts": 20,
"layoutDurationMs": 23.168999999999983,
"taskDurationMs": 8401.645,
"heapDeltaBytes": -4870036,
"heapUsedBytes": 278334332,
"domNodes": -3482,
"jsHeapTotalBytes": 17809408,
"scriptDurationMs": 159.621,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.38863636363637,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8392.636999999922,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.80600000000001,
"layouts": 20,
"layoutDurationMs": 28.002999999999986,
"taskDurationMs": 8293.949999999999,
"heapDeltaBytes": -2253904,
"heapUsedBytes": 281823204,
"domNodes": -3482,
"jsHeapTotalBytes": 15450112,
"scriptDurationMs": 167.31199999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 68,
"frameDurationMs": 47.455932203389835,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11801.995000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11589.586000000001,
"heapDeltaBytes": 14793436,
"heapUsedBytes": 279649320,
"domNodes": 0,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 170.087,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.84219858156028,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11652.969999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11428.497,
"heapDeltaBytes": -29651012,
"heapUsedBytes": 252863464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.36700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.759726962457336,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 147.38199999999324,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.587000000000002,
"layouts": 9,
"layoutDurationMs": 4.021999999999999,
"taskDurationMs": 116.61500000000001,
"heapDeltaBytes": -11508468,
"heapUsedBytes": 59243916,
"domNodes": 128,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.221,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 111.93900000000667,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.429,
"layouts": 8,
"layoutDurationMs": 2.2769999999999997,
"taskDurationMs": 83.58800000000001,
"heapDeltaBytes": 4963260,
"heapUsedBytes": 75559096,
"domNodes": 99,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.45,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 502.1869999999353,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.65,
"layouts": 76,
"layoutDurationMs": 14.553999999999998,
"taskDurationMs": 463.658,
"heapDeltaBytes": -91504,
"heapUsedBytes": 47457232,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 226.13400000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 488.3220000000392,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6579999999999999,
"layouts": 76,
"layoutDurationMs": 14.526000000000002,
"taskDurationMs": 437.099,
"heapDeltaBytes": -3450772,
"heapUsedBytes": 42971548,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 206.763,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 576.9780000000537,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.686,
"layouts": 76,
"layoutDurationMs": 14.541,
"taskDurationMs": 543.902,
"heapDeltaBytes": 1905404,
"heapUsedBytes": 106439860,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 220.22799999999998,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 538.5780000000295,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.621,
"layouts": 76,
"layoutDurationMs": 13.428,
"taskDurationMs": 499.96899999999994,
"heapDeltaBytes": 784508,
"heapUsedBytes": 106655160,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 198.35899999999998,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3229 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 05553624c8674780b597f009d3d53cde67081cab
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (389)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.60 #23211 +/- ##
=============================================
Coverage ? 87.52%
=============================================
Files ? 2901
Lines ? 160631
Branches ? 40648
=============================================
Hits ? 140586
Misses ? 19282
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23075, per the requested backport review policy. Existing GitHub checks have no failures or pending checks. No tests run.
…ndoff (#23504) ## Summary Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft. Backport of #23463 — show the Comfy Cloud video in the deployment dialogs Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud Backport of #23470 — preserve agent choice and update Cloud handoff Uses the release telemetry package and adds the Cloud handoff state without importing the unrelated error-context feature. With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23211). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves. The sign-in continuation restores the unsent handoff and prior draft after a reload. ## Verification - Commit hooks passed, including changed-file lint and app type checking. - Both video formats and the poster returned HTTP 200 with the expected media type. - Before the follow-up, 765 tests passed across eight focused suites (toolbar, dialog, agent consent and composer, and handoff). - 36 tests passed across the Desktop relay, Cloud receiver, and handoff protocol suites before the follow-up. - The follow-up passed 74 tests in the agent chooser and consent suites, including reload recovery; the regression test failed before the fix. --------- Co-authored-by: Willie <falloon.willie@gmail.com> Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
Backport of #23075 to
cloud/1.60. The automated backport conflicted, so this is a manual port.Adapted for cloud/1.60: billingTab.ts takes this change as written, so handsPopupsToSystemBrowser moves to desktopBrowser; AddCreditsDialogContent.vue stays deleted, as it is on this branch.
Typecheck (app and browser tests) and the affected unit suites pass locally.