Repository navigation
[backport cloud/1.59] fix: keep Open on Cloud inert while its flag is off (#23134) - #23184
Conversation
… off (#23134) Backport of #23134 (441df2b) to cloud/1.59. Adapted for cloud/1.59: globalSettingsApi and its test keep this branch's in-tree imports (cloud/1.59 has no @comfyorg/api-client) and gain only this PR's useFeatureFlags import; the duplicate isCloud import the merge produced is dropped. (cherry picked from commit 441df2b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-10T01:26:43.034Z",
"gitSha": "d6c1376ff487977cda77078e8adaa4a059dabdf0",
"branch": "backport-23134-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.2689999999802,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.315,
"layouts": 9,
"layoutDurationMs": 2.597,
"taskDurationMs": 575.9870000000001,
"heapDeltaBytes": 3176244,
"heapUsedBytes": 73022168,
"domNodes": -161,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.872000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2040.736000000038,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4069999999999996,
"layouts": 9,
"layoutDurationMs": 2.5170000000000003,
"taskDurationMs": 599.133,
"heapDeltaBytes": -18085260,
"heapUsedBytes": 59034460,
"domNodes": -161,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8.216000000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.6570000000183,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.682,
"layouts": 9,
"layoutDurationMs": 2.4530000000000003,
"taskDurationMs": 885.357,
"heapDeltaBytes": -2277692,
"heapUsedBytes": 70058348,
"domNodes": -161,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 148.887,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.1580000000586,
"styleRecalcs": 78,
"styleRecalcDurationMs": 12.381,
"layouts": 10,
"layoutDurationMs": 2.397,
"taskDurationMs": 909.5040000000001,
"heapDeltaBytes": 5519636,
"heapUsedBytes": 65253648,
"domNodes": -161,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 161.397,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0349999999776,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.515,
"layouts": 11,
"layoutDurationMs": 2.7430000000000003,
"taskDurationMs": 408.047,
"heapDeltaBytes": 3537392,
"heapUsedBytes": 79385320,
"domNodes": 56,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.786999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.374999999961,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.386000000000001,
"layouts": 8,
"layoutDurationMs": 2.3240000000000003,
"taskDurationMs": 434.6530000000001,
"heapDeltaBytes": -868072,
"heapUsedBytes": 61196040,
"domNodes": 56,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8.873000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 651.188999999988,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.832,
"layouts": 10,
"layoutDurationMs": 2.916,
"taskDurationMs": 484.48199999999997,
"heapDeltaBytes": 11649788,
"heapUsedBytes": 84556124,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 166.804,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 638.9920000000302,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.424,
"layouts": 8,
"layoutDurationMs": 2.1060000000000003,
"taskDurationMs": 444.734,
"heapDeltaBytes": -16206120,
"heapUsedBytes": 59797120,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 172.959,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1152.5409999999852,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.217,
"heapDeltaBytes": 16935152,
"heapUsedBytes": 80461732,
"domNodes": 0,
"jsHeapTotalBytes": 10649600,
"scriptDurationMs": 69.38,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 33.823529411764696,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.1400000000122,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 837.275,
"heapDeltaBytes": 14006836,
"heapUsedBytes": 84284592,
"domNodes": 0,
"jsHeapTotalBytes": 13533184,
"scriptDurationMs": 72.692,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.3129999999855,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.25399999999996,
"heapDeltaBytes": -3904352,
"heapUsedBytes": 70735056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.20499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 911.0509999999294,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.1420000000004,
"heapDeltaBytes": -27542468,
"heapUsedBytes": 66783632,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 173.10999999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 241,
"frameDurationMs": 24.772972972972983,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10233.993999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9356.679,
"heapDeltaBytes": -13352960,
"heapUsedBytes": 65244208,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7474.673,
"eventListeners": 0,
"totalBlockingTimeMs": 876,
"frameDurationMs": 32.07805642633229,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10333.995999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9623.605,
"heapDeltaBytes": 61245972,
"heapUsedBytes": 135682728,
"domNodes": -257,
"jsHeapTotalBytes": 68546560,
"scriptDurationMs": 7707.471,
"eventListeners": -69,
"totalBlockingTimeMs": 857,
"frameDurationMs": 31.891358024691357,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10253.942999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9519.188,
"heapDeltaBytes": 976480,
"heapUsedBytes": 80438652,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7672.625,
"eventListeners": 0,
"totalBlockingTimeMs": 883,
"frameDurationMs": 32.03,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9926.807999999937,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06099999999999942,
"layouts": 1,
"layoutDurationMs": 0.2760000000000002,
"taskDurationMs": 9182.769,
"heapDeltaBytes": 70420060,
"heapUsedBytes": 144782848,
"domNodes": -257,
"jsHeapTotalBytes": 59109376,
"scriptDurationMs": 7339.995,
"eventListeners": -69,
"totalBlockingTimeMs": 827,
"frameDurationMs": 31.987741935483875,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 250.5170000000021,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.647,
"layouts": 9,
"layoutDurationMs": 3.352,
"taskDurationMs": 208.93800000000002,
"heapDeltaBytes": -15318112,
"heapUsedBytes": 68651920,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.711,
"eventListeners": -574,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.718181818181787,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 230.39400000004662,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.018999999999998,
"layouts": 9,
"layoutDurationMs": 2.705,
"taskDurationMs": 176.205,
"heapDeltaBytes": 14583376,
"heapUsedBytes": 70630152,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.922,
"eventListeners": -574,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2032.921999999985,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.303,
"layouts": 5,
"layoutDurationMs": 1.2139999999999997,
"taskDurationMs": 623.044,
"heapDeltaBytes": -3625796,
"heapUsedBytes": 69850232,
"domNodes": -257,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 31.640999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.3969999999417,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7499999999999998,
"layouts": 6,
"layoutDurationMs": 1.5720000000000005,
"taskDurationMs": 618.2320000000001,
"heapDeltaBytes": -3868912,
"heapUsedBytes": 70199716,
"domNodes": -257,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 29.463000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2472.528999999952,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.784,
"layouts": 6,
"layoutDurationMs": 4.899000000000001,
"taskDurationMs": 1710.818,
"heapDeltaBytes": -9737480,
"heapUsedBytes": 72528692,
"domNodes": -257,
"jsHeapTotalBytes": 2187264,
"scriptDurationMs": 824.9369999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77891156462585,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2326.885999999945,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.136999999999999,
"layouts": 4,
"layoutDurationMs": 0.9680000000000001,
"taskDurationMs": 1635.4869999999999,
"heapDeltaBytes": 12312524,
"heapUsedBytes": 72703064,
"domNodes": -257,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 810.7939999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594202898551,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3596.2899999999536,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.31,
"layouts": 62,
"layoutDurationMs": 9.261000000000001,
"taskDurationMs": 1688.9030000000002,
"heapDeltaBytes": 3915272,
"heapUsedBytes": 66716660,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 770.342,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3677.265000000034,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.503,
"layouts": 61,
"layoutDurationMs": 9.344,
"taskDurationMs": 1750.7690000000002,
"heapDeltaBytes": 4047552,
"heapUsedBytes": 66367236,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 803.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66606334841629,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3091.6479999999638,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.5809999999999995,
"layouts": 5,
"layoutDurationMs": 1.6280000000000001,
"taskDurationMs": 2052.357,
"heapDeltaBytes": -16357224,
"heapUsedBytes": 67414576,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 1010.905,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.94065934065934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3069.837000000007,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.074,
"layouts": 4,
"layoutDurationMs": 1.183,
"taskDurationMs": 1961.7089999999998,
"heapDeltaBytes": 22135944,
"heapUsedBytes": 95216812,
"domNodes": 0,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 979.178,
"eventListeners": 182,
"totalBlockingTimeMs": 26,
"frameDurationMs": 16.849450549450548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3054.4080000000235,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.4499999999999999,
"layouts": 2,
"layoutDurationMs": 0.3969999999999998,
"taskDurationMs": 737.481,
"heapDeltaBytes": 24134628,
"heapUsedBytes": 85635480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 368.33700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3088.6729999999716,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8510000000000002,
"layouts": 7,
"layoutDurationMs": 1.7469999999999999,
"taskDurationMs": 785.168,
"heapDeltaBytes": 1203780,
"heapUsedBytes": 85659808,
"domNodes": -257,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 366.92999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2047.695000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8790000000000004,
"layouts": 8,
"layoutDurationMs": 2.048,
"taskDurationMs": 636.5189999999999,
"heapDeltaBytes": -20549160,
"heapUsedBytes": 60811964,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.663,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.2879999999932,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.791,
"layouts": 3,
"layoutDurationMs": 0.8339999999999996,
"taskDurationMs": 598.187,
"heapDeltaBytes": 10521764,
"heapUsedBytes": 72051000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.812000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2777.327000000014,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.191,
"layouts": 3,
"layoutDurationMs": 0.5600000000000002,
"taskDurationMs": 557.1669999999999,
"heapDeltaBytes": 317112,
"heapUsedBytes": 62837124,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 190.92700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2861.349999999902,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.139000000000001,
"layouts": 7,
"layoutDurationMs": 1.9059999999999997,
"taskDurationMs": 625.8570000000001,
"heapDeltaBytes": -20929136,
"heapUsedBytes": 72595084,
"domNodes": -253,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 199.75699999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665497076023392,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3213.514000000032,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9330000000000007,
"layouts": 4,
"layoutDurationMs": 0.9729999999999999,
"taskDurationMs": 885.836,
"heapDeltaBytes": 3397856,
"heapUsedBytes": 65959500,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 370.423,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753403141361257,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3242.6510000000235,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.673,
"layouts": 3,
"layoutDurationMs": 0.745,
"taskDurationMs": 876.5469999999999,
"heapDeltaBytes": 3321360,
"heapUsedBytes": 65445944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 368.10099999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752331606217616,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.2629999999704,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.549,
"layouts": 9,
"layoutDurationMs": 2.275,
"taskDurationMs": 424.32000000000005,
"heapDeltaBytes": 21532704,
"heapUsedBytes": 83240260,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 146.689,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.9919999999529,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.112000000000001,
"layouts": 11,
"layoutDurationMs": 2.8539999999999996,
"taskDurationMs": 439.165,
"heapDeltaBytes": 5969592,
"heapUsedBytes": 80236984,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 146.51600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2031.8270000000211,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9779999999999998,
"layouts": 9,
"layoutDurationMs": 2.3379999999999996,
"taskDurationMs": 559.652,
"heapDeltaBytes": -9842744,
"heapUsedBytes": 51404336,
"domNodes": -183,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.353999999999997,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.3049999999503,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3289999999999993,
"layouts": 10,
"layoutDurationMs": 2.5100000000000007,
"taskDurationMs": 535.547,
"heapDeltaBytes": 2822296,
"heapUsedBytes": 65594384,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.382999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1744.4239999999809,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.391,
"layouts": 9,
"layoutDurationMs": 2.514,
"taskDurationMs": 872.4699999999999,
"heapDeltaBytes": -2032012,
"heapUsedBytes": 60994068,
"domNodes": -183,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 112.11699999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.1409999999369,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.151,
"layouts": 9,
"layoutDurationMs": 2.2300000000000004,
"taskDurationMs": 828.9739999999999,
"heapDeltaBytes": 4446724,
"heapUsedBytes": 65457964,
"domNodes": -183,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 104.91900000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1450.9120000000166,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.049000000000003,
"layouts": 5,
"layoutDurationMs": 16.397000000000002,
"taskDurationMs": 1037.032,
"heapDeltaBytes": 14022536,
"heapUsedBytes": 111126652,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 30.508,
"eventListeners": 3246,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.820270270270267,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9001.706000000013,
"styleRecalcs": 247,
"styleRecalcDurationMs": 26.942,
"layouts": 5,
"layoutDurationMs": 0.983,
"taskDurationMs": 5859.188999999999,
"heapDeltaBytes": 16098636,
"heapUsedBytes": 76158304,
"domNodes": -257,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 2711.997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696846011131726,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8708.759999999984,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.625,
"layouts": 6,
"layoutDurationMs": 1.3280000000000003,
"taskDurationMs": 5920.524,
"heapDeltaBytes": -8293488,
"heapUsedBytes": 80682264,
"domNodes": -257,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 2723.8340000000003,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698076923076922,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23130.970999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22201.017999999996,
"heapDeltaBytes": -28574184,
"heapUsedBytes": 273802656,
"domNodes": -3343,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 315.98,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.887414965986395,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 22713.040999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21954.444000000003,
"heapDeltaBytes": 26368728,
"heapUsedBytes": 274879132,
"domNodes": -3343,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 293.31700000000006,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.574390243902435,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28807.022999999957,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.17100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28365.090000000004,
"heapDeltaBytes": -13477600,
"heapUsedBytes": 269501816,
"domNodes": -3343,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 899.1850000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 25,
"frameDurationMs": 52.87266055045871,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28771.992000000067,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.616999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28381.024999999998,
"heapDeltaBytes": -25507956,
"heapUsedBytes": 278050592,
"domNodes": -3343,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 887.0029999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 52.611623616236166,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8175.189999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.26799999999999,
"layouts": 20,
"layoutDurationMs": 21.731,
"taskDurationMs": 8014.917,
"heapDeltaBytes": -20848404,
"heapUsedBytes": 281776572,
"domNodes": -3343,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 137.995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.94915254237289,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8209.760999999959,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.93199999999997,
"layouts": 20,
"layoutDurationMs": 32.156000000000006,
"taskDurationMs": 8083.736,
"heapDeltaBytes": -15030780,
"heapUsedBytes": 261963508,
"domNodes": -3343,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.06600000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 19,
"frameDurationMs": 47.589595375722546,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11495.236999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11193.563000000002,
"heapDeltaBytes": 23273840,
"heapUsedBytes": 275268792,
"domNodes": 0,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 152.99700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.71914893617021,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11871.409999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11450.679,
"heapDeltaBytes": 20842512,
"heapUsedBytes": 276214872,
"domNodes": 0,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 203.54000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.379285714285714,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 129.74099999996724,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.200000000000001,
"layouts": 8,
"layoutDurationMs": 3.626,
"taskDurationMs": 106.77499999999999,
"heapDeltaBytes": 4992408,
"heapUsedBytes": 67682876,
"domNodes": 132,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.456000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 119.66900000004443,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.575000000000001,
"layouts": 7,
"layoutDurationMs": 2.536,
"taskDurationMs": 97.79799999999999,
"heapDeltaBytes": -12503876,
"heapUsedBytes": 62030540,
"domNodes": 98,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 6.061000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 572.322999999983,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9420000000000001,
"layouts": 76,
"layoutDurationMs": 14.722000000000001,
"taskDurationMs": 501.861,
"heapDeltaBytes": -2746060,
"heapUsedBytes": 44365120,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 226.882,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 455.8400000000802,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.695,
"layouts": 76,
"layoutDurationMs": 14.999,
"taskDurationMs": 414.70199999999994,
"heapDeltaBytes": -4439088,
"heapUsedBytes": 40601080,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 194.523,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 709.6759999999449,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.529,
"layouts": 76,
"layoutDurationMs": 16.743000000000002,
"taskDurationMs": 672.3009999999999,
"heapDeltaBytes": 2472680,
"heapUsedBytes": 104451824,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 288.399,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.053488372093007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 637.2460000000046,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.58,
"layouts": 76,
"layoutDurationMs": 16.897,
"taskDurationMs": 609.274,
"heapDeltaBytes": 2029412,
"heapUsedBytes": 106667776,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 253.77499999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 59.5% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3152 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3dbe23d7cf28b8019b0c274e8cde49be7b0e97f1
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (320)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #23184 +/- ##
=============================================
Coverage ? 87.32%
=============================================
Files ? 3100
Lines ? 162041
Branches ? 43331
=============================================
Hits ? 141502
Misses ? 19862
Partials ? 677
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23134, per the requested backport-only review policy. Existing GitHub checks inspected; no tests run.
Backport of #23134 to
cloud/1.59. The automated backport conflicted, so this is a manual port.Adapted for cloud/1.59: globalSettingsApi and its test keep this branch's
in-tree imports (cloud/1.59 has no @comfyorg/api-client) and gain only this
PR's useFeatureFlags import; the duplicate isCloud import the merge produced
is dropped.
Typecheck (app and browser tests) and the affected unit suites pass locally.