Repository navigation
[backport cloud/1.59] feat: carry the Open on Cloud handoff through sign-in and import it on Cloud - #23152
Conversation
…n Cloud (#23074) <p align="center"><img src="https://github.com/user-attachments/assets/f61070bb-9f9d-4e3d-96b1-45791653a7bd" alt="J4 and J10 handoff through sign-in" width="720"></p> ## Summary Two commits: - **J4, Open on Cloud to sign-in.** A signed-out user lands on the hosted sign-in page; the `from_local` nonce is now a preserved query, so it survives the login round trip back to the editor. - **J10, Browser to Cloud import.** On Cloud with the flag on, a `from_local` link asks its opener tab for the workflow by nonce, accepts it only from a local origin, loads it and says where it came from. A lost sender or closed tab gets retry guidance. With the flag off the link is stripped and nothing is requested. The loader handles only the browser handoff here; the Desktop import arrives in J8. ## Verification <details open><summary><b>J4 · Browser Open on Cloud → sign-in</b></summary> **1.** Load compatible workflow; open Cloud dialog.<br> <img src="https://github.com/user-attachments/assets/af463dfb-5211-41aa-877e-17aea2192d63" alt="J4 · Browser Open on Cloud → sign-in, step 1" width="640"> **2.** New tab reaches the real PR-preview sign-in page.<br> <img src="https://github.com/user-attachments/assets/9000fe02-84b3-49c4-aed4-461cf135dbc9" alt="J4 · Browser Open on Cloud → sign-in, step 2" width="640"> </details> <details open><summary><b>J10 · Browser → Cloud import</b></summary> **1.** Load real EmptyImage → SaveImage in a localhost browser.<br> <img src="https://github.com/user-attachments/assets/021f6b55-9b31-45b5-9bf7-5bd00173a145" alt="J10 · Browser → Cloud import, step 1" width="640"> **2.** Real compatibility passes; Run on Comfy Cloud dialog shown.<br> <img src="https://github.com/user-attachments/assets/7a6a9487-5698-4f1e-9a36-e37959c5c338" alt="J10 · Browser → Cloud import, step 2" width="640"> **3.** Open Cloud tab; real opener/postMessage handoff sends the workflow.<br> <img src="https://github.com/user-attachments/assets/5ef222c1-6b83-44e1-b0da-3ece8367e30d" alt="J10 · Browser → Cloud import, step 3" width="640"> **4.** Cloud auto-imports same ID and name/prefix; nonce cleared; Run enabled.<br> <img src="https://github.com/user-attachments/assets/7e0b22c4-5dcb-4e03-b9de-0e6805dd0d5c" alt="J10 · Browser → Cloud import, step 4" width="640"> </details> 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: huang47 <157390+huang47@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-09T15:35:54.064Z",
"gitSha": "32024c887a8583838cc5e40157bd281ef55ccad0",
"branch": "backport-23074-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.0340000000044,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4939999999999998,
"layouts": 9,
"layoutDurationMs": 2.5770000000000004,
"taskDurationMs": 455.4889999999999,
"heapDeltaBytes": 2131792,
"heapUsedBytes": 63993656,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.828,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.736999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8449999999999998,
"layouts": 9,
"layoutDurationMs": 1.8559999999999999,
"taskDurationMs": 405.61800000000005,
"heapDeltaBytes": 2085100,
"heapUsedBytes": 63340784,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.743999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.7019999999786,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.529,
"layouts": 10,
"layoutDurationMs": 2.522,
"taskDurationMs": 774.849,
"heapDeltaBytes": 8406424,
"heapUsedBytes": 67791160,
"domNodes": -161,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 125.12299999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.2299999999773,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.088999999999999,
"layouts": 10,
"layoutDurationMs": 2.1940000000000004,
"taskDurationMs": 717.723,
"heapDeltaBytes": 21516772,
"heapUsedBytes": 83194960,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 118.67099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.9029999999834,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.561,
"layouts": 10,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 342.75500000000005,
"heapDeltaBytes": 390652,
"heapUsedBytes": 70161608,
"domNodes": 56,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 10.133999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.7779999999666,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.147,
"layouts": 10,
"layoutDurationMs": 2.3600000000000008,
"taskDurationMs": 334.58200000000005,
"heapDeltaBytes": 20737232,
"heapUsedBytes": 81565204,
"domNodes": 56,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.209,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 566.6520000000048,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6499999999999995,
"layouts": 10,
"layoutDurationMs": 2.525,
"taskDurationMs": 415.947,
"heapDeltaBytes": 3695648,
"heapUsedBytes": 65135612,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 141.473,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 567.3380000000066,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.104,
"layouts": 9,
"layoutDurationMs": 1.9769999999999996,
"taskDurationMs": 396.01899999999995,
"heapDeltaBytes": 3380264,
"heapUsedBytes": 65167276,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 132.09099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1048.1570000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.7270000000001,
"heapDeltaBytes": -2004580,
"heapUsedBytes": 76102780,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 50.32600000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 385,
"frameDurationMs": 29.163888888888906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1052.334999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.4159999999999,
"heapDeltaBytes": -12262756,
"heapUsedBytes": 75567336,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 51.42300000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 388,
"frameDurationMs": 29.16944444444444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.5640000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.1780000000004,
"heapDeltaBytes": -4252736,
"heapUsedBytes": 70497164,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.76699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 23.041176470588226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 798.6870000000295,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.46400000000017,
"heapDeltaBytes": -4706824,
"heapUsedBytes": 70696076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.52499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7806.7660000000105,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8200000000000004,
"layouts": 3,
"layoutDurationMs": 0.8770000000000002,
"taskDurationMs": 7008.638999999999,
"heapDeltaBytes": 45957180,
"heapUsedBytes": 128036908,
"domNodes": -257,
"jsHeapTotalBytes": 61992960,
"scriptDurationMs": 5396.514000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 76,
"frameDurationMs": 24.147678018575853,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7308.73200000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.536,
"layouts": 2,
"layoutDurationMs": 0.47500000000000014,
"taskDurationMs": 6540.145,
"heapDeltaBytes": 45994164,
"heapUsedBytes": 119791200,
"domNodes": -257,
"jsHeapTotalBytes": 52817920,
"scriptDurationMs": 5016.023,
"eventListeners": -69,
"totalBlockingTimeMs": 58,
"frameDurationMs": 24.226490066225168,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8355.637000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7534.135,
"heapDeltaBytes": -12192120,
"heapUsedBytes": 81960152,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 5957.772,
"eventListeners": -69,
"totalBlockingTimeMs": 155,
"frameDurationMs": 25.099397590361445,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7449.169999999981,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7270000000000002,
"layouts": 3,
"layoutDurationMs": 0.7099999999999997,
"taskDurationMs": 6648.597000000001,
"heapDeltaBytes": 44201856,
"heapUsedBytes": 118617408,
"domNodes": -257,
"jsHeapTotalBytes": 50720768,
"scriptDurationMs": 5061.474999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 34,
"frameDurationMs": 24.109061488673138,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 174.84699999999975,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.072,
"layouts": 10,
"layoutDurationMs": 2.84,
"taskDurationMs": 137.67700000000002,
"heapDeltaBytes": 14511264,
"heapUsedBytes": 90992436,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 8.174,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.92500000000001,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 176.49600000004284,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.088000000000001,
"layouts": 10,
"layoutDurationMs": 2.5599999999999996,
"taskDurationMs": 135.97400000000002,
"heapDeltaBytes": 14523836,
"heapUsedBytes": 90403000,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 6.627999999999998,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.92500000000001,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2006.8359999999927,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.621,
"layouts": 8,
"layoutDurationMs": 1.635,
"taskDurationMs": 528.502,
"heapDeltaBytes": 5878316,
"heapUsedBytes": 79566744,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.621000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.2500000000045,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6389999999999998,
"layouts": 8,
"layoutDurationMs": 1.7060000000000002,
"taskDurationMs": 521.059,
"heapDeltaBytes": -14637172,
"heapUsedBytes": 60917152,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.465,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2246.3919999999575,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.116,
"layouts": 5,
"layoutDurationMs": 0.9260000000000002,
"taskDurationMs": 1311.3770000000002,
"heapDeltaBytes": 15593840,
"heapUsedBytes": 76269644,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 651.223,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2233.043000000009,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.716999999999999,
"layouts": 8,
"layoutDurationMs": 1.9209999999999998,
"taskDurationMs": 1352.1029999999998,
"heapDeltaBytes": 670320,
"heapUsedBytes": 76384732,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 637.314,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665671641791043,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3570.831999999996,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.495,
"layouts": 65,
"layoutDurationMs": 10.376,
"taskDurationMs": 1473.2849999999996,
"heapDeltaBytes": 6354928,
"heapUsedBytes": 86677664,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 667.43,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3667.0769999999493,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.691999999999998,
"layouts": 63,
"layoutDurationMs": 10.741999999999999,
"taskDurationMs": 1580.824,
"heapDeltaBytes": -23985100,
"heapUsedBytes": 70174052,
"domNodes": -233,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 698.751,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2618.13699999999,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.101999999999999,
"layouts": 6,
"layoutDurationMs": 1.281,
"taskDurationMs": 1691.2509999999997,
"heapDeltaBytes": 15950240,
"heapUsedBytes": 99779708,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 840.992,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.772903225806452,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2341.5709999999876,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.978,
"layouts": 6,
"layoutDurationMs": 1.4929999999999999,
"taskDurationMs": 1619.437,
"heapDeltaBytes": -9550392,
"heapUsedBytes": 63300292,
"domNodes": -242,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 770.921,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785611510791366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3007.4219999999914,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1790000000000003,
"layouts": 6,
"layoutDurationMs": 1.536,
"taskDurationMs": 646.267,
"heapDeltaBytes": -1658476,
"heapUsedBytes": 79397884,
"domNodes": -257,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 302.30400000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758888888888887,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2969.3860000000427,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6689999999999994,
"layouts": 8,
"layoutDurationMs": 1.5479999999999998,
"taskDurationMs": 627.81,
"heapDeltaBytes": 3459380,
"heapUsedBytes": 81973824,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 292.81199999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.480000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5510000000000004,
"layouts": 7,
"layoutDurationMs": 1.4969999999999999,
"taskDurationMs": 530.6530000000001,
"heapDeltaBytes": -15873512,
"heapUsedBytes": 62299552,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 33.339,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.219000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5299999999999991,
"layouts": 7,
"layoutDurationMs": 1.473,
"taskDurationMs": 524.4839999999999,
"heapDeltaBytes": -9902064,
"heapUsedBytes": 69029948,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.38,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2720.8400000000097,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.206,
"layouts": 7,
"layoutDurationMs": 1.6469999999999998,
"taskDurationMs": 489.42699999999996,
"heapDeltaBytes": -2115380,
"heapUsedBytes": 70838048,
"domNodes": -240,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 150.353,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564417177914,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2791.0889999999995,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.365,
"layouts": 7,
"layoutDurationMs": 1.6729999999999998,
"taskDurationMs": 514.894,
"heapDeltaBytes": 1923480,
"heapUsedBytes": 84410492,
"domNodes": -238,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 157.97699999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3028.719999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6500000000000004,
"layouts": 7,
"layoutDurationMs": 1.421,
"taskDurationMs": 742.4210000000002,
"heapDeltaBytes": -11700924,
"heapUsedBytes": 65892772,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 278.1,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3021.0099999999898,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9160000000000001,
"layouts": 8,
"layoutDurationMs": 1.9360000000000002,
"taskDurationMs": 758.014,
"heapDeltaBytes": -14097136,
"heapUsedBytes": 79123756,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 284.49800000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353595,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 550.2210000000218,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.0520000000000005,
"layouts": 10,
"layoutDurationMs": 2.5640000000000005,
"taskDurationMs": 373.42699999999996,
"heapDeltaBytes": -354776,
"heapUsedBytes": 62763128,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 123.041,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.8580000000848,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.168,
"layouts": 9,
"layoutDurationMs": 2.036,
"taskDurationMs": 363.875,
"heapDeltaBytes": -893016,
"heapUsedBytes": 60853876,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 122.72499999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.8479999999956,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2910000000000004,
"layouts": 9,
"layoutDurationMs": 2.0959999999999996,
"taskDurationMs": 492.553,
"heapDeltaBytes": -1993024,
"heapUsedBytes": 61381384,
"domNodes": -183,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.67,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.009000000006,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.102,
"layouts": 10,
"layoutDurationMs": 2.105,
"taskDurationMs": 438.49699999999996,
"heapDeltaBytes": -17334860,
"heapUsedBytes": 64913740,
"domNodes": -183,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.848999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6320000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.610000000000001,
"layouts": 10,
"layoutDurationMs": 2.182,
"taskDurationMs": 708.3960000000001,
"heapDeltaBytes": 18423412,
"heapUsedBytes": 80114140,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 93.237,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.8560000000102,
"styleRecalcs": 76,
"styleRecalcDurationMs": 10.964,
"layouts": 10,
"layoutDurationMs": 1.9069999999999998,
"taskDurationMs": 649.02,
"heapDeltaBytes": 18340896,
"heapUsedBytes": 81469928,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 84.483,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1352.3250000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.101,
"layouts": 5,
"layoutDurationMs": 10.415000000000001,
"taskDurationMs": 884.4319999999999,
"heapDeltaBytes": 9501784,
"heapUsedBytes": 110963456,
"domNodes": 16030,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 26.160000000000004,
"eventListeners": 3246,
"totalBlockingTimeMs": 113,
"frameDurationMs": 18.720547945205485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8960.914000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.199,
"layouts": 10,
"layoutDurationMs": 2.279,
"taskDurationMs": 4980.812,
"heapDeltaBytes": -11928048,
"heapUsedBytes": 62573384,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2257.2839999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665985130111526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8445.605999999998,
"styleRecalcs": 252,
"styleRecalcDurationMs": 29.511999999999997,
"layouts": 9,
"layoutDurationMs": 2.258,
"taskDurationMs": 4806.003000000001,
"heapDeltaBytes": -2751380,
"heapUsedBytes": 72184944,
"domNodes": -257,
"jsHeapTotalBytes": 1400832,
"scriptDurationMs": 2171.679,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665877712031556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21176.714000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20338.66,
"heapDeltaBytes": -2966876,
"heapUsedBytes": 281229156,
"domNodes": -3343,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 283.97,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.227416520210895,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20995.195999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20138.534,
"heapDeltaBytes": 1197212,
"heapUsedBytes": 285426468,
"domNodes": -3343,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 275.46099999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.428125,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24314.055999999993,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.54800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23976.554,
"heapDeltaBytes": -38169148,
"heapUsedBytes": 263993712,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 765.552,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 46.49273422562142,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24349.379,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.16899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24036.978,
"heapDeltaBytes": -18641788,
"heapUsedBytes": 274062100,
"domNodes": -3343,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 719.671,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 45.566104868913854,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7136.252000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.627,
"layouts": 20,
"layoutDurationMs": 22.05,
"taskDurationMs": 7007.28,
"heapDeltaBytes": 1221800,
"heapUsedBytes": 273860524,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 109.53399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.97048192771084,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7364.297000000079,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.63299999999998,
"layouts": 20,
"layoutDurationMs": 22.424,
"taskDurationMs": 7280.978,
"heapDeltaBytes": -6404536,
"heapUsedBytes": 276443916,
"domNodes": -3343,
"jsHeapTotalBytes": 23842816,
"scriptDurationMs": 111.66100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.516455696202534,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10602.831000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10378.932999999999,
"heapDeltaBytes": 4364196,
"heapUsedBytes": 263699084,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 163.45000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.64609929078014,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10257.113000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9835.993000000002,
"heapDeltaBytes": -4211156,
"heapUsedBytes": 277481048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.85200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.837762237762234,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 111.31999999997788,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.358,
"layouts": 8,
"layoutDurationMs": 3.0149999999999997,
"taskDurationMs": 85.402,
"heapDeltaBytes": -13291244,
"heapUsedBytes": 60778920,
"domNodes": 124,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.5060000000476,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.426,
"layouts": 7,
"layoutDurationMs": 1.6150000000000002,
"taskDurationMs": 63.30799999999999,
"heapDeltaBytes": 4622004,
"heapUsedBytes": 67721204,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.814000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 325.13700000004064,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.617,
"layouts": 76,
"layoutDurationMs": 11.503,
"taskDurationMs": 283.574,
"heapDeltaBytes": -5282336,
"heapUsedBytes": 37825428,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 125.004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 381.26199999999244,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.611,
"layouts": 76,
"layoutDurationMs": 13.222,
"taskDurationMs": 341.665,
"heapDeltaBytes": -4599472,
"heapUsedBytes": 38367948,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 157.554,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669565217391327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 354.2370000000119,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8,
"layouts": 76,
"layoutDurationMs": 11.558,
"taskDurationMs": 331.938,
"heapDeltaBytes": -1277472,
"heapUsedBytes": 92990388,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 115.961,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 335.3159999999207,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.706,
"layouts": 76,
"layoutDurationMs": 11.383000000000001,
"taskDurationMs": 311.70699999999994,
"heapDeltaBytes": -438660,
"heapUsedBytes": 98233708,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 112.73899999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 3155 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0d4942ef1555f98cde142fbb141ebdc00925449e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (311)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
cloud/1.59 predates the telemetry and graph-model package extractions, so point @comfyorg/telemetry/reportError and @comfyorg/graph-model/workflowSchema at the in-tree modules on this branch.
|
dante01yoon could you take a look? The auto-backport didn't build on cloud/1.59, so I added |
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23074 to cloud/1.59, per the requested backport review policy. No code-change review or tests were performed.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #23152 +/- ##
=============================================
Coverage ? 86.75%
=============================================
Files ? 2723
Lines ? 140984
Branches ? 43270
=============================================
Hits ? 122310
Misses ? 17856
Partials ? 818
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #23074 to
cloud/1.59Automatically created by backport workflow.