Repository navigation
[backport cloud/1.59] feat: offer a deployment or list missing models when Cloud cannot run a workflow - #23148
Conversation
… a workflow (#23072) <p align="center"><img src="https://github.com/user-attachments/assets/2735ef3b-ae7f-4399-98e0-4da264a06784" alt="J2 and J3 dialog branches" width="720"></p> ## Summary Two commits: - **J2, missing node.** When the compatibility check reports node types Cloud does not have, the dialog shows the Deploy your setup card that links to Comfy Platform instead of the open action. The card's agent menu arrives in J9. - **J3, missing model.** When Cloud lacks a model the workflow uses, the dialog names each missing model and explains that uploads from local ComfyUI are not available yet. ## Verification <details open><summary><b>J2 · Missing node</b></summary> **1.** Load VAESave workflow.<br> <img src="https://github.com/user-attachments/assets/22525757-adf8-426e-a3c7-128250e1639f" alt="J2 · Missing node, step 1" width="640"> **2.** Real HTTP 200: VAESave missing; no missing models.<br> <img src="https://github.com/user-attachments/assets/3a2fa3c6-47d3-4759-a5d3-05a7cfd31847" alt="J2 · Missing node, step 2" width="640"> **3.** Deploy your setup to Comfy Cloud dialog shown.<br> <img src="https://github.com/user-attachments/assets/07540f29-4cc3-48fb-affb-8cd29277a5b4" alt="J2 · Missing node, step 3" width="640"> </details> <details open><summary><b>J3 · Missing model</b></summary> **1.** Load workflow with an unavailable checkpoint.<br> <img src="https://github.com/user-attachments/assets/1364db06-56bb-4c1a-86a4-80243500c4a5" alt="J3 · Missing model, step 1" width="640"> **2.** Real HTTP 200: one checkpoint missing; no missing nodes.<br> <img src="https://github.com/user-attachments/assets/6b1e11b9-0940-4d0d-a1fa-40d7110ce0b7" alt="J3 · Missing model, step 2" width="640"> **3.** Exact model name and upload-unavailable notice; no Upload button.<br> <img src="https://github.com/user-attachments/assets/aff3ec8a-2ce3-483b-a7b3-f0362f9afd8f" alt="J3 · Missing model, step 3" width="640"> </details> 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-09T10:34:39.749Z",
"gitSha": "2dfbd0f504985bea5a51dbfd948e8bd8607411bb",
"branch": "backport-23072-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.1309999999928,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4470000000000005,
"layouts": 9,
"layoutDurationMs": 2.7099999999999995,
"taskDurationMs": 560.195,
"heapDeltaBytes": -4159116,
"heapUsedBytes": 71719568,
"domNodes": -161,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8.323,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.9779999999623,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3519999999999994,
"layouts": 9,
"layoutDurationMs": 2.4850000000000003,
"taskDurationMs": 561.603,
"heapDeltaBytes": 2256188,
"heapUsedBytes": 74418228,
"domNodes": -161,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.816000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.5690000000186,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.952,
"layouts": 10,
"layoutDurationMs": 2.682,
"taskDurationMs": 897.4939999999999,
"heapDeltaBytes": -15135720,
"heapUsedBytes": 57292108,
"domNodes": -161,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 157.607,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.9970000000358,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.736,
"layouts": 9,
"layoutDurationMs": 2.432,
"taskDurationMs": 853.601,
"heapDeltaBytes": -1275280,
"heapUsedBytes": 69092368,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 159.113,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.018000000001,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.703,
"layouts": 10,
"layoutDurationMs": 2.7939999999999996,
"taskDurationMs": 398.74299999999994,
"heapDeltaBytes": 948860,
"heapUsedBytes": 70791476,
"domNodes": 56,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.681999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.0699999999779,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.435999999999999,
"layouts": 10,
"layoutDurationMs": 2.8429999999999995,
"taskDurationMs": 390.46400000000006,
"heapDeltaBytes": -1945084,
"heapUsedBytes": 60096580,
"domNodes": 56,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 9.716,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 673.1819999999971,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.302,
"layouts": 9,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 483.67800000000005,
"heapDeltaBytes": 581392,
"heapUsedBytes": 60158744,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 174.313,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 641.7089999999916,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.006,
"layouts": 10,
"layoutDurationMs": 3.0700000000000003,
"taskDurationMs": 477.36300000000006,
"heapDeltaBytes": 10109660,
"heapUsedBytes": 86069856,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 164.047,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.431999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.683,
"heapDeltaBytes": -884128,
"heapUsedBytes": 76018736,
"domNodes": -191,
"jsHeapTotalBytes": 15736832,
"scriptDurationMs": 66.51199999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 515,
"frameDurationMs": 32.42972972972973,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1183.403999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.1580000000001,
"heapDeltaBytes": 17623180,
"heapUsedBytes": 87806544,
"domNodes": 0,
"jsHeapTotalBytes": 12746752,
"scriptDurationMs": 68.607,
"eventListeners": 0,
"totalBlockingTimeMs": 559,
"frameDurationMs": 35.85757575757575,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 928.1929999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.6450000000003,
"heapDeltaBytes": -28611560,
"heapUsedBytes": 66544876,
"domNodes": -191,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 185.70999999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 232,
"frameDurationMs": 24.560526315789478,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.7340000000172,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.39599999999996,
"heapDeltaBytes": -4998064,
"heapUsedBytes": 69935864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.31599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11018.07500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10177.362000000001,
"heapDeltaBytes": 62460088,
"heapUsedBytes": 136325884,
"domNodes": -257,
"jsHeapTotalBytes": 69070848,
"scriptDurationMs": 8154.5250000000015,
"eventListeners": -69,
"totalBlockingTimeMs": 1302,
"frameDurationMs": 31.65574712643678,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9599.054000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8845.789,
"heapDeltaBytes": 63051620,
"heapUsedBytes": 136840000,
"domNodes": -257,
"jsHeapTotalBytes": 57012224,
"scriptDurationMs": 7051.4130000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 611,
"frameDurationMs": 31.577960526315792,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10408.938000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9636.738000000001,
"heapDeltaBytes": -6284948,
"heapUsedBytes": 73253368,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 7839.317999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 949,
"frameDurationMs": 31.37409638554217,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9725.974000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8921.338,
"heapDeltaBytes": 52290560,
"heapUsedBytes": 127221200,
"domNodes": -257,
"jsHeapTotalBytes": 60420096,
"scriptDurationMs": 7127.772,
"eventListeners": -69,
"totalBlockingTimeMs": 540,
"frameDurationMs": 31.85639344262295,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 219.0469999999891,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.676,
"layouts": 9,
"layoutDurationMs": 3.01,
"taskDurationMs": 160.48299999999998,
"heapDeltaBytes": 14642880,
"heapUsedBytes": 71922380,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.963,
"eventListeners": 205,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 222.85699999997632,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.6,
"layouts": 9,
"layoutDurationMs": 2.4949999999999997,
"taskDurationMs": 164.536,
"heapDeltaBytes": 14601004,
"heapUsedBytes": 71079704,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.271000000000003,
"eventListeners": -574,
"totalBlockingTimeMs": 1,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2039.6550000000104,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.955,
"layouts": 8,
"layoutDurationMs": 2.171,
"taskDurationMs": 643.943,
"heapDeltaBytes": -16104196,
"heapUsedBytes": 62642696,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 31.083,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.5230000000074,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1080000000000005,
"layouts": 8,
"layoutDurationMs": 2.3409999999999997,
"taskDurationMs": 627.794,
"heapDeltaBytes": -6843384,
"heapUsedBytes": 84957064,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 31.909,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2411.2270000000253,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.997000000000001,
"layouts": 7,
"layoutDurationMs": 1.8099999999999998,
"taskDurationMs": 1638.6989999999998,
"heapDeltaBytes": -20374644,
"heapUsedBytes": 72409552,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 806.795,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.782638888888886,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2553.2949999999346,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.203,
"layouts": 7,
"layoutDurationMs": 2.249,
"taskDurationMs": 1691.6919999999998,
"heapDeltaBytes": -18775372,
"heapUsedBytes": 61700900,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 827.541,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77565789473684,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3669.8339999999803,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.691999999999999,
"layouts": 61,
"layoutDurationMs": 8.972000000000001,
"taskDurationMs": 1678.5609999999997,
"heapDeltaBytes": 4375460,
"heapUsedBytes": 66505744,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.522,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3771.74100000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.392,
"layouts": 62,
"layoutDurationMs": 9.343,
"taskDurationMs": 1778.8129999999999,
"heapDeltaBytes": 2839444,
"heapUsedBytes": 65471884,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.4409999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2930.4930000000127,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.8439999999999994,
"layouts": 2,
"layoutDurationMs": 0.4430000000000002,
"taskDurationMs": 1891.2230000000002,
"heapDeltaBytes": 16009988,
"heapUsedBytes": 78644256,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 942.7620000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858381502890172,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2960.519999999974,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.503999999999999,
"layouts": 1,
"layoutDurationMs": 0.17799999999999977,
"taskDurationMs": 1910.262,
"heapDeltaBytes": 15333560,
"heapUsedBytes": 77825596,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 946.0740000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760227272727274,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3057.818999999995,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6420000000000001,
"layouts": 7,
"layoutDurationMs": 1.782,
"taskDurationMs": 778.003,
"heapDeltaBytes": -9835776,
"heapUsedBytes": 67770512,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 377.282,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3082.2450000000003,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6309999999999996,
"layouts": 6,
"layoutDurationMs": 1.6039999999999999,
"taskDurationMs": 797.1030000000001,
"heapDeltaBytes": -2662376,
"heapUsedBytes": 75684584,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 395.343,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2065.5029999999783,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.691,
"layouts": 9,
"layoutDurationMs": 2.6619999999999995,
"taskDurationMs": 649.6890000000001,
"heapDeltaBytes": -15309928,
"heapUsedBytes": 67265468,
"domNodes": -257,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 31.564999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.6540000000978,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7070000000000003,
"layouts": 7,
"layoutDurationMs": 1.777,
"taskDurationMs": 620.2240000000002,
"heapDeltaBytes": -5299572,
"heapUsedBytes": 74226420,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 34.054,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2794.1360000000086,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.498,
"layouts": 6,
"layoutDurationMs": 1.7210000000000003,
"taskDurationMs": 614.687,
"heapDeltaBytes": -11086152,
"heapUsedBytes": 68646856,
"domNodes": -248,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 192.577,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3065.0960000000396,
"styleRecalcs": 25,
"styleRecalcDurationMs": 10.138,
"layouts": 6,
"layoutDurationMs": 1.738,
"taskDurationMs": 608.5449999999998,
"heapDeltaBytes": 4376528,
"heapUsedBytes": 86672148,
"domNodes": -238,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 183.43099999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3256.177000000008,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.3299999999999996,
"layouts": 6,
"layoutDurationMs": 1.3960000000000001,
"taskDurationMs": 911.9540000000001,
"heapDeltaBytes": -1297724,
"heapUsedBytes": 78197988,
"domNodes": -257,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 376.346,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83834196891192,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3312.882000000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1119999999999992,
"layouts": 4,
"layoutDurationMs": 0.9980000000000002,
"taskDurationMs": 944.077,
"heapDeltaBytes": 5749892,
"heapUsedBytes": 88552852,
"domNodes": -257,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 398.327,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.835532994923856,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.2890000000225,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.534,
"layouts": 10,
"layoutDurationMs": 2.785,
"taskDurationMs": 440.091,
"heapDeltaBytes": 1656196,
"heapUsedBytes": 63190284,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 149.87,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.8959999999761,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.4910000000000005,
"layouts": 9,
"layoutDurationMs": 2.2239999999999998,
"taskDurationMs": 430.35499999999996,
"heapDeltaBytes": -1581956,
"heapUsedBytes": 60946448,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 143.62900000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2021.9549999999913,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2080000000000006,
"layouts": 9,
"layoutDurationMs": 2.4099999999999997,
"taskDurationMs": 508.425,
"heapDeltaBytes": 2692392,
"heapUsedBytes": 65494532,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.732000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.7430000000245,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5779999999999994,
"layouts": 10,
"layoutDurationMs": 2.84,
"taskDurationMs": 552.4670000000001,
"heapDeltaBytes": -7246440,
"heapUsedBytes": 63679444,
"domNodes": -183,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.946,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.7690000000002,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.991999999999999,
"layouts": 9,
"layoutDurationMs": 2.267,
"taskDurationMs": 847.309,
"heapDeltaBytes": -4222648,
"heapUsedBytes": 58296144,
"domNodes": -183,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 106.915,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.3870000000397,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.084000000000001,
"layouts": 9,
"layoutDurationMs": 2.5970000000000004,
"taskDurationMs": 843.0989999999999,
"heapDeltaBytes": 19328180,
"heapUsedBytes": 81704440,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 111.698,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.4509999999768,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.885,
"layouts": 5,
"layoutDurationMs": 16.462999999999997,
"taskDurationMs": 1034.9640000000002,
"heapDeltaBytes": 9436524,
"heapUsedBytes": 101248916,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 29.050999999999995,
"eventListeners": 3246,
"totalBlockingTimeMs": 157,
"frameDurationMs": 19.331999999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9515.374000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.74,
"layouts": 8,
"layoutDurationMs": 2.0140000000000002,
"taskDurationMs": 5955.804,
"heapDeltaBytes": -1144364,
"heapUsedBytes": 74028592,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2758.4629999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66584938704028,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9270.950999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.749000000000002,
"layouts": 6,
"layoutDurationMs": 1.5270000000000001,
"taskDurationMs": 5802.152,
"heapDeltaBytes": 3539124,
"heapUsedBytes": 76526328,
"domNodes": -257,
"jsHeapTotalBytes": 319488,
"scriptDurationMs": 2648.6639999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666068222621185,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23303.207999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22603.153,
"heapDeltaBytes": 10909272,
"heapUsedBytes": 288174864,
"domNodes": -3343,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 299.212,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.10154905335629,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 22780.425000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22032.684000000005,
"heapDeltaBytes": -11707372,
"heapUsedBytes": 255434360,
"domNodes": -3343,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 306.30199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.279999999999994,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28389.12099999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.665000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28018.207,
"heapDeltaBytes": -6922096,
"heapUsedBytes": 275272104,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 911.462,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 53.051028037383176,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28095.825999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27698.323,
"heapDeltaBytes": -45516888,
"heapUsedBytes": 256307888,
"domNodes": -3343,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 832.693,
"eventListeners": -651,
"totalBlockingTimeMs": 44,
"frameDurationMs": 52.197397769516726,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8231.187999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.00000000000003,
"layouts": 20,
"layoutDurationMs": 28.612999999999985,
"taskDurationMs": 8108.031000000001,
"heapDeltaBytes": -29389668,
"heapUsedBytes": 253450780,
"domNodes": -3343,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 122.85099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.5141242937853,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8249.329999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.606,
"layouts": 20,
"layoutDurationMs": 22.993,
"taskDurationMs": 8141.213000000001,
"heapDeltaBytes": 6180180,
"heapUsedBytes": 283073456,
"domNodes": -3343,
"jsHeapTotalBytes": 20439040,
"scriptDurationMs": 121.74200000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.243859649122804,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11812.534999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11570.83,
"heapDeltaBytes": -3750864,
"heapUsedBytes": 259762104,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 154.42599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.05491525423728,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11673.332000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11430.386,
"heapDeltaBytes": -14463284,
"heapUsedBytes": 264681036,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.11199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.09003436426117,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 555.4759999999987,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.772999999999998,
"layouts": 9,
"layoutDurationMs": 4.971000000000001,
"taskDurationMs": 183.99599999999998,
"heapDeltaBytes": -9661064,
"heapUsedBytes": 60243380,
"domNodes": 136,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 22.235999999999997,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 103.47799999999552,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.14,
"layouts": 7,
"layoutDurationMs": 2.134,
"taskDurationMs": 81.22400000000002,
"heapDeltaBytes": -13447216,
"heapUsedBytes": 60669336,
"domNodes": 98,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6.671,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.685714285714248,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 521.8359999998938,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.683,
"layouts": 76,
"layoutDurationMs": 15.542,
"taskDurationMs": 476.46900000000005,
"heapDeltaBytes": -3245912,
"heapUsedBytes": 42155916,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 230.22299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 572.9400000000169,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7,
"layouts": 76,
"layoutDurationMs": 15.370999999999999,
"taskDurationMs": 523.768,
"heapDeltaBytes": 400384,
"heapUsedBytes": 48701884,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 257.28200000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 582.0499999999811,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.605,
"layouts": 76,
"layoutDurationMs": 14.959,
"taskDurationMs": 551.89,
"heapDeltaBytes": -2809432,
"heapUsedBytes": 82029728,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 214.784,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 630.6610000000319,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.18,
"layouts": 76,
"layoutDurationMs": 15.33,
"taskDurationMs": 597.807,
"heapDeltaBytes": 1730504,
"heapUsedBytes": 105042520,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 249.72,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3150 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b986a7e0fcd781acc3dd6643711f8943f00538c8
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (309)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
cloud/1.59 predates the design-system extraction this PR's imports assume,
so point them at the in-tree components that exist on this branch:
- @comfyorg/design-system/media/Video -> @/components/common/Video.vue
- @comfyorg/design-system/{button/Button,dialog/DialogTitle} -> @/components/ui/...
The Video props on cloud/1.59 match main's.
|
dante01yoon could you take a look? The auto-backport didn't build on cloud/1.59, so I added |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.59 #23148 +/- ##
=============================================
Coverage ? 87.32%
=============================================
Files ? 3089
Lines ? 161740
Branches ? 40720
=============================================
Hits ? 141233
Misses ? 19830
Partials ? 677
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23072 to cloud/1.59, per the requested backport review policy. No code-change review or tests were performed.
Backport of #23072 to
cloud/1.59Automatically created by backport workflow.