Skip to content

[backport core/1.59] feat: check a local workflow against Comfy Cloud and offer to open it there (#23071) - #23147

Merged
huang47 merged 1 commit into
core/1.59from
backport-23071-to-core-1.59
Nov 9, 2026
Merged

huang47 merged 1 commit into
core/1.59from
backport-23071-to-core-1.59

Conversation

@huang47

@huang47 huang47 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Backport of #23071 to core/1.59. The automated backport conflicted, so this is a manual port.

Adapted for core/1.59:

Everything is behind open_on_cloud_enabled, which no backend serves (resolves false). Typecheck clean; openOnCloud, TopMenuSection, billing, workspace unit suites pass (200 files).

… and offer to open it there (#23071)

Backport of #23071 (a676da6) to core/1.59.

Adapted for core/1.59:
- Imports point at in-tree modules instead of the packages extracted on main:
  @comfyorg/telemetry/reportError, @comfyorg/graph-model/workflowSchema and
  @comfyorg/design-system/{button/Button,dialog/DialogTitle}.
- The generated Cloud compatibility types and Zod schemas are added to
  ingest-types, copied verbatim from main's sync (#22718).
- openCustomDeploymentDialog.ts does not exist here (the workspace deployment
  feature, #21587, is not on core/1.59), so it carries only openCardDialog,
  the one export this PR needs. DeploymentDialogFrame.vue is copied from
  cloud/1.59 for the same reason.
- handsPopupsToSystemBrowser is exported from billingTab, as main did at
  the time of #23071.

(cherry picked from commit a676da6)
@huang47
huang47 requested review from a team and dante01yoon as code owners November 9, 2026 09:59
@huang47 huang47 added the backport Backporting a PR onto a release candidate label Nov 9, 2026
@huang47
huang47 enabled auto-merge (squash) November 9, 2026 09:59
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2

  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 3144 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2325 / ❌ 0 / ⚠️ 4 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 786 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 8 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/09/2026, 10:01:41 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since db5b5764b2af60e9e86aa6736c93f9002fd26852

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (263)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 213 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.51351% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/openOnCloud/openWorkflowOnCloud.ts 82.69% 9 Missing ⚠️
...c/platform/workspace/openCustomDeploymentDialog.ts 66.66% 5 Missing ⚠️
...platform/openOnCloud/components/RunOnCloudCard.vue 76.47% 4 Missing ⚠️
...rc/platform/openOnCloud/components/CloudButton.vue 95.83% 2 Missing ⚠️
src/platform/openOnCloud/openRunOnCloudDialog.ts 77.77% 2 Missing ⚠️
src/platform/openOnCloud/cloudCompatibilityApi.ts 99.22% 1 Missing ⚠️
...form/openOnCloud/stores/cloudWorkflowCheckStore.ts 95.23% 1 Missing ⚠️
@@              Coverage Diff              @@
##           core/1.59   #23147      +/-   ##
=============================================
+ Coverage      87.20%   87.32%   +0.11%     
=============================================
  Files           3040     3162     +122     
  Lines         160076   163830    +3754     
  Branches       42683    43970    +1287     
=============================================
+ Hits          139600   143063    +3463     
- Misses         19800    19925     +125     
- Partials         676      842     +166     
Flag Coverage Δ
billing-web-unit 92.14% <ø> (?)
unit 86.59% <93.51%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/ingest-types/src/zod.gen.ts 100.00% <ø> (ø)
src/components/TopMenuSection.vue 86.87% <100.00%> (+0.51%) ⬆️
src/platform/billing/billingTab.ts 94.44% <100.00%> (ø)
src/platform/openOnCloud/cloudWorkflowCheck.ts 100.00% <100.00%> (ø)
...c/platform/openOnCloud/components/ProgressRing.vue 100.00% <100.00%> (ø)
...atform/openOnCloud/components/RunOnCloudDialog.vue 100.00% <100.00%> (ø)
src/platform/openOnCloud/localHandoffProtocol.ts 100.00% <100.00%> (ø)
src/platform/openOnCloud/runOnCloudModalState.ts 100.00% <100.00%> (ø)
src/platform/openOnCloud/serializeRootGraph.ts 100.00% <100.00%> (ø)
...orm/workspace/components/DeploymentDialogFrame.vue 100.00% <100.00%> (ø)
... and 7 more

... and 109 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 9, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved under the requested backport-only policy. No code-change findings; no tests were run.

@dante01yoon dante01yoon assigned huang47 and unassigned dante01yoon Nov 9, 2026
@huang47
huang47 merged commit 127acd6 into core/1.59 Nov 9, 2026
123 checks passed
@huang47
huang47 deleted the backport-23071-to-core-1.59 branch November 9, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants