Repository navigation
[backport core/1.59] feat: check a local workflow against Comfy Cloud and offer to open it there (#23071) - #23147
Conversation
… and offer to open it there (#23071) Backport of #23071 (a676da6) to core/1.59. Adapted for core/1.59: - Imports point at in-tree modules instead of the packages extracted on main: @comfyorg/telemetry/reportError, @comfyorg/graph-model/workflowSchema and @comfyorg/design-system/{button/Button,dialog/DialogTitle}. - The generated Cloud compatibility types and Zod schemas are added to ingest-types, copied verbatim from main's sync (#22718). - openCustomDeploymentDialog.ts does not exist here (the workspace deployment feature, #21587, is not on core/1.59), so it carries only openCardDialog, the one export this PR needs. DeploymentDialogFrame.vue is copied from cloud/1.59 for the same reason. - handsPopupsToSystemBrowser is exported from billingTab, as main did at the time of #23071. (cherry picked from commit a676da6)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
🎭 Playwright: ✅ 3144 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since db5b5764b2af60e9e86aa6736c93f9002fd26852
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (263)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.59 #23147 +/- ##
=============================================
+ Coverage 87.20% 87.32% +0.11%
=============================================
Files 3040 3162 +122
Lines 160076 163830 +3754
Branches 42683 43970 +1287
=============================================
+ Hits 139600 143063 +3463
- Misses 19800 19925 +125
- Partials 676 842 +166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 109 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved under the requested backport-only policy. No code-change findings; no tests were run.
Backport of #23071 to
core/1.59. The automated backport conflicted, so this is a manual port.Adapted for core/1.59:
@comfyorg/telemetry,@comfyorg/graph-model, design-systemButton/DialogTitle).ingest-types, verbatim from main's sync ([chore] Update Ingest API types from cloud@6f5f6f00 #22718).openCustomDeploymentDialog.tscarries onlyopenCardDialog; the workspace deployment feature (feat(workspace): a dropped workflow offers a deployment that runs it #21587) is not on core/1.59.DeploymentDialogFrame.vuecopied from cloud/1.59 for the same reason.handsPopupsToSystemBrowserexported frombillingTab, as main had it at the time.Everything is behind
open_on_cloud_enabled, which no backend serves (resolves false). Typecheck clean;openOnCloud,TopMenuSection,billing,workspaceunit suites pass (200 files).